From nobody Mon Jun 8 08:28:18 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11B8F1A5B9D for ; Sat, 30 May 2026 19:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780170356; cv=none; b=FRHetW0PoILMvtvc91iLWvv3Dv5tPoEftTRo4iWHHp9qUzsAXUIUK5lL3hg9QgiEJhAgu/9TlBOCPjWrEwpBbWIhU4NKqOAbHBj/nrZU0EONJa9q74U5P1w983JEKRIJGTf4a+E7w5h6B7VynHhbS26v8a7MMOO0cxE7ekWeWMU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780170356; c=relaxed/simple; bh=nYlM2G8ceGl3y9T5fnmZhdbw8OoHi6DfQitXHZGs+Xo=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=d/6ai1J4ze6VRPg4855qwMWZK50rZ4ua4T08vKXg9h/Usr9h9XC7V0r+VFFByOnizo8AHyDVMJL8IPo1GUtjD0SctkRsBgb6iz3p5qXh3K7QxanUZvhRr1lWSWnB+c6/gbNSE4j3BS6S+YigBOX15sXH0hN5bCA0sNnjjCQ+XOw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p/6dimAW; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p/6dimAW" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-490a7a9f81bso387745e9.1 for ; Sat, 30 May 2026 12:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780170352; x=1780775152; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=sp2k/2dsuU3p5cNxUvdrCd2ECXlssNRbjfeNkqPWDi0=; b=p/6dimAWFhxgAFQz8VMJid+2/ubVOs/09iXD6eanc2QUidoqI6a5oEuV/wZBJDGAZt DKo0iAPNbqW3x5Mlsmmi0ToI1icHv/7QZSagdxndY27kuNuLUf5bD5DqKC2H2CIWxWLI gkC2UuaGVlUi70nGUK4cgwelwahpqIuAfJ043bIukQ5C3bO6+yJyVJSybbMD/yPkHgyD sY4c4ZNE/LA3uR4ghM2rgQVF6QMAY8pAtZD11zNSeOR0e/5zfbOXZ3MIWrD4ruVtlPnv SRkml10O5eOSOBXknup0ybPH1rpcCVG69RHM4yJwGsd7y2IUZFF9hcye1gQgLrK8pjlA pG7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780170352; x=1780775152; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sp2k/2dsuU3p5cNxUvdrCd2ECXlssNRbjfeNkqPWDi0=; b=X+qOWcg+AsSKIP3EBsFFQEzP9kbqu4EhWPD3jAB8umm413b2iAExJM+bUCDkXE014N vISxOtt3X9aspeZl7SjZX7/ZEn00xxAp+9i7HVVx7tQXqJDVcUashJoR0R5ylMWT7Lhm JR3SaUED5kal/+qoW9uhMSREs0CaIheOnuWxRtG8l2YesOdoYsG9SN11XSaN+VZO3WFK /TOkEqsh1qffVzs8db/t0c/BadEOn52ogw7o/tLu7VJ2sjcva2KC8A3xK900FatHaZPR FZ1BJ0f8AYIBgsLpHwJJTVkE5zSGQutwT3vgoYo5yz9XcLJbpR7QUjvVE/sT6r6jnfFz eu0g== X-Forwarded-Encrypted: i=1; AFNElJ/YrhGaLTiiyyB/uTL4XTUOAMEJFqb4ibVJ+Px4n4SsvDPi6Z6ZIAAoGTvjOLZ8qZ3o+dy7LyvwdDmWHlM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+lzo+yhLTeOT2oJGZWTvLhdYcR9pxeqk79y699Vf+92qSWbuZ 7DxZUoMXYJVrn7cElB0OVeZWNSgWrivBa0k2ePSuinhu7pl7A/yl3rtY X-Gm-Gg: Acq92OH0YsHoWqqAKL9D25jFyc+ZCu4QQ7KaWPWfvs06ZARXg87s60wjI/BmeJfzQ5e FSl2ZghRJqujhCv9Ikg4nKCh0ubeoNyu0pN5LepAVu9rPBhp6c7hKGaJr/LoXHIzYGJcEbYMZMj YW5kSwF1oDBixQLdm4NYkwJVZd7ckg3otr4ytr7kewG16TeWkQhfZOagWfz2DfbVwKk2ZQX5qro URVI9x3okwh43myoIXp2Rin9IxfL8J9foGFZx+P7QpmLtqu80ivyT3lPRKsOhuA3sNevqKS/Gyx JDjwMECsytatmc1HQrqYq7oq8n/xWWCR7oYcsHpj8qKLI5uiza2o+rp7zAW9vOJa61q2m5gAMQg 6JQucwGk1vocETyIYkgKATwvjIP7MSxREGOfKDrDQr04HFAY6TO/IGQnD8rax4Wo5JPrfuTGrDq VCAbD7dczQUP4m6XWC56o9TS1a0Mc7reYmg8ZZfr7hW8VB X-Received: by 2002:a05:600c:314e:b0:48f:e230:29f4 with SMTP id 5b1f17b1804b1-490a2a78973mr64877725e9.15.1780170352446; Sat, 30 May 2026 12:45:52 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909caa7eeesm126175175e9.10.2026.05.30.12.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 12:45:51 -0700 (PDT) Date: Sat, 30 May 2026 22:45:48 +0300 From: Dan Carpenter To: Deepak Ukey Cc: Jack Wang , "James E.J. Bottomley" , "Martin K. Petersen" , Radha Ramachandran , Viswas G , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] scsi: pm8001: Fix error code in non_fatal_log_show() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The non_fatal_log_show() function is supposed to return negative error codes on failure. But because the error codes are saved in a u32 and then cast to signed long, they end up being high positive values instead of negative. Remove the intermediary u32 variable to fix this bug. Fixes: dba2cc03b9db ("scsi: pm80xx: sysfs attribute for non fatal dump") Signed-off-by: Dan Carpenter Acked-by: Jack Wang --- drivers/scsi/pm8001/pm8001_ctl.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_= ctl.c index bb38b2d63acb..a27f3287748e 100644 --- a/drivers/scsi/pm8001/pm8001_ctl.c +++ b/drivers/scsi/pm8001/pm8001_ctl.c @@ -588,10 +588,7 @@ static DEVICE_ATTR(fatal_log, S_IRUGO, pm8001_ctl_fata= l_log_show, NULL); static ssize_t non_fatal_log_show(struct device *cdev, struct device_attribute *attr, char *buf) { - u32 count; - - count =3D pm80xx_get_non_fatal_dump(cdev, attr, buf); - return count; + return pm80xx_get_non_fatal_dump(cdev, attr, buf); } static DEVICE_ATTR_RO(non_fatal_log); =20 --=20 2.53.0