From nobody Tue Jun 9 00:58:48 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3BF23BD62E for ; Mon, 25 May 2026 07:16:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779693412; cv=none; b=r8n0k0D/Ufgh92uXe07TFhXvwtDm8AMx5WvuOV88eaBrEivwP4u0DGq0VAeTPiV1yqmKCT5BqcTRx1zSGfQD1QI9zNc/UWtNNWAoauPnwdsLH21zEQ5ckzKI+lFXFCGrDUhhJvKv7myM5JoI5br34UChVQO9mQ8CHgqTfW/8Pgc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779693412; c=relaxed/simple; bh=PgsGEZqzA7VFFuqMV6HnSLX0QnAKaqzhdZjk5ZoF2vc=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=ltOAeh+5a+JIykjQpj37TkCgvna8iTq5o/VHlbOu/Bk0DmiMOjHFWk+T3+o0GoNyXGCCFohV689xKoDo2rMTUBHUdGkHoURQd3HmxBOxY1lVxFRQlrZTv9sOywpfTvusNOvHdlBkHLQq+cuqXzCC6Ua+BQcqeASsWNebOfao9/Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hlSF28i/; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hlSF28i/" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-49050ff7cbdso16062145e9.2 for ; Mon, 25 May 2026 00:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779693409; x=1780298209; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=24zthJvGUKXcZPIu9w9sob21/I+YzFqoj+uIkca7DtY=; b=hlSF28i/xtBWRX6hInZP9pnALpE76JmRSIIc90IXFK9xk+b6EIRMEgdPKW3hOwSgYR TZIGkOKSRuMV5OCmOh8zJsvt8iIqr44sG1LBp0W+zR6CQO8qalq4yRxSgh92cLJW2123 jp2Q+7tUWf2fAyLbD+V3bOA7PucpkGHKVcNwKxjO6gYjY1RgId0d2GDbc6J7r9fiB9r+ bo8wtZa603jN82Ni7WuHRRXCBV5LmlVnT9nlTNQh8uACPz3x3jYp28pl51s1yRSFsIX8 zGjQtpQKwI0EnUntytWo+/f4lYlTC2d5gZFv6kSiTfYg2tOExK601jgcsw8eIEHz7sKC 0+jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779693409; x=1780298209; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=24zthJvGUKXcZPIu9w9sob21/I+YzFqoj+uIkca7DtY=; b=S0Q1EHwFIxjbFOhHQjdIzEgPUbmgYMjdAT+FkSSjBePdQ2AhyEFcTdq6GNnisXurto NAHclkw9b+AGF0wq0/y1+5YoXTttXc+8wz+cQ7HUckAr55LbEMSky6+iDluuqeOV0oaF 0xihLAtBo7Mx8jLN3CUndcCOG//6MYBumuRAkX3motyNvEI5ButDY+RI3GPpSFDjzKwA +4ZuK/Ce2kTFCE72ioOxmwvhUsqE8y4SQXHksKx3KyN5d8rghqd1tpClARQYKAJ4ItA6 kKvzB+pEaxdpinYvmzwOjpQDoSC2DWi66Ime7LlZAoMJCn7123rg4aeZ9qGtS+qKrWro tfDA== X-Forwarded-Encrypted: i=1; AFNElJ/j6jO3TIijkhvLVvstZA/Bc+KRyF+D2FoymMrmX4maVC6b9lTgSWEhMOKzkV+VJMcVrzsWRL6ZURN00sM=@vger.kernel.org X-Gm-Message-State: AOJu0YzpfgZCmuZVu3EHkZXxR2auajySd/wwuRYUor8OmehDbU6ohVrm n/AncLWTc+U7xJOaBicPHC3Vi93sSM3t3phPLM9u0Oci5B6MYwAdq6q9 X-Gm-Gg: Acq92OGRrYvrhkuAUQRMC3+YdGFblTEEGJLbcXiF0hx21MOOdnUSH9YB2Ksjr5jj9ao U2N4RtAoiJVmTr5Rs3DKpfeCU3UBYOSTIp5SXDHkbAm4nHakHURgMXFwlBh8HQRBhW3qAS1fGnm rvsbxs5OTcbfsn+eai72pTxBwKVwCNnnaYTc30n4UICtj7Ob1H7cobn/uAl9GHh3s6GYUUBBeA7 qHA9Mr9Bi1kqvf5WeHDxhmLmLIAcBaiSXkk4DjqQobNSsh6WhDK0fMMv2yBPzopE6DdxAlZaDrE gHzyb6gkNtHsfjRuUxbTRFHo5yLS+3AOmpXgbjQghzIpeQa7Z0BIqbatb27ij5oY+wr6AxJ/Nmm GGBfgGZ3HWi0Sdft74FeEv6vewsy1xIarXQ+CMi14pnwuzExP5pQnRnCmYRQCdNTbonAxqbSdu/ RnW2hL4AVQujsppwcPyQwlLNvnzUIy5K2GoIbMqCpIhOoi X-Received: by 2002:a05:600c:4510:b0:489:1c1f:35df with SMTP id 5b1f17b1804b1-490424a682emr203079855e9.10.1779693408960; Mon, 25 May 2026 00:16:48 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6cd1780sm26456454f8f.16.2026.05.25.00.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 00:16:48 -0700 (PDT) Date: Mon, 25 May 2026 10:16:45 +0300 From: Dan Carpenter To: Sean Anderson Cc: Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Michal Simek , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm: zynqmp_dp: Fix uninitialized variable in debugfs() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If the *ppos is non-zero then simple_write_to_buffer() will not initialize the start of the buf[] buffer. It doesn't really make sense to allow non-zero values for *ppos, so check for that at the start and return -EINVAL. Fixes: 28edaacb821c ("drm: zynqmp_dp: Add debugfs interface for compliance = testing") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp= _dp.c index 7fb11b0a44f0..847179476041 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c @@ -1888,6 +1888,9 @@ static ssize_t zynqmp_dp_pattern_write(struct file *f= ile, ssize_t ret; int pattern; =20 + if (*ppos !=3D 0) + return -EINVAL; + ret =3D simple_write_to_buffer(buf, sizeof(buf) - 1, ppos, user_buf, count); if (ret < 0) @@ -2028,6 +2031,9 @@ static ssize_t zynqmp_dp_custom_write(struct file *fi= le, ssize_t ret; char buf[sizeof(dp->test.custom)]; =20 + if (*ppos !=3D 0) + return -EINVAL; + ret =3D simple_write_to_buffer(buf, sizeof(buf), ppos, user_buf, count); if (ret < 0) return ret; --=20 2.53.0