From nobody Mon May 25 03:33:12 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AFA837CD30 for ; Tue, 19 May 2026 06:13:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779171220; cv=none; b=WSvuHwqt62fYIGD3aQFiithteTYvR3/eJoyaCgPuqg83JRmDmiQl88w+XY9GQfvGTSJ+3IJ/Mvd3pikEgLNhGeIfn8iJ/IzLAgyQw6Q1zuY6dnj/R/RZ3+HESfC2DLekiuRHKwk8Xqys5LnO2csV+JPwpXjH0q7kpH14hutgFC8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779171220; c=relaxed/simple; bh=BkN3e60PEXdoyx0mx5F/cbqqVlK6TvHKD+Ae3IxWR58=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=be39DhlqwmdSoLNy91AyPVrWJEDFATWJTVhEaIBKYY3L+8jXykJSGw2a52BNDhLZdIuoNdL/u8ANPMmWPQFXcCR65C2E9VReGcpQ+ehP1GaS9cVfObHTzhb+J5q8WuLlz3nyrzlpe30FCgDG6khPxzIu8WazNmF/H6V0/j/nlOI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fJojo2Oz; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fJojo2Oz" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-44b330c5cc6so2217993f8f.1 for ; Mon, 18 May 2026 23:13:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779171218; x=1779776018; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=bqjUL/F3PkV7mQ5AZkxkB+XxR2b2VNgyAxYreLVSeSA=; b=fJojo2Oz6Mxa6lIJFFQzyDkIBKBQa9SBAl+9PX6Ql7ufUp9AcbPse1W9jK5XdCd6Jf zTMSs3xKF+6+ErYBnkKrA9LnqVy4Vp55crWUU1WuTho2K4W1e+UcNqeqowSbrZy5wGS1 LfFAZmTseTS0Xs9i+Py+GHRwVDaBDL5bbFcK06le8+Ft50L81cz5gUwDJ+ptEn34Vu6Z FcZuse1UoIKKqUbXtubeaaf6sV+OE+rDwXyceo04WSMuZC8zfQopZqJZ/FW0eDoYT3LF FOoKEXdQKcGK+NbxrpTbPKjrolCBkCfJR3NMyKkiV9RhrwYprHRLBgg8L+0skwe6LqBh 4IgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779171218; x=1779776018; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bqjUL/F3PkV7mQ5AZkxkB+XxR2b2VNgyAxYreLVSeSA=; b=QbzP1N+rBgAF/GJE752D5CN4FcbwScyXqz1h8ZGJB1S0qMFDlvhgpToAfwgnRhUMDQ 5InIL0G7+ZbQUJ8obC1mUZqLDgkQ4lgBBUSYydRQ1w4sk15tZnSWGgRY/qlodiTjVBmK MFBuMLeSfeGgmBTjuEiXpnuxtt2CZkw6G5eUWsfhKb3fNrBq7j2Igx1kVrinCNOjtpCa bIzQz24v86MSbcgiwYQ+PRrxPaYqFoKlVnlRezL35UpcXuOmFXd+AQ55+fISZXRzBoYJ RrzmqtcG1nUMb5aD0DrWYMRd2m6NrBC6e896XaTduGIvHLTbw9ubB4TUr6Mk1cPVpgVL KGxg== X-Forwarded-Encrypted: i=1; AFNElJ8kWR05NTQvt5+lhwC8Waci5+mtuBZq1V3JTQb7vwYLgEAtNNE36F7h1IYUkR/pYHKBx+ifHazbVlAJ/2A=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5D8Wz5KqtFMWgO83SJU+Q0afAy+KS3eLL9OmxU0tVR34jXAI2 wIa473g9ino2+KcNxWe21YWk+NsRO6JpK5D2ifRSessbJs/vCPfxusEX X-Gm-Gg: Acq92OFTSTTDCEHgXxUGe8QQAt4EDdOEPxxuCKuRkrdT72a3X4Xi2pAG+2Gb3SM0v3f mpPbRF6I0TLO3DOIrWC/vF8N4zirN1gpSI18ULxhG2b9kuYoPAaVZ2D5p19lNUeHOXSoQoL24FD oWOeqczqVcI+VvyuvUS4Lz24OzoaZW5ZRFllOstTI7YTdN3uwsPyLIYX/D1swtkypZzEZswuQkp SJhimMzwXgyVil1my9hfqD+2G1Hf7FCmWow5XVOrq7b+BBOkD5ga7/YOJyZOf7G2YCDlP43Ii/2 TTSOJeCO2ZOIlMwaseD59+xZQTLQ3LqaQG/bmCTfYHYnhTcJXBg/wR9EnvPuiy5szDbH/T32+f8 OLQJtQnNu7Pt6/g/up7O/a8yxQBlyx2+G1g3RQF0mYL7huShyKmuWzMhZRRKj0NUlP79caI/EuI UlpNXkFTcNKfakys0IDIQ= X-Received: by 2002:a05:6000:4021:b0:453:e3a1:6580 with SMTP id ffacd0b85a97d-45e5c5fd95dmr30269534f8f.25.1779171217859; Mon, 18 May 2026 23:13:37 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9e768acesm45974707f8f.7.2026.05.18.23.13.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 23:13:37 -0700 (PDT) Date: Tue, 19 May 2026 09:13:34 +0300 From: Dan Carpenter To: Pankaj Gupta Cc: Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frieder Schrempf , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] firmware: imx: fix use after free in init_device_context() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a missing return statement on the error path. Otherwise we have a use after free when it dereferences "dev_ctx" on the next line. Fixes: 63536a73a3bb ("firmware: drivers: imx: adds miscdev") Signed-off-by: Dan Carpenter --- This was in the original fix but I guess there was a merge problem. https://lore.kernel.org/all/20260514090457.2186933-1-pankaj.gupta@nxp.com/ drivers/firmware/imx/se_ctrl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/firmware/imx/se_ctrl.c b/drivers/firmware/imx/se_ctrl.c index 9327d47e4312..010af8221dfe 100644 --- a/drivers/firmware/imx/se_ctrl.c +++ b/drivers/firmware/imx/se_ctrl.c @@ -486,6 +486,7 @@ static int init_device_context(struct se_if_priv *priv,= int ch_id, kfree(dev_ctx->devname); kfree(dev_ctx); *new_dev_ctx =3D NULL; + return ret; } =20 list_add_tail(&dev_ctx->link, &priv->dev_ctx_list); --=20 2.53.0