From nobody Mon May 25 01:14:39 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20C23346A0A for ; Wed, 20 May 2026 05:59:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779256776; cv=none; b=fzeB5gKt+p+J94Z6caXVFY5mkKwcMhuFKjN29JSVIllYcphWO1nVoUaNwiKTxBlHhGb3s+25Q+FvzPr213F9otG2ggWwBr+7gNPA7RoL0leK8AZqWjc3k3tW1YWpwuPlgeFw7gyjL+umFkrs/BnxJZLfq0oAyrv2uk/RpbzkIEo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779256776; c=relaxed/simple; bh=2f5OUImFmuhrF3x72G+LTN7IOvpnkhPV9gMr4mx2qz0=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=IeuhsjieR3YVu5h8z7X9wzVC64RF+3cSMO5EzhDwTCzWhdcDUhhQmgYKAsQZB0rNMMuOpjBf8wPMnRPYgTbX+6iBghV+2JVuozXOr9yX1jdgbq2yTX8XMTPI4VbXrkq9PD9Ldb8CGtMzQ/VwdyjFym9K6mYb+C4RPwkT9FzfCp8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kkyu4WRZ; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kkyu4WRZ" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-449de065cb3so4052538f8f.2 for ; Tue, 19 May 2026 22:59:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779256773; x=1779861573; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=Gnm8zcvKAshSvXmnApGnkudHEo/9J/+vPZuXibcqvww=; b=kkyu4WRZQ2nLjW3vWF5k9Kk6/hKNxy1pPtUBwEjAbSNWTxkhdnzPExnESg0z648AhO rGjFlqWgTfmygyQSJ2z9+ehGFyrBm3B9lk66q/tzL3irvaufJ6zBynqLrxKBzBUc0Je/ fUbLw/JsCDkTioM7bqZ7dxtcNBl04o+4uZZGYDR2F1nb+NMpHKAz26egctEpsrXHsZfA LM5/JNGbvJW3dPvHyari0c1waaWKJAFBiBBUOLBcB4Cz6y72Hv+BiCNzx7t0Hpomnazk CQjJIKKPxSsbOZzzxo+t+NyCnvsn+hsZ90KkpTUSem0sQB/HTqTzHGoNdKzg58mE12GG VTFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779256773; x=1779861573; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gnm8zcvKAshSvXmnApGnkudHEo/9J/+vPZuXibcqvww=; b=jnxR+sE8dtvlVP2Pqh4gjtUn+eAdhsKs0bTBQOGyxViJ26E4ZThnxlhWwlyDGV05vh dXziwsAKHUZ/XdTx6dCPaKnphjYPqjQRpCVKwRj7mRGSITD1aDyrY3ckv7bsWwAVl7T9 p6NIK5XfHf/h3DhAbT/HzKhKc1eABBNZQM8+0fDT4pyDYmOpGuP27mrRehoSYK9rItgO xVZCQgnsfajQq4rOKwNQNiBMKvRzPZzZTe++5AjsMEvn3p36ABDIyVIAdv8BFXrsrY5j jsPo8gwxMBsfuU+niI/OLB4NeYmad5Ieq24RHZc4BReGyH0eioTODGllti3lyLGgo2jk SFlw== X-Forwarded-Encrypted: i=1; AFNElJ+x1ZG7VVwwJ+iJXeUytd3MixZnX0u1anw1V3A/6CZuR8wPxgYU5FlDA8DmpMHJIJyj2JRYspsKjb35d30=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5yn1e2UOsEwawuQkIa1Cic/KVMejs7drKj1kuYZDSbvvYitGo iplAkgn3qIQcM0zzLhItK9rVYtras8clU/X0vusgSQPhhSTyHSo8z0jN X-Gm-Gg: Acq92OGU+QsT0zF13NTSFpiZZ6URPeHz2zwW1lit9RuBa/A7HhUTtym4rGlgOffosC1 CEKczgwAPgRvrG7bXtbelX4a6VxaT+TMqE3pI2QP/CIubimBjjIQ/Jnq02HBud4H6zv5scPa36W uDO4H4qAsPMCxVBv6b/rHnBIl2Bf5R+IFcCre4oBw2jyk03AYgNbMeENK2n2Aa2yLoYKWjwHBRt e+w3u/gg4xPQ0C+elTtp0ahCojXXUcDMKSIQZEGDN/mWy34bwsA12kzY7YLI6gdcgDgVylhjDUi LNMHt6seBm+A2/DuvufASS1HHMdALrQDW9KPXdAb+fmM+hyn5XwcRDLLDSnDYAmy1ehWg42lsna cUWXKG6PFqvOlUJwdTHlAKHtBnAhhhzLOTI0P+Ry33E6+VFK6jAjPgf6yAh8Zh2NKknP1Lsu0aW twU0k5PtopM1ytW2DjnFU0ds8= X-Received: by 2002:adf:fa85:0:b0:45e:739c:f186 with SMTP id ffacd0b85a97d-45e739cf80dmr17301878f8f.20.1779256773468; Tue, 19 May 2026 22:59:33 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0a17a22sm51207565f8f.22.2026.05.19.22.59.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 22:59:32 -0700 (PDT) Date: Wed, 20 May 2026 08:59:28 +0300 From: Dan Carpenter To: Paul Zimmerman Cc: Minas Harutyunyan , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] usb: dwc2: Fix use after free in debug code Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We're not allowed to dereference "urb" after calling usb_hcd_giveback_urb() so save the urb->status ahead of time. Fixes: 7359d482eb4d ("staging: HCD files for the DWC2 driver") Signed-off-by: Dan Carpenter --- drivers/usb/dwc2/hcd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index 1a763ad4f721..2414291aa908 100644 --- a/drivers/usb/dwc2/hcd.c +++ b/drivers/usb/dwc2/hcd.c @@ -4804,6 +4804,7 @@ static int _dwc2_hcd_urb_dequeue(struct usb_hcd *hcd,= struct urb *urb, struct dwc2_hsotg *hsotg =3D dwc2_hcd_to_hsotg(hcd); int rc; unsigned long flags; + int urb_status; =20 dev_dbg(hsotg->dev, "DWC OTG HCD URB Dequeue\n"); dwc2_dump_urb_info(hcd, urb, "urb_dequeue"); @@ -4828,11 +4829,12 @@ static int _dwc2_hcd_urb_dequeue(struct usb_hcd *hc= d, struct urb *urb, =20 /* Higher layer software sets URB status */ spin_unlock(&hsotg->lock); + urb_status =3D urb->status; usb_hcd_giveback_urb(hcd, urb, status); spin_lock(&hsotg->lock); =20 dev_dbg(hsotg->dev, "Called usb_hcd_giveback_urb()\n"); - dev_dbg(hsotg->dev, " urb->status =3D %d\n", urb->status); + dev_dbg(hsotg->dev, " urb->status =3D %d\n", urb_status); out: spin_unlock_irqrestore(&hsotg->lock, flags); =20 --=20 2.53.0