From nobody Mon May 25 01:15:21 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39E7124E4B5 for ; Wed, 20 May 2026 06:00:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779256837; cv=none; b=LaHxlxCKkwRzB87GZ1JzfngxuuMpHr0pQmQ9yij+VN367sFz8144RSHO++wyipKQpH6zGEgB9KJ1k02Da4quFaDoECY0wqnP5dDXR5vAuuravvWldN/dE+CzvyifAZF8w3J9wC+A/6dZmpVjkDMAHq+ZFHFJN7hxU3cJeDzb//U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779256837; c=relaxed/simple; bh=PwdFhbnaIbvzyL0ByKYE7HETeCMGZAIbkeJSqweSa40=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=EBc3KvTGQW0TYNLQbd8Va6IVVTP8iPkbOd94lM8jTv8857ojqYeG08vMnGMbeulwUd/rWVkMkn+z85UhbqhRTE5+SOnvIqW03OA50N2i4kBbm0cCmuU5gBhUYMbLRf6gj9gjI/sF41eeVUmL9hB7HL+S4uJOC8zdNJOwcbBQc18= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rRuM7iLm; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rRuM7iLm" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-488b3f8fa2bso42934335e9.1 for ; Tue, 19 May 2026 23:00:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779256835; x=1779861635; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=B6h5aMTMM8bzIWFDjN53bSMUWPzwm9wWidLlXx3yYUg=; b=rRuM7iLmZ9hqTroKGQqzpwOggl9f9djMT0YcNIzugBySJ7TCV3RV+murkL2Gk7Ha9o WBRZGa8orNsoIo1HEVeE2WULyqkD6equIdBStlPxHrVyalB3qTfQyUIZrHfCt+DHxl5p cHTAIy2Ej63rIyUKjvHNL/lDl/lHkIF9X8Qf/ofpKPxwtDdiMb+CS92lG+n6mfDjJZUa 2+YlkDgNlOcB3vzk4KWRcokaJi2+K1mEWz+OtEBN7B7ZNsQG255SaqxXpnRzlKA2L0vT lM5I8NAEh54dxDK787zxnlE1Mh+hFFFXxLIcdXJF+C+R2GQovmUhj9cIuVGiqckxC68N foDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779256835; x=1779861635; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B6h5aMTMM8bzIWFDjN53bSMUWPzwm9wWidLlXx3yYUg=; b=DhVTSUhr0Ex/VF20lBGAKJk1UIYZ2ojwnI2zsGy4fyjcca0GW+J0xI2pR+Goh44wH0 /ZZZc7rX9LvPjo3L01hIPeHqrVQvgcznFzvPOP4ke1EFqV1IliYZ0fJ0i10hwUhEkj63 L0knws0s1rxiigkfjfr3azpIKp7Rf/UjlBU6QBwbRhEO2bNHM1X5/WW+FlSdI2NGUvhu Ol4adfN/NP1fZvIKLJ7pHlfuGGB4IYSt7+sOZ5KTKxlqO64kISEL0ljgwvQXaCvDRoU3 z8zzzhGtyKV9d/1zRGTOKBYZfa/xo25ReFB8Z5lT49ebVdMNbBKRFv3I9ZpVUaxXPmPw QXMg== X-Forwarded-Encrypted: i=1; AFNElJ99atW7IcG0LVujgM7re2RlYnyG519xJFWkRxKiB3uYsXXZSZR3kowjD3ur8FKmtqnSenC3C9OIV150z1I=@vger.kernel.org X-Gm-Message-State: AOJu0YwWyN2/fKsDpzB/TKhD73WPze7mE6g5qM5gMFQFXYyMUwcIqBZA 4b1ODQ4D9IRmOA11osKJ2ZjxEOvsXyAnkgb+bBXIY9pSCi9T8+GFsfcL X-Gm-Gg: Acq92OGhjHnpluUXlEoz7ohRBBrdhWN+2+S/yWnz5CITDCfAJg+jC7xSEkVf8FFVh6M Ny/96X1tcY08sjIdDIIWrhGOZa6oMKRRca3UCnRUOyz7nFYLVHaBLGXeBqxqsZw1pVHOH4n6a3Y T0yHL77nwqIBTjvHomuHseDQM82C/5yYY1y7Lte7Bi0LM5e4O742TqA9hACiJBJ1xOJKQrAXsXt 6vBLs3Pj716j4CxiyjvUCS/8i4/9TIdj+aulPf4MHXJWAVGasUUQ89MgEfUx2vFal5gyUOikbgk at63sY6zzZCbuP2D7fQLrKO/VnCoVDlXCkD6mlMFe9p/J8W9PwvgIyH0jWKOJDI5b/pqJ3I28nP OFZUHzYSRb6ldQKEWOaLfxF5tSEOm5/IMqwrGpu8QN1pfOCUuwci/i2PQ/cFuOnOGKiby05G4la XDxzNUbGQW5MkNM8x4OZ8wWrGsjNFkJhguaA== X-Received: by 2002:a05:600c:c4a7:b0:48a:53cb:8604 with SMTP id 5b1f17b1804b1-48fe539519dmr330248945e9.14.1779256834204; Tue, 19 May 2026 23:00:34 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48febf86db7sm185387655e9.6.2026.05.19.23.00.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 23:00:33 -0700 (PDT) Date: Wed, 20 May 2026 09:00:30 +0300 From: Dan Carpenter To: Francisco Munoz Ruiz Cc: Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] soc: qcom: llcc-qcom: Fix NULL vs IS_ERR() bug in qcom_llcc_get_fw_config() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The devm_memremap() function doesn't return NULL, it returns error pointers. Fix the error checking to match. Fixes: ac23106a9b9a ("soc: qcom: llcc-qcom: get SCT descriptors from fw-pop= ulated memory") Signed-off-by: Dan Carpenter --- drivers/soc/qcom/llcc-qcom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c index dcc08f63e020..2006bfe198ea 100644 --- a/drivers/soc/qcom/llcc-qcom.c +++ b/drivers/soc/qcom/llcc-qcom.c @@ -5231,9 +5231,9 @@ static int qcom_llcc_get_fw_config(struct platform_de= vice *pdev) } =20 slc_mem =3D devm_memremap(dev, res.start, resource_size(&res), MEMREMAP_W= B); - if (!slc_mem) { + if (IS_ERR(slc_mem)) { dev_err(dev, "Failed to memremap SLC shared memory\n"); - return -ENOMEM; + return PTR_ERR(slc_mem); } =20 ret =3D qcom_llcc_verify_fw_config(dev, slc_mem); --=20 2.53.0