From nobody Thu Sep 18 17:15:48 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19C9EC4708D for ; Sat, 3 Dec 2022 16:49:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229838AbiLCQtz (ORCPT ); Sat, 3 Dec 2022 11:49:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229756AbiLCQtx (ORCPT ); Sat, 3 Dec 2022 11:49:53 -0500 Received: from smtp.smtpout.orange.fr (smtp-11.smtpout.orange.fr [80.12.242.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CAE820BD4 for ; Sat, 3 Dec 2022 08:49:50 -0800 (PST) Received: from pop-os.home ([86.243.100.34]) by smtp.orange.fr with ESMTPA id 1VhypqniCap0Y1VhypzTXS; Sat, 03 Dec 2022 17:49:48 +0100 X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 03 Dec 2022 17:49:48 +0100 X-ME-IP: 86.243.100.34 From: Christophe JAILLET To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , netdev@vger.kernel.org Subject: [PATCH] packet: Don't include Date: Sat, 3 Dec 2022 17:49:44 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There is no need to include here. Prefer the less invasive which is needed for 'hlist_head'. Signed-off-by: Christophe JAILLET --- Let see if build-bots agree with me! Just declaring 'struct mutex' and 'struct hlist_head' would also be an option. It would remove the need of any include, but is more likely to break something. --- include/net/netns/packet.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/netns/packet.h b/include/net/netns/packet.h index aae69bb43cde..74750865df36 100644 --- a/include/net/netns/packet.h +++ b/include/net/netns/packet.h @@ -5,8 +5,8 @@ #ifndef __NETNS_PACKET_H__ #define __NETNS_PACKET_H__ =20 -#include #include +#include =20 struct netns_packet { struct mutex sklist_lock; --=20 2.34.1