From nobody Thu Apr 2 01:15:56 2026 Received: from mail-yx1-f51.google.com (mail-yx1-f51.google.com [74.125.224.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BFD11A6814 for ; Tue, 31 Mar 2026 02:20:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774923654; cv=none; b=q+OeJAHGgFc7y8Rro9WZWYhYsLcEL8ytUz9ffVkUrObnSeEZZWzVotroeWOd42WasXc+rxHAzRrByoFOYZ/zKrsr+lv0ixHGacUhxAmc9/pjPnCIaE0pgmGmzpajPvjGujBPFOIS1vRJKYPYkaDx4t7giRAin4CxKlEsWMrhDQU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774923654; c=relaxed/simple; bh=xWfbA/b41dqUqeYggRy7GHl+5b94DiDfVOk838lqMe8=; h=From:Date:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=HlDmxBI4emGIVNO+pzJfuqnZWawwTHMOPh6ymCR6lPBhsBQLcENAh2vKzTn0mSRLSwGxDA1p2E5D2ASydYpmQr8yd2wQGEMOgHHP9x3dtJXyebfT0ZZQJldzInjNc/iCI/FLVRKZsrrhS5UwJkreRickgDWQu97naXXIyf6kyQg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O+QRVraW; arc=none smtp.client-ip=74.125.224.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O+QRVraW" Received: by mail-yx1-f51.google.com with SMTP id 956f58d0204a3-6500040ef85so5763575d50.1 for ; Mon, 30 Mar 2026 19:20:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774923652; x=1775528452; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:to:date:from :from:to:cc:subject:date:message-id:reply-to; bh=YxLew5C5VXtqmnFAJHo/mT9jMZ2okWzhT0EADGBwUTE=; b=O+QRVraWW/p+vU6soDidmFibfLEP0mopNKvXGR3ADPZBhO3UhJa2UtMSCwua/yXSDK mGF2xKNc606iuxFT+bgDoDHSpqxnyxpi4Po1liYzchfJR8TxpxcOVx0dfOMWAD6r/fT0 wCmBEa5aT2cqDkkqhS6NVvqcSRHLsb3xppqbx8v+USjvRe3FbzXBavW5Yd2a9fYLBVRl 1eOxL7caPAu2r0yKHs5BIF/KBqNf+WWySx2q2Cb5fiEaa4HWcSy8N/Iz0muHYfUehbFN z1gpAptXJXlWSVGihb4K8ht71h2WU7PAuu5jiG4WPeQsQdjMlBEGnkarQp9wkSDaIVdz /LGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774923652; x=1775528452; h=content-disposition:mime-version:message-id:subject:to:date:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YxLew5C5VXtqmnFAJHo/mT9jMZ2okWzhT0EADGBwUTE=; b=s/mazJREjHkscdoj2nOesS1cHvSmuro7Vpb/Fdwu+LqoVAkKHLPxZdXrW92chohNu0 NCNmVdG/pDUsYp4Okx5FJyLOFGaShHOJXDcZ9UR+PaWzvDvRTonSIbaXtKtHhqtHQmmF hgk/rH0vwrtvcMMlW8nLh7XuQyqhEtjz3uIK7k2zHgN/qZuBqq2ErNi3WfWy6JGdg9df P2QfnPbOdMeTMGRCEsu5bng3vdxB+RJIRVriA3Bh3eJOxJafBqUkC22AK3emvMmJWnqt Uhqcdq7KxzMzUpajMrBPVjgVYNPo1TjT3X+xRIBKZcrf0eujU9PNETMMPKe9V2bLAKRc L+0A== X-Forwarded-Encrypted: i=1; AJvYcCUdHN/rPw0uY3j2x65+3I+Ngb/55cjbwHZYi0ZZEEgPHWCsh/wHR+C5Wz5ya2jjHHaIvm9y1zxcHSKUqq4=@vger.kernel.org X-Gm-Message-State: AOJu0YwWB5pwZx0fElmzWsqZC4ZBB9DGNdJzheh32Wt/qlEd7Pu1z05P Vhrf/BcHj5CT942IPVf2B4HcZ0O2VHBZNP9Y+HIerC2xZJaXe4CVk87J X-Gm-Gg: ATEYQzycssjPEA+dcM+dvLY6iMyIlponnI+qgeS2zoNan7XSKVL98GnmTUTzDQGjFVe hi+3ygYXWvLO2Ly41ReTje4MbqY3mkygWM3jyoV176y+3EYbpKk/51MMTZ0Y6JIg6GXS2Wg7x/i tC6Y+BPhQ9pN0R7+00Pls7hwv6lYv0j/E56eOuEsT890rGdcto7AhFt1Ax1YqchSBJHVXoouw4+ eNcLVoPbZbg1FPyrABNytDaXtZM5hY5xc7rbrfzB0g2SPNmTyYnT4HEFnpDJNMZ0NXZoThoWjcN Q/+Bl0+v0qXUVDXDoO4EHe/8nlLZ0cGPo87rbGtG4y53XCaAVKHhhvJsTLCPNfD66PUbitQkwc+ YdOc5ukd+zDDgTQmowIbe9BMvaFhh/3c09YIs19sSNP2BPcNPa/aRNNlOozDs0YjC6+lii9rDcV xvOHk4M0iS4txJ4ZMv1mQWhDCoAB8QPzBSZTxjG3B4/O49kY1wg4ndSgz6lkH/6Yue+1Q9yg== X-Received: by 2002:a05:690c:dc5:b0:79b:e346:980c with SMTP id 00721157ae682-79be346ad82mr145977167b3.12.1774923652314; Mon, 30 Mar 2026 19:20:52 -0700 (PDT) Received: from tradnomic.core ([2600:1700:6e30:be0:2534:66a9:45be:e121]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79cba0778acsm43743777b3.33.2026.03.30.19.20.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 19:20:51 -0700 (PDT) From: rafad900 X-Google-Original-From: rafad900 <19312533+rafad900@users.noreply.github.com> Date: Mon, 30 Mar 2026 19:20:49 -0700 To: shaggy@kernel.org, jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org, syzbot+1d096d31de6a0491b55e@syzkaller.appspotmail.com, skhan@linuxfoundation.org Subject: [PATCH] jfs: fix null log dereference from sb during readonly mode Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" #syz test Clearing the inode pointer is necessary to ensure no memory leaks after txBegin fails to initialize the superblock during read only mode. - This error was found by syzkaller - After ialloc() is called within jfs_create(), the inode pointer is created but never freed when txBegin() fails. - The patch addresses the need to stop commiting a file=20 transaction after txBegin() fails and the clean up of pointers.=20 - The patch was tested on QEMU with the repro provided by syzbot Signed-off-by: rafad900 <19312533+rafad900@users.noreply.github.com> --- fs/jfs/namei.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fs/jfs/namei.c b/fs/jfs/namei.c index 60c4a0e0fca5..3a5f45cdeae0 100644 --- a/fs/jfs/namei.c +++ b/fs/jfs/namei.c @@ -97,7 +97,13 @@ static int jfs_create(struct mnt_idmap *idmap, struct in= ode *dip, } =20 tid =3D txBegin(dip->i_sb, 0); - + if (tid =3D=3D 0) { + jfs_err("jfs_create: unable to create tblk due to read only filesystem"); + free_ea_wmap(ip); + clear_nlink(ip); + discard_new_inode(ip); + return -EROFS; + } mutex_lock_nested(&JFS_IP(dip)->commit_mutex, COMMIT_MUTEX_PARENT); mutex_lock_nested(&JFS_IP(ip)->commit_mutex, COMMIT_MUTEX_CHILD); =20 --=20 2.43.0