From nobody Fri Dec 19 19:19:25 2025 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 729AD33A9D9; Wed, 17 Dec 2025 07:31:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765956708; cv=none; b=BXCAef7aGN3zlFBg13UmnXa19p9if7VA4jfm8Odv2Z/cukJNusxRM0YlNIeor7f/9aQg/Q388RbnuXa9Y47SR8s19luFsZ12mKa3NO2jo4mH2xIav7qAH+Icm9XuDXraNTsREz6F/dABIXB3uUOB7/3dnMROs5Li4iSVhpLrDWw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765956708; c=relaxed/simple; bh=rbr0d8jBiRsl8AdGg9Qf16262/nqBn7Sep4c+qa2ZBg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bqGdTgLxdFOdCjLbajWc/YSa4HzMwyl50Ckvl+dEPLXamlPI33QGXdCic755ybSC/gbGLq+J3VqiHMbiJvBzz0xmCJAkk+69B3gPfRzzlpwBaLazIEsZnTKpXbuFV5R2lkoxTgCY0TlygRpIv/ZvFOQ0VGGowZxNDai86Xm8+ik= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=rcM1irid; arc=none smtp.client-ip=91.218.175.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="rcM1irid" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1765956697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O/RC2JaZfQWnRGhHEhR7EU7DG2VrpSmCFoSBZ0fAAxk=; b=rcM1irid7iZhLEiyC31dWf7GEZg2x6QnaCq8514+s+TRHJjJRBt5XX0VjwPoXWf4b870kM gF5CmOgkGe+CAHQ+l47v+XRNjSHJHKl4eleD+t4cE2jzU/bol8kuSG/q/eFSE/KS5KSEvx XfQohA5II8VscYDtO1EgTJmoLnFVmII= From: Qi Zheng To: hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, harry.yoo@oracle.com, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Muchun Song , Qi Zheng Subject: [PATCH v2 14/28] mm: mglru: prevent memory cgroup release in mglru Date: Wed, 17 Dec 2025 15:27:38 +0800 Message-ID: In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Muchun Song In the near future, a folio will no longer pin its corresponding memory cgroup. To ensure safety, it will only be appropriate to hold the rcu read lock or acquire a reference to the memory cgroup returned by folio_memcg(), thereby preventing it from being released. In the current patch, the rcu read lock is employed to safeguard against the release of the memory cgroup in mglru. This serves as a preparatory measure for the reparenting of the LRU pages. Signed-off-by: Muchun Song Signed-off-by: Qi Zheng --- mm/vmscan.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 354b19f7365d4..814498a2c1bd6 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3444,8 +3444,10 @@ static struct folio *get_pfn_folio(unsigned long pfn= , struct mem_cgroup *memcg, if (folio_nid(folio) !=3D pgdat->node_id) return NULL; =20 + rcu_read_lock(); if (folio_memcg(folio) !=3D memcg) - return NULL; + folio =3D NULL; + rcu_read_unlock(); =20 return folio; } @@ -4202,12 +4204,12 @@ bool lru_gen_look_around(struct page_vma_mapped_wal= k *pvmw) unsigned long addr =3D pvmw->address; struct vm_area_struct *vma =3D pvmw->vma; struct folio *folio =3D pfn_folio(pvmw->pfn); - struct mem_cgroup *memcg =3D folio_memcg(folio); + struct mem_cgroup *memcg; struct pglist_data *pgdat =3D folio_pgdat(folio); - struct lruvec *lruvec =3D mem_cgroup_lruvec(memcg, pgdat); - struct lru_gen_mm_state *mm_state =3D get_mm_state(lruvec); - DEFINE_MAX_SEQ(lruvec); - int gen =3D lru_gen_from_seq(max_seq); + struct lruvec *lruvec; + struct lru_gen_mm_state *mm_state; + unsigned long max_seq; + int gen; =20 lockdep_assert_held(pvmw->ptl); VM_WARN_ON_ONCE_FOLIO(folio_test_lru(folio), folio); @@ -4242,6 +4244,13 @@ bool lru_gen_look_around(struct page_vma_mapped_walk= *pvmw) } } =20 + rcu_read_lock(); + memcg =3D folio_memcg(folio); + lruvec =3D mem_cgroup_lruvec(memcg, pgdat); + max_seq =3D READ_ONCE((lruvec)->lrugen.max_seq); + gen =3D lru_gen_from_seq(max_seq); + mm_state =3D get_mm_state(lruvec); + arch_enter_lazy_mmu_mode(); =20 pte -=3D (addr - start) / PAGE_SIZE; @@ -4282,6 +4291,8 @@ bool lru_gen_look_around(struct page_vma_mapped_walk = *pvmw) if (mm_state && suitable_to_scan(i, young)) update_bloom_filter(mm_state, max_seq, pvmw->pmd); =20 + rcu_read_unlock(); + return true; } =20 --=20 2.20.1