From nobody Mon Apr 6 09:09:55 2026 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0C532BD11 for ; Sat, 21 Mar 2026 10:26:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774088792; cv=none; b=Xnigyp2vHtZ6uOp6DrgJ0gB/vSimGK/LDmKqgBJ8blAyF2WQCnVVtC12oTwliDSTuJjvGKVXfh9fc32AInUNz9JN1JxCloPbZ5mvK65vImbiRlq32LJIyeMVdMigjujf+U28zalVfgFiF216yVa5F3RIBobLsvczMKh7k/NiHiM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774088792; c=relaxed/simple; bh=0lbwGssq6/IWVsCAO0OLP8f/ZLC/+igyd+9IITKJTUo=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=sLAon3441/l7u4WuQbt58VC9C3M/R2sEXtIq5lg/aVx/5fgqf0cnEdqYABqXShpYaSo3hubpv5veF0csUJ57+H/HnB6lM6xfcXtXowjlhpcI1ch6hradv3LxUWnJXGi1dfOermGhg/mnsMs2qpxusQ3fT0UjwkW8d/DbdpAmJdo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Emx1YnTX; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Emx1YnTX" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-43b4d73463dso885181f8f.3 for ; Sat, 21 Mar 2026 03:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774088789; x=1774693589; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=8gSvEXvLNrFWzXilQr1NHH72SCF5cRdSmCN6DzRuhF4=; b=Emx1YnTXNHfpZSf4ZNLycfidCa/exXuUrDfgoRx/LwQML29abZwSxv6dE54YbP1HCT m9psD7jvO9YS6+8KiCRMKmm5GdJ6138RM+Goucek9bz3GOpkBmzCXx2YVQ8ucE6078gr VCDk0xBPAngmgykjSZE750vcOL47j7rIxbOMSa/No2YOeVjJVhgJW1fa/XmUDxeuNDVQ WSiC8VKYZ0JqsjnZXAdhVUQ9NOZ2WymXeSXjSsOOvfzxwKpNnasA0cKJt1+UnRxUvg8S YWTRMPMgTmLD2s/AMQsXSLPRu/V8e0NEgfp4AxiPJvAUSuBGxBDB9OLhkfMrImZSNnZ1 /TRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774088789; x=1774693589; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8gSvEXvLNrFWzXilQr1NHH72SCF5cRdSmCN6DzRuhF4=; b=Mhr8aVJGjugMgG0FlVml3Hej0PUsReX5j2ecYdy0MrWCTeRA6oElAwqCmksGJiFUS4 vPoUfVkd66nMj1xcgHyw3iF+Ll/CefjrJyrGgiXzPzgsTRa8/eLnkTPXIJZu53jv6U/2 I27ZV3BP47uEA2XbzpBiKj12100MjncOzwc4+vciioSjYoRpxhDozdsjSMUvmt+CyjkB 4EZEhS4KJ7zA7xZdPkbRTu+PYWGu4oFW1g9Wbm4t4zF/Z9oxjFSZbTYxJmiMlokDFQHc KGQukliAb1ca42cGV9qUe/wfFjKb1ZBU5YiAwPyB9Hcs0Mv4WZNAI2P1CLzVjhCoDHh2 TpVQ== X-Forwarded-Encrypted: i=1; AJvYcCW4aAXpZ32AJp+V/2KSlt4fgniV+S89vSScCKFMIoYDsUh8bU6CYQyHAtQnyEThyXwj4pcj9os6xH8VfGY=@vger.kernel.org X-Gm-Message-State: AOJu0YyUQX27qzh2sE58JtYybKOmKlWnYzsxZk4Qg4azPOHavuew1P9I A4DwhhcfMNq4xIFprY4pgKbiePMu8+HkiOg28zWOK4mkJFdE+qF4gprOnGi7lgWYA9c= X-Gm-Gg: ATEYQzyLHcsNE142mnPLTwSWAbQSJzRvdGyfwn9BS7Rw5dH3dx4DkkC0CN5Cp4UTntq N07smFKruu5yxvDk9ONdbsTTPr80V7wzzjacNkw4H+RkjbwVDQfUg81KMTQNv/cxQKGl3PpR57F hJNDIUW08REocwJZuJwqPRTF/ImwCbjDkFuLWN2oGy/yhRlO15clwUcPKUS32+nfryHZ/dDVcTy b+B5qfu7cSpNgVTwqI0jGBW/akfDlWgCpc0fpXK62CyZAZQgJ0CvG4WyUkBJ6siAH45wmyly0xw 2idrvngzDD2gcTsSK3jBEuXhijDBAMdAOWTNR8ewHho3/K/32GmuJSyiaPXCkw9s8CFjSuwEvoa kTDJjqf3FKB/ziihiiS4kZqcrZm6TYEWmzKvvWY0fk4evfBRpX+VKGL28b+otZsN0Jnp56Y7Zqf 8Taxb2oaSbY7HvaVHs7gQLqfOqnlueDj+NPcAFTv4= X-Received: by 2002:a05:6000:2310:b0:43b:53c0:f6f with SMTP id ffacd0b85a97d-43b6428ad3fmr9710653f8f.54.1774088789134; Sat, 21 Mar 2026 03:26:29 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644ae016sm12771163f8f.4.2026.03.21.03.26.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 03:26:28 -0700 (PDT) Date: Sat, 21 Mar 2026 13:26:25 +0300 From: Dan Carpenter To: Keith Busch , Sungwoo Kim Cc: Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Harshit Mogalapalli Subject: [PATCH] nvme: remove bogus check in nvme_pr_read_keys() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This check for if (rse_len > U32_MAX) is confusing because if rse_len is > INT_MAX, that will trigger a WARN() in kvzalloc(). Fortunately, the caller blkdev_pr_read_keys(), puts a limit on num_keys. The number of keys can't be more than PR_KEYS_MAX (65536) and the condition is impossible. Delete the confusing, dead code. Signed-off-by: Dan Carpenter --- drivers/nvme/host/pr.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/nvme/host/pr.c b/drivers/nvme/host/pr.c index fe7dbe264815..abab2746f0f8 100644 --- a/drivers/nvme/host/pr.c +++ b/drivers/nvme/host/pr.c @@ -239,9 +239,6 @@ static int nvme_pr_read_keys(struct block_device *bdev, * enough to get enough keys to fill the return keys buffer. */ rse_len =3D struct_size(rse, regctl_eds, num_keys); - if (rse_len > U32_MAX) - return -EINVAL; - rse =3D kvzalloc(rse_len, GFP_KERNEL); if (!rse) return -ENOMEM; --=20 2.51.0