From nobody Sun Feb 8 17:14:35 2026 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7456B14B97E for ; Sat, 30 Nov 2024 10:01:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732960869; cv=none; b=k9i6+ugn5zPhW5xgeWe5vBEIL/cGT+S3rH1/3S4ZqLVlwusLHP5eXEZnX3vCZiOGt2HWApvR8HL2wcQ0M58zUFrMxasjq/mPKkGTcyq0RQ2pdL0XI7jCkT7UHPb5sbiC3gOsCGmCk0EPQFeWCIyZCqkvbc2CWGXQdkREY31lpzo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732960869; c=relaxed/simple; bh=/XpaTseG/TEeisBd+wk4TWWeiStEhV6ICnH01fIZSu0=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=GH7fEd3B/vkT3VefO10jIkIzvzuMCq7R0sAWdtqtz15O2Nizl0pUCdy5hyflYPKdwfduDlJEDVEwxHAPgdK0P6kgMewBKgQsahJLvz5tHL59PvYzuYzkhmOH8OJp84O9LCf21WtJXZO2whqOFENwJLCKVasYe1T1kpbk8gcbQuY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=d1YyKLUz; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="d1YyKLUz" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5d0bdeb0374so1127894a12.0 for ; Sat, 30 Nov 2024 02:01:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732960866; x=1733565666; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=a67SmAxg7nZOip6zVhj4ZsmBcbeJIrKRZCIwBRUJFXg=; b=d1YyKLUzWuTjh2B4bEUrPOGTF5zhAiYqp3Ha8yY5Quyjso2KPJm4Yt6xEyzT99yZz2 nFTJbNWOzGTTXjU4aPAATBmUn9maJj4zvf1B4UH2+n2o8SSGI5XRf5s0U2ynrVd5ZKuv YUzR+igj4Mu9a8DiHoCfEAWtSUzpMBwqOVMcG6dwxs0d8tGpWBcLnAN7x1FzwIZXFXqs T33rqTeCOZ/nOxYSQbL4xJI4egCBO00mku5/zd8Zpodkuw367jFtr5ktz4QjnNhR5TJ1 9Q8N4GlOZI6BhdRzkg8HKX+AwHu4VlfYOohIYLH3AcMBeLpuR7GkjR5Ude0X1SclfK12 OCOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732960866; x=1733565666; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a67SmAxg7nZOip6zVhj4ZsmBcbeJIrKRZCIwBRUJFXg=; b=QXSRqDGWqBqfoucc1+uK1FxvhWNPu349ZEnIHDlMGSjA3IefciHf0Npcl2llRfcPrS VmnDG2O8/mUrPh4YKZur/U5i3b09fY9ZNsZ9IvRVL1pJH8oOY8dbfWHXuMQhAFXWr9N0 y2/labXAPyQEGWbIWdpoJ3o/VTcKP7IqYZBGRXax3SMlsN9AoGVgFSztNUOIYURi/G22 q/1X8wrdthoRbxQhiCwS0S2IifPjz5wRBgS9KAM0aIw5sqeaRHateYVHSe9NAqaAFZq+ fCmtlLU0UVwzB8xiGM9hcjlfFvcacYL7IpU/CnVMTKBOTfG3bZ8iufTLjJ21b6+qAx/D jc9w== X-Forwarded-Encrypted: i=1; AJvYcCWkUPqz2oWES1y8Pcepfc7VxaPOLjgW1BLQ6AS07nrmxoYg3kuZAJezuFjUTqALY3yiscLX9ndECVk6mYI=@vger.kernel.org X-Gm-Message-State: AOJu0YwZbqIaEw3qlmkdWWqDuTvcY03nJcxTULHxz6OJ5xJFHguVFjJ0 V6uRksS3TSWEf1roygWQ/bWoU6/VCeZH9dnUo7moR0xJdOH5SzpMk058+KxNAJg= X-Gm-Gg: ASbGnctD37AUqOEez73xOGMaF++2aYHgPQVmhp/PuOFrEHExY2EyrJMV9cM1ASLusYT kqvMTgrwhCZ3RrYafsMMli/uZ6q/wJrWLxYN/0C1SgQQQcAVwrShF04ANw5suycWCfZyRsJ32g/ cfmfQd1fqsJKuw6AcOQwZDzCF59ir6QXPgSHO2/HuokiO4SvXIHU8wu+UquqNAuJXI//RZLDkA2 AevCFo7RBJWmHFbSMGEqgM6q/jtdqemRLBqMsAAGHxvgdjg8M8dJQuQA9agkykqvjAknHe9 X-Google-Smtp-Source: AGHT+IHz6Lgpgq1CwlN5SY6GoUtJEsnuXZdZiLP/TvT694J0WqT85iYkJrByZ7WTMbPj28wc6GAvsQ== X-Received: by 2002:a05:6402:354c:b0:5cf:e9d6:cc8a with SMTP id 4fb4d7f45d1cf-5d080bd019amr12849937a12.20.1732960865832; Sat, 30 Nov 2024 02:01:05 -0800 (PST) Received: from localhost (h1109.n1.ips.mtn.co.ug. [41.210.145.9]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d097dd619bsm2665439a12.39.2024.11.30.02.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Nov 2024 02:01:05 -0800 (PST) Date: Sat, 30 Nov 2024 13:01:01 +0300 From: Dan Carpenter To: Yevgeny Kliteynik Cc: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Dan Carpenter , Muhammad Sammar , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH net] net/mlx5: DR, prevent potential error pointer dereference Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The dr_domain_add_vport_cap() function genereally returns NULL on error but sometimes we want it to return ERR_PTR(-EBUSY) so the caller can retry. The problem here is that "ret" can be either -EBUSY or -ENOMEM and if it's and -ENOMEM then the error pointer is propogated back and eventually dereferenced in dr_ste_v0_build_src_gvmi_qpn_tag(). Fixes: 11a45def2e19 ("net/mlx5: DR, Add support for SF vports") Signed-off-by: Dan Carpenter Reviewed-by: Kalesh AP Reviewed-by: Yevgeny Kliteynik --- .../net/ethernet/mellanox/mlx5/core/steering/sws/dr_domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_domain= .c b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_domain.c index 3d74109f8230..a379e8358f82 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_domain.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_domain.c @@ -297,6 +297,8 @@ dr_domain_add_vport_cap(struct mlx5dr_domain *dmn, u16 = vport) if (ret) { mlx5dr_dbg(dmn, "Couldn't insert new vport into xarray (%d)\n", ret); kvfree(vport_caps); + if (ret !=3D -EBUSY) + return NULL; return ERR_PTR(ret); } =20 --=20 2.45.2