From nobody Tue Apr 7 18:45:29 2026 Received: from mail.avm.de (mail.avm.de [212.42.244.120]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E57CB3ECBCA for ; Fri, 27 Feb 2026 11:20:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.42.244.120 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772191208; cv=none; b=CPfzXkZbcgbKww5RBHZWX+663DpO1Qnz//AaFuVIi6ZXt+iCULY6nF8KmKtwI8BguA+LVR7QPpubp2pbFXIlCHOKaTeUFQbPelegj+pK15zKmUDco1GE5S7DHOxc4M/+paO8Sdj29G42FnICaG/ksJCrAaox+ehXiVUqfWX1Cf0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772191208; c=relaxed/simple; bh=mMP39wVBeVEPNeq5TXPhF+Asl+2jnR0rzRl6G1NEl7U=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=YxtZOMWHSI4iqgv5uMlNljb4+io+a5W/DcYLH8/bNcfo70sLHUWg0J++dTdkN4IYc3CESvFaKyJWvyorrXEBXeF90sFORiIAtLG0gS5Pmqd6lK6Og4fcKkb3l8hMfocu10+iHet2M6KEw7Lz7y6aj14ySBIWhF2GpkPqjzSLnmo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=avm.de; spf=pass smtp.mailfrom=avm.de; arc=none smtp.client-ip=212.42.244.120 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=avm.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=avm.de Received: from [2001:bf0:244:244::71] (helo=mail.avm.de) by mail.avm.de with ESMTP (eXpurgate 4.55.2) (envelope-from ) id 69a17c1d-0473-7f0000032729-7f000001cd78-1 for ; Fri, 27 Feb 2026 12:12:29 +0100 Received: from mail-auth.avm.de (dovecot-mx-01.avm.de [IPv6:2001:bf0:244:244::71]) by mail.avm.de (Postfix) with ESMTPS; Fri, 27 Feb 2026 12:12:29 +0100 (CET) Date: Fri, 27 Feb 2026 12:12:28 +0100 From: Philipp Hahn To: Jason Baron , Jim Cromie , linux-kernel@vger.kernel.org Subject: dyndbg: pr_fmt(fmt) with additional arguments? Message-ID: Mail-Followup-To: Jason Baron , Jim Cromie , linux-kernel@vger.kernel.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="CFwBZZ+b2rGOhDlc" Content-Disposition: inline Content-Transfer-Encoding: 8bit X-purgate-ID: 149429::1772190749-490E495F-6AF22552/0/0 X-purgate-type: clean X-purgate-size: 3701 X-purgate-Ad: Categorized by eleven eXpurgate (R) https://www.eleven.de X-purgate: This mail is considered clean (visit https://www.eleven.de for further information) X-purgate: clean --CFwBZZ+b2rGOhDlc Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Hello Jason, hello Jim, I've been using the following in my modules to prefix all messages with the module and function name: #define pr_fmt(fmt) KBUILD_MODNAME ".%s ", __func__ This worked nicely until `pr_debug_ratelimit()` is used: The additional arguments breaks `DEFINE_DYNAMIC_DEBUG_METADATA_CLS`: #define pr_debug_ratelimited(fmt, ...) \ DEFINE_DYNAMIC_DEBUG_METADATA(=E2=80=A6, pr_fmt(fmt)); \ #define DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) \ DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, =E2=80=A6, fmt) #define DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, cls, fmt) \ static struct _ddebug __aligned(8) \ __section("__dyndbg") name =3D { \ =E2=80=A6 \ .format =3D (fmt), \ This could be fixed easily by adding an additional '...' to it to slurp any additional argument which `pr_fmt` might add. Would this be okay or do I miss something? For testing I have recompiled current 7.0.0-rc1 for x86_64 with no compile failures. Philipp Hahn Acked-by: Jim Cromie --CFwBZZ+b2rGOhDlc Content-Type: text/plain; charset="utf-8" Content-Disposition: attachment; filename="0001-dyndbg-Ignore-additional-arguments-from-pr_fmt.quilt" Content-Transfer-Encoding: base64 RnJvbSA1NDUxNzNhNzVlMzkyOGVjMDAwYjExMjdiZmM5OTQzOWI3ZmEyZjhiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlEOiA8NTQ1MTczYTc1ZTM5MjhlYzAwMGIxMTI3YmZjOTk0 MzliN2ZhMmY4Yi4xNzcyMTg2NzAyLmdpdC5wLmhhaG5AYXZtLmRlPgpGcm9tOiBQaGlsaXBwIEhh aG4gPHBoYWhuLW9zc0Bhdm0uZGU+CkRhdGU6IEZyaSwgMjcgRmViIDIwMjYgMTA6NTM6MDQgKzAx MDAKU3ViamVjdDogW1BBVENIXSBkeW5kYmc6IElnbm9yZSBhZGRpdGlvbmFsIGFyZ3VtZW50cyBm cm9tIHByX2ZtdApNSU1FLVZlcnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNo YXJzZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdApPcmdhbml6YXRpb246 IEZSSVRaISBUZWNobm9sb2d5IEdtYkgsIEJlcmxpbiwgR2VybWFueQoKcHJfZm10IGNhbiBiZSB1 c2VkIHRvIGFkZCBhIGNvbW1vbiBwcmVmaXggdG8gYW55IG91dHB1dCBmcm9tIGEgbW9kdWxlOgoJ I2RlZmluZSBwcl9mbXQoZm10KSBLQlVJTERfTU9ETkFNRSAiLiVzICIsIF9fZnVuY19fCgpCdXQg YWRkaW5nIGFkZGl0aW9uYWwgYXJndW1lbnRzIGJyZWFrcyBkeW5hbWljIGRlYnVnOgo+IGVycm9y OiBtYWNybyAiREVGSU5FX0RZTkFNSUNfREVCVUdfTUVUQURBVEFfQ0xTIiBwYXNzZWQgNCBhcmd1 bWVudHMsIGJ1dCB0YWtlcyBqdXN0IDMKPiB8ICAgICAgICAgcHJfZGVidWdfcmF0ZWxpbWl0ZWQo IiVzIiwgIkhlbGxvIHdvcmxkISIpOwo+IHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIF4KPiBub3RlOiBtYWNybyAiREVGSU5FX0RZTkFNSUNfREVCVUdf TUVUQURBVEFfQ0xTIiBkZWZpbmVkIGhlcmUKPiB8ICNkZWZpbmUgREVGSU5FX0RZTkFNSUNfREVC VUdfTUVUQURBVEFfQ0xTKG5hbWUsIGNscywgZm10KSAgICAgICBcCj4gfAo+IGVycm9yOiDigJhE RUZJTkVfRFlOQU1JQ19ERUJVR19NRVRBREFUQV9DTFPigJkgdW5kZWNsYXJlZCAoZmlyc3QgdXNl IGluIHRoaXMgZnVuY3Rpb24pCj4gfCAgICAgICAgIERFRklORV9EWU5BTUlDX0RFQlVHX01FVEFE QVRBX0NMUyhuYW1lLCBfRFBSSU5US19DTEFTU19ERkxULCBmbXQpCj4gfCAgICAgICAgIF5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fgo+IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNy byDigJhERUZJTkVfRFlOQU1JQ19ERUJVR19NRVRBREFUQeKAmQo+IHwgICAgICAgICBERUZJTkVf RFlOQU1JQ19ERUJVR19NRVRBREFUQShkZXNjcmlwdG9yLCBwcl9mbXQoZm10KSk7ICAgICAgICAg XAo+IHwgICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fgo+IG5vdGU6IGluIGV4 cGFuc2lvbiBvZiBtYWNybyDigJhwcl9kZWJ1Z19yYXRlbGltaXRlZOKAmQo+IHwgICAgICAgICBw cl9kZWJ1Z19yYXRlbGltaXRlZCgiJXMiLCAiSGVsbG8gd29ybGQhIik7Cj4gfCAgICAgICAgIF5+ fn5+fn5+fn5+fn5+fn5+fn5+CgpBZGQgYW4gYWRkaXRpb25hbCAnLCAuLi4nIHRvIERFRklORV9E WU5BTUlDX0RFQlVHX01FVEFEQVRBX0NMUyB0byBzbHVycAphbnkgYWRkaXRpb25hbCBhcmd1bWVu dCwgd2hpY2ggYHByX2ZtdGAgbWlnaHQgYWRkLgoKU2lnbmVkLW9mZi1ieTogUGhpbGlwcCBIYWhu IDxwaGFobi1vc3NAYXZtLmRlPgotLS0KIGluY2x1ZGUvbGludXgvZHluYW1pY19kZWJ1Zy5oIHwg MiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZm IC0tZ2l0IGEvaW5jbHVkZS9saW51eC9keW5hbWljX2RlYnVnLmggYi9pbmNsdWRlL2xpbnV4L2R5 bmFtaWNfZGVidWcuaAppbmRleCAwNTc0MzkwMGExMTY5Li4wYWMwZGYwNGJhYzAwIDEwMDY0NAot LS0gYS9pbmNsdWRlL2xpbnV4L2R5bmFtaWNfZGVidWcuaAorKysgYi9pbmNsdWRlL2xpbnV4L2R5 bmFtaWNfZGVidWcuaApAQCAtMTY3LDcgKzE2Nyw3IEBAIHZvaWQgX19keW5hbWljX2liZGV2X2Ri ZyhzdHJ1Y3QgX2RkZWJ1ZyAqZGVzY3JpcHRvciwKIAkJZHVtcF9zdGFjaygpOwkJCQkJXAogfQog Ci0jZGVmaW5lIERFRklORV9EWU5BTUlDX0RFQlVHX01FVEFEQVRBX0NMUyhuYW1lLCBjbHMsIGZt dCkJXAorI2RlZmluZSBERUZJTkVfRFlOQU1JQ19ERUJVR19NRVRBREFUQV9DTFMobmFtZSwgY2xz LCBmbXQsIC4uLikJXAogCXN0YXRpYyBzdHJ1Y3QgX2RkZWJ1ZyAgX19hbGlnbmVkKDgpCQkJXAog CV9fc2VjdGlvbigiX19keW5kYmciKSBuYW1lID0gewkJCQlcCiAJCS5tb2RuYW1lID0gS0JVSUxE X01PRE5BTUUsCQkJXAotLSAKMi40My4wCgo= --CFwBZZ+b2rGOhDlc--