From nobody Thu Apr 2 14:07:32 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED386349B02 for ; Tue, 10 Feb 2026 10:08:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770718110; cv=none; b=B9JO2iktcfLyNVYmUFgshwAXPqfJgesWQYQMpFmDcUEr9Uxy3MXkNm5LWxfqSRTrYvN8QEARb0hFp7f6bi6agldjIRvMzEhLxeIw6hw6uhpWZsXeJdLxe0CUSy6m0SZVY6oJcurPIUIM7/jNUQGcCm7HlKh73iL3R/NndNs0ZWY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770718110; c=relaxed/simple; bh=g8cCp8SVweSihnrR9rMsrRXF9XO/JoQgmnDE3KnS4rA=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=EbjzdmqnupfsSoskthGdvw7G/yHnMWT6NLx6iHzW4yfypNs502+1UrT4smqMfPdDrEDuBGG1xQ7l3lF+1aLOdy99XkqLhVgu9aszJazWehx2eD2D5gT/pSR3ETtdaU+NhJRHkNgef2oM3LAqFPG3pOavu33kGV2k3vE/hnD4pUc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X27Oi7Pq; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X27Oi7Pq" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-47ff94b46afso51642945e9.1 for ; Tue, 10 Feb 2026 02:08:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770718106; x=1771322906; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=yVaRDWsLmokfItqakaemlVq7gRQyDWlLjmBO7o/2Rts=; b=X27Oi7PqoFfG8iFthzXvDJ7Yiy2Req+dsARdoC2B+/bVf+5x9oXJujNNnq/IjVWOBl GjZq4dPFE/IxR0UlP2mBTwRoFVOBHSw//jVgU0KH0jRgzwaN+WLSURNq3wJpq2QYgGWv Iid/1vHi1K0INl4EG3IwW1jNSvbgFb+A9dyjzKgch4iC8h47pAu83rU6upvv2z/rAZRs XvesAJv+8ccib/t/5zBhsJNmziSc5kT3VicznHs6xVvYloe5t+K0PGkLxSD8qHAJMAi1 kSwyT9fgalEh36VagXzZeM9rngSzgvcEyJROGCSELfIl6KwDh8RF0yo3jaMVN3W94/AN r/zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770718106; x=1771322906; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yVaRDWsLmokfItqakaemlVq7gRQyDWlLjmBO7o/2Rts=; b=V2WZZOgKZp6TVJcTaQstDSqV0KYZCGvS2XhuGKXkiT7A0i28t5LPOlNDnAXxjPswV4 C4HW5tkOey7K37SdDO/WpkvQq8ezD41E+zLrOZht7CVnjb42aLS9hw3DTe9oiJs0gkNu Wm2OZT7FqUy0dUQMSukudFAlB1hHVhpwUMHyrmPN5SQ+NKrCAq+CtFohApbWdF6Iw0os q7SR9eHBWsek6D2p9WaJYU7koEwevteG2Ozc5Mg7wdYjcmF8+Ne/xGnmhvxJcc31mUzR HDzPiES5D9mxxfHNfgyctxjkbRL0OfnWSef/gLMj/471QgCIyr74/8QEndRBvuo3DCJ8 4AaQ== X-Forwarded-Encrypted: i=1; AJvYcCWnTJhMxDo9fx3YacIHbSaV1T2/U4NRQmc5BeLgJpMV6tmW9q54s2tv1XEUp6jww3oX8pUjUOxDNeW3CKQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzKVdwS9FAEo7lJwb/4I2YMNQJtRHV4b6IDTpab+mutldsTGwT0 bRYk8nxDq1Ay+QDMk68rcbPJa1bNdWgombTwCm0PTEKqdPFKwf4gqwQ= X-Gm-Gg: AZuq6aKbAA9uYutNk9qCNF+Ke8AWsf3M54w1lGV289ItSh2JxnlW5Bf5EF2AShgeZOk ayfajXHVEr72aVnl5qiSBhRqh8Jzws97sOcq2EWgwd8v0FAtriYzOlx5KmkPcSaW+KzRbAH0CCN EtZDHiN1XvlLzb+JKSlBEeA19ooUyNftuDE0fIWDFUduYXn2B6d5oIexUDFu60TKJVuAkIV9REM qmTmBPMw6n36pv/TeP+ONyWjtzpijDrj7jowX0slQMS3oFiy6hwz8hSgXJv8z6O0uxU8po+TrVE d+cXSTkglzM3wt413uXFDLHbtR7QnojHWuBZoLBPLy19RoWqgdIKGpiZ5OsRGdp1Msg4cMX2mCd zyT28/jbHbdRA++qhwHM3nRozYwFlncwBYgeAUvNZwYGMly86I6oC63+z148YN+7QeIVBCTFh4y NJ/HGuSawXSwXB/U+5jDgxdHHKfhGQyvZO X-Received: by 2002:a05:600c:46cf:b0:483:4b37:8620 with SMTP id 5b1f17b1804b1-48350530e24mr22715885e9.10.1770718105653; Tue, 10 Feb 2026 02:08:25 -0800 (PST) Received: from vova-pc ([85.94.105.74]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4834d7e74e5sm47719775e9.12.2026.02.10.02.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 02:08:25 -0800 (PST) Date: Tue, 10 Feb 2026 11:08:22 +0100 From: Vladimir Riabchun To: njavali@marvell.com Cc: GR-QLogic-Storage-Upstream@marvell.com, James.Bottomley@hansenpartnership.com, martin.petersen@oracle.com, skashyap@marvell.com, himanshu.madhani@oracle.com, qutran@marvell.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: qla2xxx: Completely fix fcport double free Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In qla24xx_els_dcmd_iocb sp->free is set to qla2x00_els_dcmd_sp_free. When an error happens, this function is called by qla2x00_sp_release, when kref_put releases the first and the last reference. qla2x00_els_dcmd_sp_free frees fcport by calling qla2x00_free_fcport. Doing it one more time after kref_put is a bad idea. Fixes: 82f522ae0d97 ("scsi: qla2xxx: Fix double free of fcport") Fixes: 4895009c4bb7 ("scsi: qla2xxx: Prevent command send on chip reset") Signed-off-by: Vladimir Riabchun Signed-off-by: Farhat Abbas --- drivers/scsi/qla2xxx/qla_iocb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_ioc= b.c index 3224044f1775..0de015de7eb5 100644 --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c @@ -2751,7 +2751,6 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_o= pcode, if (!elsio->u.els_logo.els_logo_pyld) { /* ref: INIT */ kref_put(&sp->cmd_kref, qla2x00_sp_release); - qla2x00_free_fcport(fcport); return QLA_FUNCTION_FAILED; } =20 @@ -2776,7 +2775,6 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_o= pcode, if (rval !=3D QLA_SUCCESS) { /* ref: INIT */ kref_put(&sp->cmd_kref, qla2x00_sp_release); - qla2x00_free_fcport(fcport); return QLA_FUNCTION_FAILED; } =20 --=20 2.43.0