From nobody Sun Feb 8 21:27:23 2026 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2164F346795 for ; Sun, 8 Feb 2026 10:54:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770548069; cv=none; b=FCXCXXeuOyY7zWMSeTYPsXxPd7SGGnmdTSWrQqXpNoJvf3v4psuXjLojTAuOonhoWYUaVTZu4EmiVvO1hWNvCVtLG1p9TldqngFWjnylY7bYRa0cwve8PrntKG6jAMpjQcOg1UWXcyJDF2sTJf+jtLv+vRZnKU5169YAn2uWpNQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770548069; c=relaxed/simple; bh=09EsHM0XWxOtlJPU1WX2qZmGxyI0lzeI24djkkcnGYk=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=EbbkwukgpsTUoZDufpblVNG/yA/9o8QoOn62t7X92SUeJBuXkE1C0wradNXJI50L3Q4bMLCS2sbto7uGhI8/Yqor2mXvsvQOOZF38Nf4EWabrNmsPoiTMBI5hxjjwYbylyNkoLx/snqYsl24VzqCEOSWJGs0LxEpB32w5L/Dl6w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MBVQ0aAX; arc=none smtp.client-ip=209.85.128.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MBVQ0aAX" Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-47ee3a63300so38670445e9.2 for ; Sun, 08 Feb 2026 02:54:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770548067; x=1771152867; darn=vger.kernel.org; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Gee6j3Nhagod6OKsFyP0vgwT+iZ/TvwykmcXeqLktgQ=; b=MBVQ0aAXsx5atpMKjeZsL4kAn/m3SgtCF0rKVHK/0Snptt/hzaKFMV7yoleq2vzuyZ aSAExbOL0gOR5rnJ/R0UrpLwWpv9BuLDXoGEvz9BPMPg7tJEp45+kujqWYVzSBZTO1pZ nbhr7vI6RTjK+eOmZ8AfYoLP2TL3pfK9SF4GIxpKruh1j25pqYeCr9lvUVnMtt1m7szs DvQ32EeiqIe+ZyQAeXq5izMPnRLs1SWU/jlRSicIGfpgYJqh+z+UJ7TtP+/9tq8C4pZx 6g54nyhTe/znGBCOIEkunRMPaqbtsK3ysMr7zaLUfvT6O3VMTUGJQABPz4pZqRTuUbWA IHqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770548067; x=1771152867; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Gee6j3Nhagod6OKsFyP0vgwT+iZ/TvwykmcXeqLktgQ=; b=KER+rbEanfAAgAPPfRStqjYdAvV2XcxXqzQ0PnCtVAYrsaSvtpJPCK7UyIH0780EBn SfDpB+8yRSsKILcX3dTH12T44RPG5ndNx2frStf2ncsywVMLMRG7w+wGAd6ibzNPN8jF 9IriVmJSGURmEXhWo2/+N50q01Uz4YT9gXw14TLPq8LM9XZ/Yv+fp2r4jbaupEgFfUod BO+XxCYeWZZPX9I8L4Ncr2hmZACwFjLJSYX8o5zPLCRhYKP5Q2wfVngagYZB8gnj6k16 0wB3y2RhvZntLDrxLHG1DCCJByuPmz0JgXQUkvI1ORlE6oT6JJyjC2DmetuLLtNPRAKl ociA== X-Gm-Message-State: AOJu0YzJoSlLoJyOhETZ5BL1rUet/oI19mqgapIWXRvqmWSPw22E/xV+ Zbxo/EUj0QhoZWxnZMrn3dhAI0FSmvLxbaJtVU2yGbWpGsvKtPwTVvjpkRLEXhC+ X-Gm-Gg: AZuq6aIRT9bR+b9tGgJzQ78YMc3LpFTUFnDKvsMo3jqMmYYz065xopcuXkoMf3j5zFQ zG4uIkWFUGwxdFPqwViVhClsTilXEX4zdLiMB+9P5+yum3b+x/5yhbaL+8JNVQyFoFIoPdYSziV uCj7SnT9k5CbDogwohsl11E9xx7ZIyXpJlu8CpodNwEGyRERbOZbhW+CCAO+uUpIZpRfP+dUHfY Iu25ikJuSUBmVXNkzrkOIKFEDDGaHwS4DazwuAxyVjoSVtAhOxHKAkf2JEAjmLYqwkhFZUENY6p GIoOL0YDTHhy30VL8tMES02lOV/oA8l/vINEz80Bs0vzRX7Y9j39QyrHnbDvMEJikOhCvMPOXBX e8aVdAWSEps6Mz9iuOCww/XxF0hOFU6DzYg9aVFkrMrBUVLW+0xQYA0DKgQj7Mza2w0/x9LALVw == X-Received: by 2002:a05:600c:3e12:b0:477:9fcf:3fe3 with SMTP id 5b1f17b1804b1-48320180a1emr117052625e9.0.1770548067006; Sun, 08 Feb 2026 02:54:27 -0800 (PST) Received: from BERA ([31.223.74.217]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48317d299bfsm235819465e9.2.2026.02.08.02.54.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Feb 2026 02:54:26 -0800 (PST) Date: Sun, 8 Feb 2026 13:54:24 +0300 From: Bera =?iso-8859-1?B?Wfx6bPw=?= To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev Cc: linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: Refactor setCCKFilterCoefficient to remove duplicated rtw_write8() calls Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Previously, the function used 16 individual and repetitive rtw_write8() calls (8 for each channel condition) to set the filter coefficients. The new implementation uses a table pointer to select the appropriate swingtable and iterates through the 8-byte coefficient array using a single for loop. This achieves the same result without changing logic. Signed-off-by: Bera Y=C3=BCzl=C3=BC --- .../staging/rtl8723bs/hal/HalPhyRf_8723B.c | 28 ++++++------------- 1 file changed, 9 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/stagi= ng/rtl8723bs/hal/HalPhyRf_8723B.c index 9df3274c1048..ed447daad3ad 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c @@ -121,25 +121,15 @@ static void setIqkMatrix_8723B( =20 static void setCCKFilterCoefficient(struct dm_odm_t *pDM_Odm, u8 CCKSwingI= ndex) { - if (!pDM_Odm->RFCalibrateInfo.bCCKinCH14) { - rtw_write8(pDM_Odm->Adapter, 0xa22, CCKSwingTable_Ch1_Ch13_New[CCKSwingI= ndex][0]); - rtw_write8(pDM_Odm->Adapter, 0xa23, CCKSwingTable_Ch1_Ch13_New[CCKSwingI= ndex][1]); - rtw_write8(pDM_Odm->Adapter, 0xa24, CCKSwingTable_Ch1_Ch13_New[CCKSwingI= ndex][2]); - rtw_write8(pDM_Odm->Adapter, 0xa25, CCKSwingTable_Ch1_Ch13_New[CCKSwingI= ndex][3]); - rtw_write8(pDM_Odm->Adapter, 0xa26, CCKSwingTable_Ch1_Ch13_New[CCKSwingI= ndex][4]); - rtw_write8(pDM_Odm->Adapter, 0xa27, CCKSwingTable_Ch1_Ch13_New[CCKSwingI= ndex][5]); - rtw_write8(pDM_Odm->Adapter, 0xa28, CCKSwingTable_Ch1_Ch13_New[CCKSwingI= ndex][6]); - rtw_write8(pDM_Odm->Adapter, 0xa29, CCKSwingTable_Ch1_Ch13_New[CCKSwingI= ndex][7]); - } else { - rtw_write8(pDM_Odm->Adapter, 0xa22, CCKSwingTable_Ch14_New[CCKSwingIndex= ][0]); - rtw_write8(pDM_Odm->Adapter, 0xa23, CCKSwingTable_Ch14_New[CCKSwingIndex= ][1]); - rtw_write8(pDM_Odm->Adapter, 0xa24, CCKSwingTable_Ch14_New[CCKSwingIndex= ][2]); - rtw_write8(pDM_Odm->Adapter, 0xa25, CCKSwingTable_Ch14_New[CCKSwingIndex= ][3]); - rtw_write8(pDM_Odm->Adapter, 0xa26, CCKSwingTable_Ch14_New[CCKSwingIndex= ][4]); - rtw_write8(pDM_Odm->Adapter, 0xa27, CCKSwingTable_Ch14_New[CCKSwingIndex= ][5]); - rtw_write8(pDM_Odm->Adapter, 0xa28, CCKSwingTable_Ch14_New[CCKSwingIndex= ][6]); - rtw_write8(pDM_Odm->Adapter, 0xa29, CCKSwingTable_Ch14_New[CCKSwingIndex= ][7]); - } + u8 (*swingtable)[8]; + + if (!pDM_Odm->RFCalibrateInfo.bCCKinCH14) + swingtable =3D CCKSwingTable_Ch1_Ch13_New; + else + swingtable =3D CCKSwingTable_Ch14_New; + + for (int i =3D 0; i < 8; i++) + rtw_write8(pDM_Odm->Adapter, 0xa22 + i, swingtable[CCKSwingIndex][i]); } =20 /*------------------------------------------------------------------------= ----- --=20 2.43.0