From nobody Sat Feb 7 18:55:36 2026 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE2AA2571A0 for ; Sat, 7 Feb 2026 14:02:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770472929; cv=none; b=N/8K87qmwhHZA4HarsNEn4RHkVnHjyNvI9RdgJKtiKMh5qWJ65gZzDHuoxuwPdVGLwBVdUooxlfnNnklFWxwgyJo/LTVdxF7WnrZ8GW4pYgldF1WOqLLYjJG6Ol6W/1t5xhzXHr+AEthSxSqxN3DF2hiZ21gWw0yHdyz5UYe4IE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770472929; c=relaxed/simple; bh=VA0zE8rDX2Q4udlhMjvEaVqSPONuk3F8F5XadgQPuM0=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=mcDOtZRjLVUZVY8qlnRPbMIXA7ln3ISAmPtRDojy9QJfYoEEBsFeRnZQ8xOh4yP3+XQLmoKUcjLiZmPg9rdGfgDJ2Vqg4YDIW1I4eYnJggn8bAlnOYGSQci+cNyb/p7BMqV9Lt46f2q+B9Uq3F4jAhOxMjwtsEDS2HjF5Owj8uM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y5914EH1; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y5914EH1" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-47edd6111b4so39433095e9.1 for ; Sat, 07 Feb 2026 06:02:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770472927; x=1771077727; darn=vger.kernel.org; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=+Knuttv861Uu0HJP206y97ixPrPqbWPfbOEF8vnELD8=; b=Y5914EH168VyKg6gaUhKsWuTA7hfTh7GQr2Zc0YfTc6OmoMpGgaSM4eUbQXcBY4wmD NqHXVyWBEANaaOjZctO9AAKEuyIUfv7V2fyPXgMal+FzlO+BOtob0wPS1qvcawA1iZX1 NLBFW1C5DbQ9CtrDzjpHJbWN+1cUeAvotG9xo2dwVEDZj20p+RKb0d9PNzDv03tMPLCk ZVWrQSvja/D4R1Q+ZxjP4pwvWvCB8eulnCzCChfvIJdVrURBsfxpWYrVTTWwFSCfCCyx SvMIaP5yt5qqZD7wK2/2dcFVAPHYuIhT/VD7ah11zy9oGnjqeFc2Mlng3UOTA6S2KJpe rczw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770472927; x=1771077727; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+Knuttv861Uu0HJP206y97ixPrPqbWPfbOEF8vnELD8=; b=unNivDkFVMRo9mKZL3H2X1ycVAqTsNa9Wp6qDTZqOfVb9p5u2D0duFUeM2wp1W733j IynP8jYAcvrDkwD807pYgK/xkr8SoTMhO9UJxRUGc+MyGCOIkRKmmBss/5yjtD43fDBD pntSztDK2ItPAVCUZdbhguq280fL7vUAe9x22M8g3mLR9f/ulKsR0BWaPyZpVa3GF5I1 mQBw4f82aMPmY/4qqwAkeIdicQDeweS0jyjUtpFcY/lBrXrnPhaR7fHr/0dWhTD7FubR Kq73otzBvVpYg10KrX2RHbc+kMwHAsZEjCNtOAXiZ8D90TE1IMDRDZGj4dwB7Mr8oMeK NFIQ== X-Gm-Message-State: AOJu0YzdDVTDMWXO4riipNqeW6ch9wXPbR/SljqeE5h1BMhQtbhkiV+I zehzQeijMuDOMdFiNWUoJQMyFQGNNcc98Msgg+yfSn/kz7xeZntZEqN2sTCxqga/ X-Gm-Gg: AZuq6aKKzYbMWoctJFdjkE1mUY3P9BlezL0KkuNF1uqZO1l3WsWudTSwYmpRNQTzIC+ PFciUaZ586a449c9V3PGWIX5FfwpKURjdwjEhxKGcUtZqBZ4cPIbM0vd8M1kyxAZ11KknBhHhEU 0hSpJ2l3EdVjrVcV4/s3kYN3m1nwcBE/BZaCgbcQGehVGWjQ9vkNFZRDIh1p+7tQIdEvNlJxZv9 LcHlrlDUIX6J9I5pZiQAt6hpF09odUPjnLrC8pFJPiDgOz3c5xcNgBSzSnBkORbX+zBtfjnHSba w/6GzYVN4wsQmD2rJ0mzxF64hpBQT2SsLEN6SmZ7Ba32avqqeEPMOnEENbLAVFGNZFeaZSXWmJ6 vfBVKkc+DSwT+FXorq9/cdI77bgv8AoNyLNjyLYbWbxu8Bjc62xMOBDAGzXIplvqqW5gRQPOmZA == X-Received: by 2002:a05:600c:3553:b0:477:63b5:7148 with SMTP id 5b1f17b1804b1-483201dc644mr84015775e9.6.1770472926577; Sat, 07 Feb 2026 06:02:06 -0800 (PST) Received: from BERA ([31.223.72.158]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4362972fc1bsm14028237f8f.28.2026.02.07.06.02.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 06:02:06 -0800 (PST) Date: Sat, 7 Feb 2026 17:02:05 +0300 From: Bera =?iso-8859-1?B?Wfx6bPw=?= To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev Cc: linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: rtl8723bs: refactor ODM_SetIQCbyRFpath to reduce duplication Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Refactor ODM_SetIQCbyRFpath to remove duplicated PHY_SetBBReg() calls and improve readability. The original implementation duplicated the same PHY_SetBBReg() calls for both RF paths (S0 / S1) with only the path index changing. This reduces code duplication, makes the intent clearer and eases future maintenance. No functional change intended: register keys/values and the selection logic remain the same. Signed-off-by: Bera Y=C3=BCzl=C3=BC --- V2: Removed helper function V2: Used explicit if() instead of ?: V2: Removed /* S1: RFpath =3D 0, S0:RFpath =3D 1 */ comment based on Dan Ca= rpenter's suggestion V1 link: https://lore.kernel.org/linux-staging/aX9UxRK_iYwxhTAm@BERA.locald= omain/ .../staging/rtl8723bs/hal/HalPhyRf_8723B.c | 30 ++++++++----------- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/stagi= ng/rtl8723bs/hal/HalPhyRf_8723B.c index 34692cca33f5..9df3274c1048 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c @@ -1078,6 +1078,7 @@ void ODM_SetIQCbyRFpath(struct dm_odm_t *pDM_Odm, u32= RFpath) { =20 struct odm_rf_cal_t *pRFCalibrateInfo =3D &pDM_Odm->RFCalibrateInfo; + u8 path; =20 if ( (pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC80][VAL] !=3D 0x0) && @@ -1085,23 +1086,18 @@ void ODM_SetIQCbyRFpath(struct dm_odm_t *pDM_Odm, u= 32 RFpath) (pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC80][VAL] !=3D 0x0) && (pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xC14][VAL] !=3D 0x0) ) { - if (RFpath) { /* S1: RFpath =3D 0, S0:RFpath =3D 1 */ - /* S0 TX IQC */ - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][I= DX_0xC94][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC9= 4][VAL]); - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][I= DX_0xC80][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC8= 0][VAL]); - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][I= DX_0xC4C][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC4= C][VAL]); - /* S0 RX IQC */ - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->RxIQC_8723B[PATH_S0][I= DX_0xC14][KEY], bMaskDWord, pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xC1= 4][VAL]); - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->RxIQC_8723B[PATH_S0][I= DX_0xCA0][KEY], bMaskDWord, pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xCA= 0][VAL]); - } else { - /* S1 TX IQC */ - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][I= DX_0xC94][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC9= 4][VAL]); - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][I= DX_0xC80][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC8= 0][VAL]); - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][I= DX_0xC4C][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC4= C][VAL]); - /* S1 RX IQC */ - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->RxIQC_8723B[PATH_S1][I= DX_0xC14][KEY], bMaskDWord, pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xC1= 4][VAL]); - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->RxIQC_8723B[PATH_S1][I= DX_0xCA0][KEY], bMaskDWord, pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xCA= 0][VAL]); - } + if (RFpath) + path =3D PATH_S0; + else + path =3D PATH_S1; + + /* TX IQC */ + PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0= xC94][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0xC94][VAL]= ); + PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0= xC80][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0xC80][VAL]= ); + PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0= xC4C][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0xC4C][VAL]= ); + /* RX IQC */ + PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->RxIQC_8723B[path][IDX_0= xC14][KEY], bMaskDWord, pRFCalibrateInfo->RxIQC_8723B[path][IDX_0xC14][VAL]= ); + PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->RxIQC_8723B[path][IDX_0= xCA0][KEY], bMaskDWord, pRFCalibrateInfo->RxIQC_8723B[path][IDX_0xCA0][VAL]= ); } } =20 --=20 2.43.0