From nobody Sun Feb 8 04:11:18 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 781C91F9ECB for ; Fri, 6 Feb 2026 13:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385139; cv=none; b=R1JFMxh81zy9eU/nz6RSlCFYBMTG/9CdrOuef7GqZNDI3NPtWRU4oxnaIfdTuMAgBZ+HEnzANTmkS+T1GQJfyfddKnxPKDy+q2TvhoFitQtAXEZkd6VIKV5ue44IRieTpsaKkE/EV5z68r9F5ATwVt/4SzleRZcpynptFduXZ4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385139; c=relaxed/simple; bh=ERjqnIJQfjdU3wTboUi0s1ea02FFt7jl7kPzuva8f00=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=o44b4JaqgXNxZjx9pmYzh5alAfIFG1QC1wGVJR4qWtHWNcA4g4T3aIVDwEWbYOMKRGxUB4nu5r/IIb7eX6jqgOzO/Z7Zw5Vf5jL29RpU4t9zB9CeJhet2PpMytfDzp5klDVx8fb9bTeUXOVJB72Vq0Bs73KquCQ28SPdA8AeF7w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Uo+F0svK; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Uo+F0svK" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4806ce0f97bso19015805e9.0 for ; Fri, 06 Feb 2026 05:38:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770385138; x=1770989938; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xSVsGkI58CbZq2nCLU80bXxVw6qpW/ZiID0uMzovT90=; b=Uo+F0svK8uREZAuKkmyM0sYMsdB9PA1olouTZpljd7qFCkt2KtMglfhOk+PXQXuRQY 8qL+KZxR08o3GIwYBnV5BXr4+emlyRJ7sDBGhwLnxqO2zzSY/Tf/FRTw+KutwZT+nuir kXV27Ej5APaJonJFUdQjyKzp99lp+mwMyVCXyovtMXElqKbt0+B0WQwICz4xaHIKZ3wa zfBsy8EsfP0EHcgc3sOIzJq8lDtzutNekz0QnwnLgK91kWBZItkM/dxY9aRL/78MwgdG 1HSwbHT3r2LkL+E8E9P9R+viWi5kVBGmSvHD+BHtODU9ZpzdclrhExD2BL+x02rNZBC0 lXQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770385138; x=1770989938; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xSVsGkI58CbZq2nCLU80bXxVw6qpW/ZiID0uMzovT90=; b=TWMvQuenD6chBSTL2r2F64ggBFPzLp8BfCE0upmbToXnMMyYvBsGSbSPxDPLsOTJlK Fcmy8Lf3Go8LbEssPjT1OuIEmu2uVF9WIeTZuPMngSdPrpy8d/94rxEwCnUzJPrttYHv Wd9ByGNx9KYGVjQqShgasG0nmRvj5xdOH/PQhY1oJir8F9nBCSL4feThD6IbOEwgYa9r e5Hnfzw1RdSqvgvZAGiqIbvARoJEot5PboqfWlqFzDZEGgE4Nd5lxY9FiXli8X6hVCZP kEwChzKPlQOStSnRDxSAs89R4B+Wga2lyfBYXBhH/a7nCKSpjB2t1JkcWnbgp1hQIPYH MIIw== X-Forwarded-Encrypted: i=1; AJvYcCWkbVOSl2c2YU+Jfq0OFHRUNSE3DhMZFCI4nS/SJm4lzrdi9h3wS3kFPTtr6vTzjmJx6QmTM+G74Ol7SsQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4h9lp39RUCdCiarICE5EeYqoBaqE6/i5Olnr5G6VJdfq44KCy Dz9htCz6DUgs5D+FQzhDMY7QHvFG03qsgOmQXq2WucR9WL/SRaIDgc1vQsrLZwIVepA= X-Gm-Gg: AZuq6aJB+Zk4T5/e++Jv+rBX7YMSCuzfzZZMMxBENhrELOW1y1dwKRLRxsZeDkp9UJy PWqBP8ZdCQdhKbynVb0evp7r4SpMFp2u2ODPKyJrQ578F/z5uY9Y/kbCF0jxgXAM22G2Gd57UM2 phIb3YgDFGJ/q2Af7miHkqDc3cvLYmtpRZ2pzSG8H8YMXI75CeXXOVzsFQ7K/Z/2Vx3C2aY5Hbo 6yWPbuwd16GyWazD4CCalwxubmr56Ed4Xo8zrQAQ7qumpr+vOfwUt923GF209evjwYdNf37Dmu4 8IA6/37iJsAT37Gq7A9W+VNdxbV8b7SRiV9qkAEdPh3R6a9j/1RvaXYfO9TPH2G74Lsl7iUQcg1 hynd9k8h0Mh0OUWEUjHHrPlZi0lFHJDSxfL3Pv6QJlFvEWikWiL3jU572zBYhzT0yf6HdoNBozH WHFc8gLvf5yyykP3MS X-Received: by 2002:a05:600c:470c:b0:477:b734:8c22 with SMTP id 5b1f17b1804b1-483201dab23mr42682665e9.8.1770385137793; Fri, 06 Feb 2026 05:38:57 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4832a38425asm145755e9.7.2026.02.06.05.38.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 05:38:57 -0800 (PST) Date: Fri, 6 Feb 2026 16:38:54 +0300 From: Dan Carpenter To: Krzysztof Kozlowski Cc: Tudor Ambarus , Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] mtd: spi-nor: hisi-sfc: fix refcounting bug in hisi_spi_nor_register_all() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This was converted to a _scoped() loop but this of_node_put() was accidentally left behind which is a double free. Fixes: aa8cb72c2018 ("mtd: spi-nor: hisi-sfc: Simplify with scoped for each= OF child loop") Signed-off-by: Dan Carpenter Reviewed-by: Pratyush Yadav --- drivers/mtd/spi-nor/controllers/hisi-sfc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mtd/spi-nor/controllers/hisi-sfc.c b/drivers/mtd/spi-n= or/controllers/hisi-sfc.c index 54c49a8423a2..6897ced2d57b 100644 --- a/drivers/mtd/spi-nor/controllers/hisi-sfc.c +++ b/drivers/mtd/spi-nor/controllers/hisi-sfc.c @@ -403,7 +403,6 @@ static int hisi_spi_nor_register_all(struct hifmc_host = *host) =20 if (host->num_chip =3D=3D HIFMC_MAX_CHIP_NUM) { dev_warn(dev, "Flash device number exceeds the maximum chipselect numbe= r\n"); - of_node_put(np); break; } } --=20 2.51.0