From nobody Mon Feb 9 01:50:40 2026 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF4C734F263 for ; Sun, 1 Feb 2026 13:27:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.67 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769952459; cv=none; b=dC/1M/Fh8zsWFpRMibjp8DJcI7QQ1vasN3/gPXTVv2d8rMQ7CjQIr2CGtUhhPtwvTNUs09JTFdowXy1rhlgX1Vc6QKi6CP5WOoAoWJh4FLJm+Vks75D4+Fl9poAsKXYLmR39WCkefuY3s98+ZsrBXMnpWtOu7E5KAmSNXfJgXgc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769952459; c=relaxed/simple; bh=LGH5AqPOEsiIUve9uUoEOb5Gf3ZLwNENwTScdQdP7X0=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=jUUbXwbF4+8oqxGoc+MESmTtTdWkqHOZ0WHeKh8pWnG34urCkHAgbFCeMbpe/oJ5FWL1AfO5c7gOwkxKPWwg9qQHc0Xcdkn7/rb7R3SiO8BWk0+yb/5FAdQVtHJY4X/c/1EyTKUfSQ2XqOg0LEbeqBLUE9WHTH4sljTfqfRAmwQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T+rZAbmw; arc=none smtp.client-ip=209.85.128.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T+rZAbmw" Received: by mail-wm1-f67.google.com with SMTP id 5b1f17b1804b1-47ee3a63300so39048605e9.2 for ; Sun, 01 Feb 2026 05:27:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769952456; x=1770557256; darn=vger.kernel.org; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=I3UUytHfblt7ijE/UxVwvx3W9WU1y/4ofbR1uKj5fyA=; b=T+rZAbmwKhVtCjD3UoGTw4Pi2CS23VEAdyL7od26zSYEREVzMgZmMTUI/Z0Brzs7vn pBBz6moa1GRcVIlD9AQA8IFmDK6ZDKwD1oCkal+3vOuziiGx8wb2H012v3osrTDk0QM8 cnq89FTvR2oLGtNe6SY5oyMG9F72U6rCLfuOM/R/xDE2iQ3GPn25QcVXt+ecQcL13bxW v6LrgGksQxTdBGcnfsNHIcmLWeH118vs91IdJ2XD/X0d0PguNdYQF4lvgQnfynsOm68e ceZ0BIRXsl10YXSbKpsa9/FILKHIGml9VEajwhfhfkALRBUp6E5h2y5vTNiQ47bhA5dB 0pfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769952456; x=1770557256; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=I3UUytHfblt7ijE/UxVwvx3W9WU1y/4ofbR1uKj5fyA=; b=DXSiZ0L2cDlq7OQiTKwOd9rHqdy2XNpjwPJISMTlBjLnVxwuxq7+A+n6ebhnWUj/TN oqkEhPDha1LUs8v4rLV8MKC0tIn7KI9QPGc5xDCGwFuci5WYPvKpWRoq9WEMKPBCIDQf 4r6cYf/kq74ubJtEKmnvXYGv0T66maUK6AYFz4IXg526SINbSzHPteAvFuC3SofOOin5 +GFTp0HFUBzqMWVuPVy4ay+THN7dmLYe61inHv2Un75EJKCvTPdsEyggYx4He1lGq31H BtSCMfwZlT2irPBET1dpu8JWN8C87LfFCJbu+Seo4moy2ipchHfNccHsrNkOIOBq48Vk S5EQ== X-Gm-Message-State: AOJu0YyxIv7SO7OgExNGxXqSGeGZYH8JMaz20/39h3DRai0d/R+thmYx +fNggmqkuFPYTk1cNY7wNeEQrfIGIPuEH1Or5VOiASh0mcYsUQtNWOIH2PMnHSlL X-Gm-Gg: AZuq6aI8hd8BX2RIsX0EzKAhYpfRgfhNw5TX8Vpe/7YkDzRTdvuLPt5EQ5vj+s6tzLK pBD6JU1EsxPfrSSa2Miv3YGo+yEBbp5/Ur3MpS03XBuXSXIhdpHa0DnO3dhjf6dRAg2BNtdZQpi 5IjmgNgZjFSG005BvCCqUyuw0kU8S9Q6ZJcIurLV3O+w0XsIWydo7u2FZ7CKj3xylOLde9GqAt+ FPZXHRYDK2nHURi+qKogjMZ0paOQ89sgIPiWKMH9jESWFWoaMM9tdLxkiQMV4xxQcMGihVnPok4 T4eUJlHnFRtSt2CPKRy+Wc4bMFT41SXwGp9QmldyxCXyj7HLcMg4e1FoYSLfA7hvqYVsbGiZ7Sv sOtf293YnbALunIVJmyGQdB9p06d6NtxWCxrs+telep4NkONaRv8bsKMCvnyKMWNxT+7qgbFZ X-Received: by 2002:a05:600c:3f0d:b0:47a:9560:ec28 with SMTP id 5b1f17b1804b1-482db465f83mr106113515e9.13.1769952455843; Sun, 01 Feb 2026 05:27:35 -0800 (PST) Received: from BERA ([31.223.9.211]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c37420sm418189755e9.9.2026.02.01.05.27.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Feb 2026 05:27:35 -0800 (PST) Date: Sun, 1 Feb 2026 16:27:33 +0300 From: Bera =?iso-8859-1?B?Wfx6bPw=?= To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev Cc: linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: refactor ODM_SetIQCbyRFpath to reduce duplication Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Refactor ODM_SetIQCbyRFpath to remove duplicated PHY_SetBBReg() calls and improve readability. The original implementation duplicated the same PHY_SetBBReg() calls for both RF paths (S0 / S1) with only the path index changing. Introduce a small static inline helper, set_iqc(), to encapsulate a single PHY_SetBBReg() invocation and select the RF path once based on RFpath. This reduces code duplication, makes the intent clearer and eases future maintenance. No functional change intended: register keys/values and the selection logic remain the same. Signed-off-by: Bera Y=C3=BCzl=C3=BC --- .../staging/rtl8723bs/hal/HalPhyRf_8723B.c | 33 +++++++++---------- 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/stagi= ng/rtl8723bs/hal/HalPhyRf_8723B.c index 34692cca33f5..bd535f774852 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c @@ -1074,10 +1074,17 @@ static void _PHY_PathBFillIQKMatrix8723B( /* */ /* MP Already declare in odm.c */ =20 +/* Helper */ +static inline void set_iqc(struct dm_odm_t *Odm, u32 *table) +{ + PHY_SetBBReg(Odm->Adapter, table[KEY], bMaskDWord, table[VAL]); +} + void ODM_SetIQCbyRFpath(struct dm_odm_t *pDM_Odm, u32 RFpath) { =20 struct odm_rf_cal_t *pRFCalibrateInfo =3D &pDM_Odm->RFCalibrateInfo; + u8 path; =20 if ( (pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC80][VAL] !=3D 0x0) && @@ -1085,23 +1092,15 @@ void ODM_SetIQCbyRFpath(struct dm_odm_t *pDM_Odm, u= 32 RFpath) (pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC80][VAL] !=3D 0x0) && (pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xC14][VAL] !=3D 0x0) ) { - if (RFpath) { /* S1: RFpath =3D 0, S0:RFpath =3D 1 */ - /* S0 TX IQC */ - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][I= DX_0xC94][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC9= 4][VAL]); - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][I= DX_0xC80][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC8= 0][VAL]); - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][I= DX_0xC4C][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC4= C][VAL]); - /* S0 RX IQC */ - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->RxIQC_8723B[PATH_S0][I= DX_0xC14][KEY], bMaskDWord, pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xC1= 4][VAL]); - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->RxIQC_8723B[PATH_S0][I= DX_0xCA0][KEY], bMaskDWord, pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xCA= 0][VAL]); - } else { - /* S1 TX IQC */ - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][I= DX_0xC94][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC9= 4][VAL]); - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][I= DX_0xC80][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC8= 0][VAL]); - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][I= DX_0xC4C][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC4= C][VAL]); - /* S1 RX IQC */ - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->RxIQC_8723B[PATH_S1][I= DX_0xC14][KEY], bMaskDWord, pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xC1= 4][VAL]); - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->RxIQC_8723B[PATH_S1][I= DX_0xCA0][KEY], bMaskDWord, pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xCA= 0][VAL]); - } + path =3D RFpath ? PATH_S0 : PATH_S1; /* S1: RFpath =3D 0, S0:RFpath =3D = 1 */ + + /* TX IQC */ + set_iqc(pDM_Odm, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0xC94]); + set_iqc(pDM_Odm, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0xC80]); + set_iqc(pDM_Odm, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0xC4C]); + /* RX IQC */ + set_iqc(pDM_Odm, pRFCalibrateInfo->RxIQC_8723B[path][IDX_0xC14]); + set_iqc(pDM_Odm, pRFCalibrateInfo->RxIQC_8723B[path][IDX_0xCA0]); } } =20 --=20 2.43.0