From nobody Sun Feb 8 15:59:21 2026 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D5492EFDA6 for ; Thu, 8 Jan 2026 19:57:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767902264; cv=none; b=ZM84pPjuPa3JQClqdXjQvgq5gcKSAVY8QwGPq+yl95JMSCPeDmzeu0rsnQQoQFdchZGJJfycVe2Cd9ZogTwRn99aTQA6VHybkPsx2cLaAyGxmOgcuy6Fy6BC1uHZJ9f9MTFilOuoYyNlQr8RW0II4BFwGsj2uoLaizlKtrKGW/c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767902264; c=relaxed/simple; bh=SEPQdKAnhPs5qLuQcj39VfnCDYxTiNdPEOtqU1zoQRU=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Gcgh/g5YIWvhSkvIb+NzQc1B38uG2sdbB6flT9I6GkKoybyshEY5UF4owFfmozg/VMTDA/kzpWldbC0XZ/vWRkRIfV8lkt2AZlguzdGgrMtZW8jaSa7cU+/GEhjkA2Ll4Yrqhu4R3kbGZDn3YfMy8E9/lDv1nA/kGlVLmB1NMwc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SVv4ewMK; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SVv4ewMK" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-4308d81fdf6so1826750f8f.2 for ; Thu, 08 Jan 2026 11:57:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767902261; x=1768507061; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=7gDf4kLAuf0qf8dByGwvVIAAHMwWtxHLpFy5fp7Ykwc=; b=SVv4ewMKDYFLaBBR0a7aI6A9JomvmAP3+HlvrbqDfrnMXzj/L5Kpo6MmH9SwYXud8z WaZPcwdFdwdSg67Ck7cUktr8fOXoRz1lCElZU/B6+MYiy+urk2IsxO0YI55HIrfCEzgf p/8F/W5emq1umeMCW/ZdvS2N5LaP/E4UhAdJPmYwhJAq71sjRPtbHp+pL6jNdzsbGKRZ Je/Bn7rmEs0eJI0PWcwwTeXjB2m36PEH/ypgAKMR2eiw5ZeR0fBnccYZKLehII5yliKx To8c0sN+RHPRzT+RoajfioHBwIArOrmCoJjy7G20qZWHxkal3MxLxFegGzO0nanHowRr jXZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767902261; x=1768507061; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7gDf4kLAuf0qf8dByGwvVIAAHMwWtxHLpFy5fp7Ykwc=; b=lswNmn/6W3o1mQdxmYFx81oW/J9NWGhNsp9DJ02t4ZW0KGXXt+DleSW8rCSkaSG2uV EnvGPksf3flmPwwpGhcaHNiQqnsabxyB5kkIN/BIKxOOVPeb5Y1ndZKm+el7ouE2b769 z2i6aCmX7hGlru2t+V0cGazugDzlY9s7o1sOS+0xg8ZQAWKBTN/Fzw8WBYFGwRbcvjIW W+gJrms33d1oaMB/YKKGRrR9HP7N4WnUVgyDg9td/vKwpWywmsxl32dyEYBryz6MFJQE JuDJgaKV6cOK2ftws7QD94JthFnJHduhNN3vszJlU5SdOflmUBo5hj3+STeTEWaYCrlX m9SA== X-Forwarded-Encrypted: i=1; AJvYcCX/h+z3K0WTV/4oONFGzzHnxZvIPvcvmU/lnjAfyVGjmMJulxoyHPdEUqKFuvQ5w2QW38x3T1uTQeviKkc=@vger.kernel.org X-Gm-Message-State: AOJu0YzY3JDYi9BpqGW5Em3i1JFEApgBv7UK8WkEDhAjmvDbVLthkN5+ xhnvZVgyUpyR7rJPpfKenJAlPiCeBD+FkSmBgOH2ijvsYLuDjGtHpehtbIG69P2IH7o= X-Gm-Gg: AY/fxX4Yd/kF0xdJJ96Eg0b8AGPA1l0qPamuHlUT5G60XoyiWWVIXnO9mF5JsKaZxCj Ba4GLfu1YqgYEg/yIuWXH4qh8IlWx7FcV3Gva0vwbQrmROi84uq+lyyUcW2zvWrmV+/5doKkoGO sfqp8XrbCTZOSC3GGL9KCou60K4UlGIvPeiGNC24XP0PcxROLArNVayT/6+sPtcaWGtGfwjNiN7 VBcF9phl5jHRDtvrzTUITRMWQpJLH0zmPSn2PZwpnJ9YuUNNNJvmBxbq79TOzgNkuvt5h+EHJsp v0gnLN4GC+paruHRBghVQgAOJ++mKgCiA7kSGOPVvcK6eLv2a3pjOk2p3t/bDAAwICf4ZHcPEtF 93GP+TbDzyCiNbPjW2TI4nJLkO6GrJmvRLs3WtP6LSXvS7lVUIX20YHfm3wkoCOEC7z1becyTt5 5zISUPc6tmUcmekb+M X-Google-Smtp-Source: AGHT+IHZFBCYQJFhqky8VClr8SnHFwzl/K8CfsbIy37jcUuYeB36t9vSgMB3jS7bjLFN1WcoCrT2gA== X-Received: by 2002:a5d:5d13:0:b0:3ec:db87:e5f4 with SMTP id ffacd0b85a97d-432c362817bmr8072719f8f.7.1767902261307; Thu, 08 Jan 2026 11:57:41 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5df96asm17943736f8f.28.2026.01.08.11.57.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 11:57:40 -0800 (PST) Date: Thu, 8 Jan 2026 22:57:37 +0300 From: Dan Carpenter To: Amitkumar Karwar Cc: Brian Norris , Francesco Dolcini , Kalle Valo , Cathy Luo , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] wifi: mwifiex: Fix use after free in mwifiex_11n_dispatch_amsdu_pkt() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The ieee80211_amsdu_to_8023s() function generally frees the skb, so save the skb->len first before it's freed. Fixes: 776f742040ca ("mwifiex: fix AMPDU not setup on TDLS link problem") Signed-off-by: Dan Carpenter --- drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c b/drivers= /net/wireless/marvell/mwifiex/11n_rxreorder.c index 354c5ce66045..90831a1350f5 100644 --- a/drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c +++ b/drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c @@ -25,6 +25,7 @@ static int mwifiex_11n_dispatch_amsdu_pkt(struct mwifiex_= private *priv, =20 if (le16_to_cpu(local_rx_pd->rx_pkt_type) =3D=3D PKT_TYPE_AMSDU) { struct sk_buff_head list; + int skb_len =3D skb->len; struct sk_buff *rx_skb; =20 __skb_queue_head_init(&list); @@ -44,7 +45,7 @@ static int mwifiex_11n_dispatch_amsdu_pkt(struct mwifiex_= private *priv, ntohs(rx_hdr->eth803_hdr.h_proto) =3D=3D ETH_P_TDLS) { mwifiex_process_tdls_action_frame(priv, (u8 *)rx_hdr, - skb->len); + skb_len); } =20 if (priv->bss_role =3D=3D MWIFIEX_BSS_ROLE_UAP) --=20 2.51.0