From nobody Sun Feb 8 15:59:23 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4BDD31CA4A for ; Thu, 8 Jan 2026 20:00:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767902431; cv=none; b=nYJ2nFmJER0hjE/NLkJICUKrI0ALtEglmuw259XOWmVZmbB7etwd233tDihIOJzN7sJqdcXV4XiontFtm7hMsVP3z73J1cG/dFUxS8ne158EUIs0RVsxmxqLeUmjRNSTtyolL9LhyUmNF9haPb6350t7xCuW9eiFBaEaUOWEHnE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767902431; c=relaxed/simple; bh=oRS1hAU5OfWdEUW9LOFCO7By8fdkrh8TpGijGee93nA=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=WiHj0Dila5j/f9OuLdx6kwHpOOA/R1bnxhni4Nen37gdWd9RMapY7dZ5bN8t5SyUtyVuG81ElbQi+BexKqKEbS/FvFGpPJJdMwGuJndTbfq2Fg4tSg5FixFMCcXD8C32w2uPp1if0LtD0pkteom405JKrTmnoJAsAN+AdGlo1W0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qUB+2zV7; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qUB+2zV7" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4779aa4f928so38908825e9.1 for ; Thu, 08 Jan 2026 12:00:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767902428; x=1768507228; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=Gcl9W7utZBdw7FMB9g/xVOVl0GPxA6kn4avJQSoGwXc=; b=qUB+2zV7Y9u3RmTSqxHCte/PhFJg5AnhugodrVZpp7noiOLyLn/StdqQIj485PWM8G PJyAG7N/tz2h3griAfRA+coD5tNHX/jdzsbDb5aRcQibSgBFTIpM4mnD7ZXrhtEcfh+Q rM2Ex0QNgfzHEAWMZHcEVMuA+x6mfpTER3ZkWBQkxLlH3jgj9r5erfXT5O7V4/n5Qmt0 aW7PomzAqjs7nYYv3fHzm62f5xzADZ9tWHNadshVXBtiy1Z2Au+3eXqnjMzATX3QYTqr EHcpLufajmdFHp/mk/SqOyvstpqylFOVXd14QYCfY8uoJr6Q9K65g8qQDDGSOU9GN6kb ZXww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767902428; x=1768507228; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gcl9W7utZBdw7FMB9g/xVOVl0GPxA6kn4avJQSoGwXc=; b=lBKdPxedXWHP8cTGM7CTIf1L+MRiqo9f2tH/7T75Dy4afXHqk29StYMJDFpnAK6/rd uMXnltvb0lgKzig7VdHv4ReCNlTCmFVl3ODL2Bqj3QONN43OpqKVU4Dj9l7QZoUZCle9 Alo1bh8aa7AwmVd32Yp5+3I5jJHT57BNpSTKTBEanShhLax2G6c8kPq6lpvQqjeXrZeB JYTts/L9nrcYmb6jCYMOQ0PoX5jcOb+ouNfEzqlsMofPm6Jr8o6RO6jENJIxogJJbLcr op13zmq+zibl0x5CT2MbyX3tpNfsgMCRYpQmZYbRjnxcs6BikBBbrYNlhPLQDvy+wYE3 2FgA== X-Forwarded-Encrypted: i=1; AJvYcCXf8zeWDd7ttCyJU7flwH0TJt/A6EGqloEQiAYteSvdRBEjSMk/bK0gCWdrZvpAxn8n582v5m52kVviXuc=@vger.kernel.org X-Gm-Message-State: AOJu0YxGpJhHR3kHGiDlJx/9LORUBMah5hhau0/hcBcIJXXVRg2a+UNC kWno2ZSFaKNN2nOaPdlx++qFKRK+g7Wu9e0VlhaQxSvdM7zVAmo5hH37LgE9xTpizss= X-Gm-Gg: AY/fxX5za8vrsqlRt2XRp/wdNgwpP0B85n9V6v7HuQJYgjtz6qpQlucS/cXeONkDGf3 ZPl87GOTC/GaCS0vrZ0fpWCsvBshVomqTfmpxXWpmKekZ4zZI6mcBGYFnSTKti+DFkvyngFjd0G CXYb0gI9fJ9ol3bF9xZBzX7ztGSqh8x35e5GvCUu1BQr4HhuXFoENpoV4WFhVLLQNwscKnqQOOb XJJkab+HCu/VN+XRe8pkM4nNSwTSTKxgiQcnR16T30HdZUeF+yALdTHTnrwYUKZ0Y2B9KOZcQ6T SB5JWF2upvql2yZedQvvsKVdVLvxndmBVY5AqMILbkpaUG5FwSYh/DHsjoO2y5Yc5Cd4D5gq/Zk 2V8vrfkySGtUiBMk9owXkW1d6cG1POAkXonEFvynt0Yep16sJ1zealKmoHo6mHgIxc4nCKgsJyd PDf9US7vbjnzIpniZ8 X-Google-Smtp-Source: AGHT+IFDQfRRHTy8VXJdne5ZZULneM+07+9GSYBN+09fhDGgLXusMoTgHfEjB4HwQ4EFEEDpVfL1QA== X-Received: by 2002:a05:600c:a48:b0:477:9eb8:97d2 with SMTP id 5b1f17b1804b1-47d84b08652mr86768025e9.8.1767902427872; Thu, 08 Jan 2026 12:00:27 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e16f4sm18895387f8f.11.2026.01.08.12.00.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 12:00:27 -0800 (PST) Date: Thu, 8 Jan 2026 23:00:24 +0300 From: Dan Carpenter To: Chunfan Chen Cc: Brian Norris , Francesco Dolcini , Kalle Valo , Amitkumar Karwar , Cathy Luo , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] wifi: mwifiex: Fix a loop in mwifiex_update_ampdu_rxwinsize() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The "i" iterator variable is used to count two different things but unfortunately we can't store two different numbers in the same variable. Use "i" for the outside loop and "j" for the inside loop. Cc: stable@vger.kernel.org Fixes: d219b7eb3792 ("mwifiex: handle BT coex event to adjust Rx BA window = size") Signed-off-by: Dan Carpenter Reviewed-by: Jeff Chen --- This was found via static analysis so I'm not positive on the impact of this bug. drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c b/drivers= /net/wireless/marvell/mwifiex/11n_rxreorder.c index 90831a1350f5..91166b89f918 100644 --- a/drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c +++ b/drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c @@ -826,7 +826,7 @@ void mwifiex_update_rxreor_flags(struct mwifiex_adapter= *adapter, u8 flags) static void mwifiex_update_ampdu_rxwinsize(struct mwifiex_adapter *adapter, bool coex_flag) { - u8 i; + u8 i, j; u32 rx_win_size; struct mwifiex_private *priv; =20 @@ -864,8 +864,8 @@ static void mwifiex_update_ampdu_rxwinsize(struct mwifi= ex_adapter *adapter, if (rx_win_size !=3D priv->add_ba_param.rx_win_size) { if (!priv->media_connected) continue; - for (i =3D 0; i < MAX_NUM_TID; i++) - mwifiex_11n_delba(priv, i); + for (j =3D 0; j < MAX_NUM_TID; j++) + mwifiex_11n_delba(priv, j); } } } --=20 2.51.0