From nobody Sat Feb 7 15:35:01 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 670D62D9EED for ; Sat, 20 Dec 2025 08:45:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766220347; cv=none; b=aXWccsKSKNsTOgvfMIjwFBmrlTFNgMaX8N+Ev1xhuN1Z3QsyN7vOb/xrQD8uQb0ebdGWhKhBEiO2mklXzCX/FO+Vd/myGUPBvUZBOURnq74eruZReWojqMoP+NV4NJ+I6XEXb+IoYwgiHE7wDxFOhiPboC7fQwz6ZIxnjKNXYJQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766220347; c=relaxed/simple; bh=+S85M7vZcdB2shypININVpHOd4FTUrPIPOTRXmCXQiM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Nxwy36O+UdIR8lvn9KiRfFv41e+XCdzaYcg2hSwA12hZjf00MvG7FyVm1EHkzrR9DSi27BHMm+ZT+07b3U8X9WV22ymr5IwCKs+F/01oEsqFnQNk4Qaw/3dckPofotCT+Yzl7o5FLbfTe3eh+zb7X9uoER9Bgb1qCamHq8ycA3Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=utvggR5z; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="utvggR5z" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42fbc305914so1853792f8f.0 for ; Sat, 20 Dec 2025 00:45:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766220344; x=1766825144; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=6BUTU7KENszCvbPNcK9L3kbL2a9wKFYRCwPwVT9719s=; b=utvggR5zzuTIhNmN3WxghVSwaB4UHsm3dD6u0NQal46cN6AzPOnfts2gAHcYOrGxHf ACwnXzWtghQmt1+wupf1LC9pMOMxZr0sUb5aMZDWvkeynaOlHEe6yQl56E56eXq9wKtw 7XmxHSJPiuJbEqU2hXAM6l2OeppY7WaQHIw/xCZs5gjIefIfHe6ZY8q35tpSibCg/Q4p ZpgSULygILRZsVcD/LP1TOumaHbv7vUv8aYErmgpzERUNcNrAHNIW0LuNpMzcXSfMLFz 79Fk1Omx84nkWbfoJJZA8lNRoAgSgmgyZMC+m36JHkh1lEW8pCfmPbYaJEHghpDwkEkT ukIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766220344; x=1766825144; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6BUTU7KENszCvbPNcK9L3kbL2a9wKFYRCwPwVT9719s=; b=uMRQlttwq8+MSMHt43Ji6vV8ruTsmBMt02jpNDkEaq3ph+W2pP+bf3GsrXY+UpfiKN aD1lASj8ADnQfm7g/uzkH8uSaAqzg1ZV9uAd/bxtksp2Hyrxg2gPiCGVXeWWgdYHoZcY jMqm5MJZS86V64CeQNNvyHpuG/5r2Ouo6PJqEu/s6h+VrkiywO2t1Cv0DkXZAyGWeD2J lw/H+ZMBUp4M1sRBBzXgoZk8QMhYbjRbNDlGOyTzNPhoNbYyr4VcBVcK5rz3OjPNbW84 KM4n7o+8Yx9hjWtT+HMJyLgzT1LfjyPgXiSB3GcwzHo/rw0Z+mpKR8YEuRHR63uR27PP kQYw== X-Forwarded-Encrypted: i=1; AJvYcCUK9WBfKRTrGosHHNlEFohNW7fRLXFLvACYWv/3IPyFN6p7q277BgVT5R9XNhodu76VUsbjKzGrbXNRhUo=@vger.kernel.org X-Gm-Message-State: AOJu0YxSjQrrPLgZcKoYEA9I5ENtneakjAX+mu4UTk4lNpPrrgUp4MP0 JSqkEPsawxsNmhTtNC+YgDQBF9/InfKjttZ0SljCkwCrtpc1ltAQGQDILXFkEL9w+MA= X-Gm-Gg: AY/fxX7bQogcm8/Jz5MITQs8RnO2PseH4nD/NwNyn8vAScT5UU/WmqNA4k72Q7d+lsO JPhrKkZxAeYYjt+0NofzMvkwp2J4O5SqIW18T3YZkqJ1qFpN2PQYu3QI1vhBGSNzB9NnFp13jdu z8m+GWxFBavmFlqlowlufSFd+ubDHwhRWyDGQdjDZcHYwT58LEhWXPge1l2/ZgJRjV2U1lZi0SJ PtNcsMkl2NupPWceVXmfkvcTG6Vm9Da6//XmseMvg1TtUURYTxOvhNO+yp9Ad6ak4hyGNwbZvzV QYs01SmGrxmByN3IgNFpLh1JlqeYVUGpwOyNVIQTVDjPBiJSTVAkLJk09SIeS61L+TniZ1V5l5W 0q9lthkC2f5ZmD+Z6PqzDTRvxaOUoF107NUhnkxkTD9mOAQYbTWxAvQVd0m6+Z6IHPbVK0nebXF flKMb8LhnOXiumbNkT X-Google-Smtp-Source: AGHT+IH2hmS7gnHrym6BlZDJPvms24FqDpXh/5usVOeYZs9oX/On+LAvByornqMlQyiobOiJjnzxJA== X-Received: by 2002:a05:6000:400f:b0:430:f742:fbb8 with SMTP id ffacd0b85a97d-4324e4cc56amr5628044f8f.21.1766220343511; Sat, 20 Dec 2025 00:45:43 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eab33f5sm9530459f8f.41.2025.12.20.00.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Dec 2025 00:45:43 -0800 (PST) Date: Sat, 20 Dec 2025 11:45:40 +0300 From: Dan Carpenter To: Shuming Fan Cc: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] ASoC: rt1320: Fix retry checking in rt1320_rae_load() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This loop iterates 200 times and then gives up. The problem is that currently the loop exits with "retry" set to -1 on the failure path but the check for failure expects it to be 0. Change from a post-op to a pre-op so that it exits with "retry" set to 0. Fixes: 22937af75abb ("ASoC: rt1320: support RAE parameters loading") Signed-off-by: Dan Carpenter Acked-by: Shuming Fan --- Technically now the loop only tries 199 times after my change, however I am okay with that. sound/soc/codecs/rt1320-sdw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt1320-sdw.c b/sound/soc/codecs/rt1320-sdw.c index 9447e742c672..c0acb6ac462d 100644 --- a/sound/soc/codecs/rt1320-sdw.c +++ b/sound/soc/codecs/rt1320-sdw.c @@ -1480,7 +1480,7 @@ static int rt1320_rae_load(struct rt1320_sdw_priv *rt= 1320) /* RAE stop & CRC disable */ regmap_update_bits(rt1320->regmap, 0xe803, 0xbc, 0x00); =20 - while (retry--) { + while (--retry) { regmap_read(rt1320->regmap, 0xe83f, &value); if (value & 0x40) break; --=20 2.51.0