From nobody Fri Dec 19 13:31:07 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2FD219049B for ; Sun, 7 Dec 2025 12:39:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765111200; cv=none; b=QdmID7+fBQEGx30lQtfkuLCbKRKsAKTxh3LeLOv0AWW3MY7NV4UxxlQ7B6L/L50elJ+v0X/pSS9AxrRDPYfxjh0r0DgX85JVT8wZfKQovxUiKUWKcsuOR9GPwA74wsPIq6VdLJaZ8GLnp0Ksq3QaI4A3mr6icTuruqRTHuCyQP0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765111200; c=relaxed/simple; bh=Ytz+SZqOIW+Xy5xzf61tHStbY6EtoqoLzDhjnRsCsAk=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=WdY5vJtiuCL9xPXW6ij4CqTOLpG252rZvCjdJ68IYIhQizfR2L3fq1FE0OF4tbGgo7HbxKIyJxhhNrHMGS4aoSLE7VqWxjwI6n8Gf4VoFj8F+J6DVCwT8ebmWkPo9Va1aEkctYZ5NeWYPzTIsYOnDLjaJIJ/gBoPwk2Jyy3VMwc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=f8q3++9s; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f8q3++9s" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765111196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=rgXA81QLeZ8uxrq5YssERSuP8GaYN0hU+8W5qT5Vtak=; b=f8q3++9sODGQn7h6GPzcrH0t6IqxQcKsonevjTZjPzJ+kUGYeRN4lIaAX1sys4uPdgqSU1 EpJBFKU6cBElUvsUhbtHvqZAtZqXoygAA0zGnu14+oxLpvXjTXoIL0RdiukYY9ifhsgrwS 6XFVaR0vwAaq62VOxTcHR9K4sVDCK1U= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-PXj43SbAMtaj8nAdWGYIEA-1; Sun, 07 Dec 2025 07:39:54 -0500 X-MC-Unique: PXj43SbAMtaj8nAdWGYIEA-1 X-Mimecast-MFC-AGG-ID: PXj43SbAMtaj8nAdWGYIEA_1765111191 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8766018002C0; Sun, 7 Dec 2025 12:39:50 +0000 (UTC) Received: from fedora (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 76BD5180044F; Sun, 7 Dec 2025 12:39:40 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sun, 7 Dec 2025 13:39:52 +0100 (CET) Date: Sun, 7 Dec 2025 13:39:41 +0100 From: Oleg Nesterov To: Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan , Felix Kuehling , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Boris Brezillon , Rob Herring , Steven Price , =?iso-8859-1?Q?Adri=E1n?= Larumbe , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Liviu Dudau , Jason Gunthorpe , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 4/7] drm/amd: kill the outdated "Only the pthreads threading model is supported" checks Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Nowaday task->group_leader->mm !=3D task->mm is only possible if a) task is not a group leader and b) task->group_leader->mm =3D=3D NULL because task->group_leader has already exited using sys_exit(). I don't think that drm/amd tries to detect/nack this case. Signed-off-by: Oleg Nesterov Acked-by: Felix Kuehling Reviewed-by: Christian K=C3=B6nig --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 10 ---------- 2 files changed, 13 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/a= mdgpu/amdgpu_vm.c index a0f8ba382b9e..e44f158a11f0 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c @@ -2551,9 +2551,6 @@ void amdgpu_vm_set_task_info(struct amdgpu_vm *vm) vm->task_info->task.pid =3D current->pid; get_task_comm(vm->task_info->task.comm, current); =20 - if (current->group_leader->mm !=3D current->mm) - return; - vm->task_info->tgid =3D current->tgid; get_task_comm(vm->task_info->process_name, current->group_leader); } diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd= /amdkfd/kfd_process.c index a085faac9fe1..f8ef18a3aa71 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c @@ -833,12 +833,6 @@ struct kfd_process *kfd_create_process(struct task_str= uct *thread) if (!(thread->mm && mmget_not_zero(thread->mm))) return ERR_PTR(-EINVAL); =20 - /* Only the pthreads threading model is supported. */ - if (thread->group_leader->mm !=3D thread->mm) { - mmput(thread->mm); - return ERR_PTR(-EINVAL); - } - /* If the process just called exec(3), it is possible that the * cleanup of the kfd_process (following the release of the mm * of the old process image) is still in the cleanup work queue. @@ -918,10 +912,6 @@ struct kfd_process *kfd_get_process(const struct task_= struct *thread) if (!thread->mm) return ERR_PTR(-EINVAL); =20 - /* Only the pthreads threading model is supported. */ - if (thread->group_leader->mm !=3D thread->mm) - return ERR_PTR(-EINVAL); - process =3D find_process(thread, false); if (!process) return ERR_PTR(-EINVAL); --=20 2.52.0