From nobody Sun Feb 8 02:34:48 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EC0D279DAB for ; Fri, 5 Dec 2025 11:39:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764934752; cv=none; b=keLgCeA44wtSFhkP4EItlW0PIoNPKhg7CtI75//34vuyyPkWQbH1qGzVo+3bci+a1zedVcQHAC2dHlVwbKgqT6wI1cEfH85UYAtNEJIu2PmTK/PFMwmdMvFjGseWzf/DSVurfkKtuFOyBxAm0jSbj0zqFP+COZAfpkV0ntVrsKY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764934752; c=relaxed/simple; bh=TVVtGnBO/kgt+MW43a4WOfzk9YnJRjsgyZDeLmIwQUY=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=nPa5ygYraMM8Xdhbi+CqpC4bFwaHt1jM8UzZanpwSJ5nKj7jaYOycwYwY39J4fJBE0kotZaysRMX5y4PId0M3eolMXNHQOqZKsS6rkrOPp1W7fVQaEYPoXsGNaOVQekSR9vuBQh9+38qeR51IJ85dPWqF31n4+L7rZW/zN1gf3A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=d3QBIYmS; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="d3QBIYmS" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-477bf34f5f5so16293655e9.0 for ; Fri, 05 Dec 2025 03:39:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764934747; x=1765539547; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=8aX+EX0NpaccXweXp78xCHa7QYL2+QD6+NVQreKl8cY=; b=d3QBIYmSN37tc31xE3YCK4tMVilfQQUiOPnkcvanqKSw4mCnNTIuNxQgQRf+jEBOHM LqZU98xvdWE7V4Y5SgNB0zbMxk3UK8L4KplJbZkBpFpDXXumMZTWu/u8avM/UpIdiTJJ GKaiRiB74Odu7iWWB0RW06Ix7evS6B9RNi8QvG8lTNuKmGU5yxb1Ur4rPT5cTEP3bahj 1fu5UxotxPwZ992HGoZNE2N9Juo8ZD9xzvnCys1hiVxivBojeVo6S2aVj8uo6h3xa1T1 P8lefDST7YfAJcj1QdIaOwXOaMgs5ocIncYq9HVIm6afIhWJb+/agHFX94WmBx7l/7sr a9ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764934747; x=1765539547; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8aX+EX0NpaccXweXp78xCHa7QYL2+QD6+NVQreKl8cY=; b=bY+ThRJBVY02242x2TRVIAwjWBN0Onx0x8Prn1Z/Brvz6luKAo3Gm/gofkPU5PNlKq PUVu/G5SrZoe0Vs55dY+r5Abutvg1ZJR40sei+BSlfINmUEZpv+jjtSwoS52F7hGGZp4 4Ea3YvJeHFxVa2Qrj951LB/wDCKzFRvMcV4TgVj/mkNP9ohKNIA33zE8ie5QJQO/rGvl dfvOpUuD+HBl1SuCOh3Jegh4y9MucerS+tfrx23znuY90fo6uqQmEyGZCD6CnXzdUgVL 1c08CcS/0QiOFwtaBKp2NdJBtSsSBhi3qHIYno3xixq2WPrfhY8n2pilaBonNDJW+Ydq WJ0w== X-Forwarded-Encrypted: i=1; AJvYcCWQ7hoQIR605LCGzbwXnyhdjV3mlS8hdvqqTFM1qMrWsHg4vO+zRpKao89noQRKfJePccEmV5Mzxe2Sf0Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwXEHqplkSaisc+tTHsALXNrB6LKi8+lBcue/nzLJavqb0QOtvm wlMMjZZEk/kyTzLh5lh74XH6yHFq5yVKQfNfUUMjrSSmhV+ie1hqGiSWJQGe+19uM3g= X-Gm-Gg: ASbGncts10BSVioCOjfYffKp52ZwWOjkc5X2nDtR1bC6ntEkIKNX+Zj1Zl2IxS42PK7 jno3h6ZhDc3oS3ajSZPVMqvO56YSL7Gc98GpLQFgNJFrsyweeSGitEEWqw7yi9vs26clYK5ff5f s6nB23NtlumAUZY55WTT1oWIGRRsa90SidbghQ1PBGn+qhpBj4bBi0SRSHr9srYn5Pm2ZWKO+KI /+PxWvkABHIKztlKKBv6FImnwwvdYYSjqbh1f8SaZAaqNARqsHqfdIreunNrKkCApdvjGow+uyW 4x9ljKM4Rt8uvWgzv8tDVRv+sNSaxlY4Z7PuBmW8ruPJdy/4D/nEZl78WziF7pgPFTske02LDBE xw3t0UbB/wa5US71Wxl+gqi+7VfOUm7OX2WN9BpoNPNndpfSJ+9HYRC8izCoSwjsSdCfZy/yBhx 2Y2ZR8vH3mjOFUOtAu X-Google-Smtp-Source: AGHT+IETbivJfBcDFqX/qYauRBKsQ++55ebaSqc3KEhL3Ernui7SaVmRbHIyHQmMXTPmCfMZXsNxvw== X-Received: by 2002:a05:600c:4584:b0:475:dd89:abc with SMTP id 5b1f17b1804b1-4792f25b843mr62826545e9.11.1764934746896; Fri, 05 Dec 2025 03:39:06 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47935fce542sm23520885e9.0.2025.12.05.03.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 03:39:05 -0800 (PST) Date: Fri, 5 Dec 2025 14:39:02 +0300 From: Dan Carpenter To: Alexey Kardashevskiy Cc: Ashish Kalra , Tom Lendacky , John Allen , Herbert Xu , "David S. Miller" , Dan Williams , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] crypto/ccp: sev-dev-tsm: fix use after free in sev_tsm_init_locked() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This code frees "t" and then dereferences it on the next line to print the error code. Re-order the code to avoid the use after free. Fixes: 3532f6154971 ("crypto/ccp: Implement SEV-TIO PCIe IDE (phase1)") Signed-off-by: Dan Carpenter Reviewed-by: Tom Lendacky --- drivers/crypto/ccp/sev-dev-tsm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/ccp/sev-dev-tsm.c b/drivers/crypto/ccp/sev-dev-= tsm.c index ea29cd5d0ff9..06e9f0bc153e 100644 --- a/drivers/crypto/ccp/sev-dev-tsm.c +++ b/drivers/crypto/ccp/sev-dev-tsm.c @@ -391,9 +391,9 @@ void sev_tsm_init_locked(struct sev_device *sev, void *= tio_status_page) return; =20 error_exit: - kfree(t); pr_err("Failed to enable SEV-TIO: ret=3D%d en=3D%d initdone=3D%d SEV=3D%d= \n", ret, t->tio_en, t->tio_init_done, boot_cpu_has(X86_FEATURE_SEV)); + kfree(t); } =20 void sev_tsm_uninit(struct sev_device *sev) --=20 2.51.0