From nobody Sun Feb 8 05:41:18 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F4E430C61F for ; Fri, 5 Dec 2025 11:09:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764932974; cv=none; b=TtQUxUbksmDm4z1wp3yPnKJV5x/4VoxGdUX44qPM5KunPVojz0t+VaZ/cz8A2t8OptWxDyKvZFvGZneuddAqq2yeneCIlmBIWNb9yT2Bz5mi2rjQS7mKDSWlDti8oThA2k41r1WuPfhUlhX92v/3nnYnK97/8/4QG04ndcclJbk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764932974; c=relaxed/simple; bh=HQEN6OeKnX1NuKSfZHIbuNkIh3NrW5bHqOizNUsFAbs=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=JFXkM7p6t+LLQK3Ac2CSD477C8DVc4TKxqI11FwZTztxhZEvaNZgc7Mx4UElfFiNOggF3Akk8Ow6HG1dPi/JQGYrsi1qCun4w/fgBsj0glNyPwhiixTx86OBoEbxGTY2+KtKPboxYL8zYBaFtIhw2s7onk+G31EGOWaQtNFQ30o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KPLJYvsw; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KPLJYvsw" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-477b91680f8so19760215e9.0 for ; Fri, 05 Dec 2025 03:09:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764932970; x=1765537770; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=p/C0PagtTMInOFxe3qelV765/5mfYdQN+er9ThsJgfE=; b=KPLJYvswEribdTCcfMAIfjQ3Gw5DpoyzSYrfb7OE3ssBevV6V2XnSbeVBCdsozajEN 02JR6iY5NZp7gizNdFPP+zl5w+pxU5nJ7p61BTwtHoMXy4jJkhZBiLOFa5DhsU+vGrRS 3/jrd2y0kzBMQrpnBLQINTlOZY8IOTuU/7swPijwqyQWdKJhmuEy2GznYJGbFG3MCnJF zJyeGrfeMaEyPHslA3VwMqJeoT+/AwNbXxsOAiw1J078zflFbXDHZFQKVGb0T2i7kP5P ED80htgxQNwp8yv07iiMtvU1XziVOSd84ljTKOdBFJiNJg5dtpo2iM0kfM9OqmcD4oSA V9QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764932970; x=1765537770; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p/C0PagtTMInOFxe3qelV765/5mfYdQN+er9ThsJgfE=; b=JZF62vlYSS6YbrgS1gJgNKP23wvOqJt1EJ0nNtwpi6hPF4/Vt8OJW1NjdtF2gefbol yOYlFGAu8/+gYtuNMfR15e262y86dylyfAivUvSYUjpSuX7K6qAuZnQoztZSLhaOLuMt IXmv/RCu5RlzPhOS3MBg77246r90/YuSqosv874BEW+2kWbUW+oPjzI3txLwUlPgFATI viCKxUJqd32snDmZdoM/cZEI+JTcsVx5dsEarPT0bdAcmC6hpIVSgSwleuHSIjU3QAX7 KgNG03Of7YQBrgwuTqEP5dY4LtlUnqbHcfaQioO6sbcIjpqX2qkZ//3UibT6CB2Zkh5B yDaA== X-Forwarded-Encrypted: i=1; AJvYcCWxT3/S2OPkyV44oDDWSkR26VSplhO799S5bRkKDINqIUGmKgF5o880BsnYiqCUC/9YdtmBvGWa+a4hEyQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwB99NKwhOVpL+Wo3JILZh9TIqMigqF1a26dpBA1QRcKnSyL+01 YQNTbP2DRwguMk77Cif53HAqFUdwv0h5KQH3Io3DBqycw59WSEY1Sd5gz7YA3n0Cxxk= X-Gm-Gg: ASbGnct84cBjYqYO906FENt/iFJk9u1ZMDbNl9xBnG+d1lTHI5XhpD12m2zx5Pj7KD3 CMpfezL/lW3Z1075uqphh2BhFzfbvotSkJrFBt9nc0qeo92bxgzjh/PkHoNHv4Ik0P6Ft8zsYw5 4rO6+SRrOkjJUonO32Rr/poIsrtmeoXlvsK2UChtOHtTX64p8KdaVw+S4SzJzrxoy5AfMrE9H5Y 9sY7QDfOhR1gqurDguGmNb/T9c2z964R9oaWfNiBys7oS6WduKOSqSM16vdCHTCvJycGmc2hrzp be8HESCI1NBmzuuodsmkVevmOzKup4aEkyA5pRKCzCX/gvAWmIMzlOO3lT6+SAJ2DkEqCCxt0tz 4vKi3bCbm3/9l9BJ8NtnzU+dsz5qFZzp/+WJh61LxC+D+fvtRcvVHv4iHeoUTmNJPDP6IDMNt+D WcJRPvkU3BTjU3oN6H X-Google-Smtp-Source: AGHT+IHCkU5CgfbT6Uz9t3Nb4ylQ2nrafmcxdx4Hm3Q2PBKnBoGZ/U3wVfqkqFkieDHCTVyrSxNH0A== X-Received: by 2002:a05:600c:1d0e:b0:46e:59bd:f7d3 with SMTP id 5b1f17b1804b1-4792af321b8mr94681325e9.20.1764932969765; Fri, 05 Dec 2025 03:09:29 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-479310b8e70sm78214345e9.5.2025.12.05.03.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 03:09:29 -0800 (PST) Date: Fri, 5 Dec 2025 14:09:25 +0300 From: Dan Carpenter To: Harry Wentland Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Simon Ser , Alex Hung , Sebastian Wick , Daniel Stone , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm/plane: Fix IS_ERR() vs NULL bug drm_plane_create_color_pipeline_property() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The drm_property_create_enum() function returns NULL on error, it never returns error pointers. Fix the error checking to match. Fixes: 2afc3184f3b3 ("drm/plane: Add COLOR PIPELINE property") Signed-off-by: Dan Carpenter Reviewed-by: Simon Ser --- drivers/gpu/drm/drm_plane.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index ce76c55913f7..e32c7ea8551c 100644 --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -1867,9 +1867,9 @@ int drm_plane_create_color_pipeline_property(struct d= rm_plane *plane, prop =3D drm_property_create_enum(plane->dev, DRM_MODE_PROP_ATOMIC, "COLOR_PIPELINE", all_pipelines, len); - if (IS_ERR(prop)) { + if (!prop) { kfree(all_pipelines); - return PTR_ERR(prop); + return -ENOMEM; } =20 drm_object_attach_property(&plane->base, prop, 0); --=20 2.51.0