From nobody Mon Dec 1 22:36:26 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83A12274FD3 for ; Sat, 29 Nov 2025 14:50:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427847; cv=none; b=GStq+VBq0EBZMZ7z/kaovo7VsfGlBC3kGJtmmQVNRBqs0DXsaVk7QKjETfjmkEVnisL6OzxqRikwg0u4Vz3PulN5mzMCprGsmChcz9m0yzJ+m+aPxVrq729Qay5Ku3NT191teXkohitEe/0JEKelretjLkEpOkQY+HS/vQE6VZo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427847; c=relaxed/simple; bh=J5zPGbJTnILt+tpvDM7cBZAP5RPjho+gmkFk+nltQzM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=DHkYGRR3IPCR4Y1TTv2fohVKMniM5cBIik7Sixp0xumBir9NGIa4aZ19rHFoiBD2+K3L3t+gUX1PvAxyoREfMahl40XuaYd+QpKiJ7Vdub9ovteu8UqJ+JG8TAmnZyjEC7qeCnZPPwtRBRhYtJ92eqK9iIDXTIHJ0sg1ZIlWfKE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=u/hVpss+; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="u/hVpss+" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-42b31507ed8so2488911f8f.1 for ; Sat, 29 Nov 2025 06:50:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764427844; x=1765032644; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=m+0Wdrus7bMlJRqb6V1pME87+u16xr1L8R/gLBLUKRI=; b=u/hVpss+JAswZ1ZM/KEAnUOOqJ+mH3ZPwrH1u1VqEXwRLox+YH7hCApQSzXrzaQVO1 Dx1OKG0r2OazK0hn66splmpcUZNnoydY9t48uH5Ry7RJuor161684g2OocWrb4/KTj6y 3yJRia1HNe2nqYhKinSPMtRVLJ3LCUCb+g2WyVafV1W2ucblOtS5BzmS5NXRyCmiP+zC L6ePNkNcPXBdg3s2x7CWIrKxvDRmWWjDBGuYGDsCld1Ny/ve24cbT0NiMtyEhzIXtEuM J68dPyLAzXM5KM/gU6mqPxCVpVUn+HGLHH4zIN1sIIsNsx4R3sMi+2uciVkOzal+MyPR 0yTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764427844; x=1765032644; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=m+0Wdrus7bMlJRqb6V1pME87+u16xr1L8R/gLBLUKRI=; b=itvNuWCyMRvGnWNo4DxE2Kc8RI/6MxfocgkaOxTPbADVGDViXWk6IgJnBLmKXb9gf6 32vht4OQS2SEBW1Eycoi6FFJknvGhRnjsHJMnV07uphP9H+4qYOOyTYCyT+XTVfAI7KR IEXXOR4rLC3X7TMTV8Nzq8ws9BXDvWEGepwCqdH9wmyrdw3VKmC/ceDab/agGgfCp39+ 9B2MLlphP1aTnh27FljGD9MKd5MWlnrjEu1Cm3+4OtRlYascLE/rx77jksX+QyX8L8aU iBMBFztvkSKem+kE5qE2ORbAh3dBICDZxMBDpvoMDOTJ8cIS8YHVLOr/AdQuQ8JL4dFl 4B+w== X-Forwarded-Encrypted: i=1; AJvYcCWqDwdCNvpPzy/1gpAPHTSSGkvRNEnifoFSGF8YSLjaqlnD2Le8WM53GKmwMevVv7OhFS69KzhSZ96Ys7A=@vger.kernel.org X-Gm-Message-State: AOJu0Yxxn3zg9kneTOvcuDFcnVC+Mawu/9uKk5jTL0mO4Vvp8e5f3WIs ODnmzWmrazY0Sqlj3GBXdw5zzsOIzjaXnXZPznvaK9Lq0lRw7ACnwEEbioe98qie2/w= X-Gm-Gg: ASbGncsl0mIsAXqfqShNPXtYnwNflR7ktf89nforSTojFiZnsek+N0QjLq4Z1+WI5wg Ne6pSiVkClKADNY6H5JVK6ch8iaiCYLhejyjz/kyNJMghuEfXxQi3bXLr/oXGdYAQtZFigr9TD6 NVYRJbyLptset+CRlNKowgV12cPdqFa39u+/ElQNDQG4lf2x9TEydKydGD3hcOj4dbWNznMFl/K SBHlt60e2VEtwH+d237bjL/qAkRgAWtYa+CdZlyOyvJ5Y06wpI7T75U26n1VVqibRz5+Fh7+9gl 7g2Z4Gklx407BwHemkVgmUWJ7W4UkEIPC5cx36koqRrelHutw3hGYoAbgVVQAnz38qWAwTMCvVz Sc8AKThYqm3C5fmgyVe1/cMaNaVycsRQbaKScWouu2gVBRnQprFO5GeHFQgWkHmSZW0wffFADy5 08WkdcoQfUIFDgpoh5 X-Google-Smtp-Source: AGHT+IH4TkVKjgwG9GJixr3YdNDKWfYNOqAZur0LDZWb7kXIBUGv/MfkS8v7aEbUV7sbsGFPBt3PuA== X-Received: by 2002:a05:6000:3106:b0:429:cda2:9ffe with SMTP id ffacd0b85a97d-42e0f1fb97amr21173345f8f.7.1764427843628; Sat, 29 Nov 2025 06:50:43 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42e1ca9aea3sm15375037f8f.35.2025.11.29.06.50.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 06:50:42 -0800 (PST) Date: Sat, 29 Nov 2025 17:50:39 +0300 From: Dan Carpenter To: Thomas Richard Cc: Peter Rosin , Krzysztof Kozlowski , Andrew Davis , Thorsten Blum , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] mux: mmio: Fix IS_ERR() vs NULL check in probe() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The devm_kmalloc() function never returns error pointers, it returns NULL on error. Fix the error checking. Fixes: 4863cb2b0f50 ("mux: mmio: Add suspend and resume support") Signed-off-by: Dan Carpenter Reviewed-by: Krzysztof Kozlowski --- drivers/mux/mmio.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mux/mmio.c b/drivers/mux/mmio.c index e4ddb1e61923..3409af1ffb80 100644 --- a/drivers/mux/mmio.c +++ b/drivers/mux/mmio.c @@ -101,13 +101,13 @@ static int mux_mmio_probe(struct platform_device *pde= v) mux_mmio =3D mux_chip_priv(mux_chip); =20 mux_mmio->fields =3D devm_kmalloc(dev, num_fields * sizeof(*mux_mmio->fie= lds), GFP_KERNEL); - if (IS_ERR(mux_mmio->fields)) - return PTR_ERR(mux_mmio->fields); + if (!mux_mmio->fields) + return -ENOMEM; =20 mux_mmio->hardware_states =3D devm_kmalloc(dev, num_fields * sizeof(*mux_mmio->hardware_states), GFP_KERNEL); - if (IS_ERR(mux_mmio->hardware_states)) - return PTR_ERR(mux_mmio->hardware_states); + if (!mux_mmio->hardware_states) + return -ENOMEM; =20 for (i =3D 0; i < num_fields; i++) { struct mux_control *mux =3D &mux_chip->mux[i]; --=20 2.51.0