From nobody Sat Feb 7 22:07:22 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B89572D6608 for ; Fri, 28 Nov 2025 07:18:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764314284; cv=none; b=eQv8bqft8x92m6GqGEi99JHk7TifWk7oz5WUEtHzW40TWThbKlFLZ39aZOIeHtT166T+6T4La9yPkvO4rdUm3dlL8nQVj6GJ0V0yUa3ly3E2C/rsMQtyeJRMyzlDbSITZtfWpphQ+g1NObyuuU5LxUmx4Ek8/Id0grXDmBo1w2U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764314284; c=relaxed/simple; bh=fGe+nHBgqjnuXX4Zgz4nOkEHxwuFtR0ZX4+FNRv7TYE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=c86jpa8dYYMgKWAnSSTrdS98078WoDVluj48sPB+idX0GywWf2vNOzXdPQ6cVoAxam/CxMvb+mHdblr8x0TzLp4VQweFn3/WC6c7C7BDe+yXZIhq8Oj0jmEKfO+xKiUuM4hG8q2/cb0tmLikrDB03VIW3nOhSU0snOhiuKVnuX0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=sv2G0ORk; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sv2G0ORk" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-42b2e9ac45aso962601f8f.0 for ; Thu, 27 Nov 2025 23:18:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764314281; x=1764919081; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=c1lnMlPJCV6DA11oj/bOj969pPM/KGvJxcxKxlFLMzs=; b=sv2G0ORkjoAaPN4k99IlCMKzvBZfe5MSHit0yF2hstCccycV6PFKrElmXfrT04aXRx avY5k1ovgWXpxq9X0ebm4PPS6Iwpn2tIvqZWhLlBGNRuzEBquJ5hPKinM8+j6urMl3l3 Hzm34hgyddUSI8NH2N5txqXkdEhtfMyZr0sgTiSlFCP1MpA8ylbB57YMWetJVtB52Ics HMvS42o4A8GH/CDSlqyzITjlNrBrhCzi6N2OyLFAvVr5CyNCYVbuJc33F+VlaPRBOvwK XtNvcO3eXcuaWqpTGV0ogq1EXA4tmH5e7dw6GHwRkrr99HPjE3EQ7lakXggy9PJ/EyDF CcTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764314281; x=1764919081; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c1lnMlPJCV6DA11oj/bOj969pPM/KGvJxcxKxlFLMzs=; b=Pr/RTGFUizOypIK5vCznzWb+mo60MZEEMvdv8ogV3HMUuhI7NwwP2vcl/KFajIg+iB wA4PJ+emsf/h0/cCBTTbvjpW4a9SAONc+Ie7FP4wEv17tQ7VhwvSjGEUEYEK19DJhOLR hu1y30gfzXmIvQjSEAidSjpkpBb9gfG/Iczz0sCfLb5G0dEagpLawBZDlMGuVj8Ati0c rfhUOInet/5gqd5sULXgxdkvv4ms5mDHjibyJFyUn+JzDxgom08G4I5VwVpuwr+8Mc/6 D2VvWITzQs8RKesTKPXs/MpVkW/KclFgn1FnrNlBd3IHKbxai6kPycfZ+Tz1GrMFX/nq x5+w== X-Forwarded-Encrypted: i=1; AJvYcCUoaG7EX6+RrsLwu5H1+c5+YzDZnLe8BZPBg5QSoSk9mwdYmA2jUCkAmFBXVNsIPS0GNhPdy8VPHDbf2IU=@vger.kernel.org X-Gm-Message-State: AOJu0YyGMgb1ukt3sxBgIQ/9Fl1/YuvHeJD2JZwMw/kalvfcO/oo/Ow4 WxyKoYxmI3EPPY7saFQpFJl1u1yjhK4szRS1aQT0RZQZtv0hg+toxE4F1eo/k1o9UT8= X-Gm-Gg: ASbGncvU00jcGN1vLsHHC/zVR9qZDtfV4W93f3jzXmxGgyZ/GuTKfVYGUl7A3JvmKyK 05PdQ5de46E3zlwsH1yTHzplraMRBIqT+JZjHoa/QwdLq3xW9Cf5vJW67/CHsr1ipNcjTG5wdvw e6Vph3A820QKjIcmv1q750+Fq3a5ZXO1Sk0CNmO0cAkGDWxl37ue8wMQcfJpPFRiDXgBzc+vOVQ D8FrhSDdd9zVQSA1FIc+OeiRP2xHun4JmS1T/4lOcJmSQyadsIBzZwVSSlIikeRyhK7hTqCSUBx k1284vgu3Z4uW6rvpR17dQiALRwC7xjOHHHanH3jrpf0X6Tx/nKmyiF/dgippZtsxRLX6I7Dctz lLI2pOJUtQ+T7VhTztchFUqIPx1FNlGNDeY1mKBkq8e1HIxh+l792GIi5+Kto5NufAFQzuKKlqO AM3k3Ca+Ie40mophXN X-Google-Smtp-Source: AGHT+IE/vF207ynThbqS/gDZLvJNkmiYWvWDCH+AiSXpAgbbcaT5jU5/c/AmtDqFX8SL4gsnjq1wgQ== X-Received: by 2002:a05:6000:1862:b0:42b:3ee9:4771 with SMTP id ffacd0b85a97d-42e0f22a21dmr14964083f8f.23.1764314281092; Thu, 27 Nov 2025 23:18:01 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42e1cab9af3sm7899692f8f.41.2025.11.27.23.18.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 23:18:00 -0800 (PST) Date: Fri, 28 Nov 2025 10:17:57 +0300 From: Dan Carpenter To: Dave Penkler Cc: Greg Kroah-Hartman , Michael Rubin , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] gpib: Fix error code in ni_usb_write_registers() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If ni_usb_receive_bulk_msg() succeeds but without reading 16 bytes, then the error code needs to be set. The current code returns success. Fixes: 4e127de14fa7 ("staging: gpib: Add National Instruments USB GPIB driv= er") Signed-off-by: Dan Carpenter --- drivers/gpib/ni_usb/ni_usb_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpib/ni_usb/ni_usb_gpib.c b/drivers/gpib/ni_usb/ni_usb= _gpib.c index 1f8412de9fa3..fdcaa6c00bfe 100644 --- a/drivers/gpib/ni_usb/ni_usb_gpib.c +++ b/drivers/gpib/ni_usb/ni_usb_gpib.c @@ -566,7 +566,7 @@ static int ni_usb_write_registers(struct ni_usb_priv *n= i_priv, retval, bytes_read); ni_usb_dump_raw_block(in_data, bytes_read); kfree(in_data); - return retval; + return retval ?: -EINVAL; } =20 mutex_unlock(&ni_priv->addressed_transfer_lock); --=20 2.51.0