From nobody Mon Dec 1 21:30:05 2025 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33B5D2D641F for ; Fri, 28 Nov 2025 07:17:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764314276; cv=none; b=YngGS+x89rb27bQsJ9M00cCEicWMyWNlbkYk5gNcrWnhJoeOYr6c6uKu5aiUpyd1pKgtFFsBJ9vHYlvVYT3JgKjRlzJfjnQKwyhuGOplIUVa8Q7Mj6KMfPSeeW0rEKBb6Drr1BV/x7PvovSJfVk+V8lKR7lRozmKI8UR2rcqApo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764314276; c=relaxed/simple; bh=KoHI54xKO6w4vhThwhJrArEjSn2FRb5H0Tw2vvN1TzY=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Uxfahix9xXkd7zwbe6Z79OxmS1+qb8Fg56irY4iTc6ZkBw4Wjwkm712CfsNYZgmjJVQmjhLZOSjmvWKAgRZJHEJBGZngeaAqbBMebIBH+wMroFP3WqZK3tb7C8qeexySowykQWaaaGz7UmrzphdMpM4A3RzLRMZb4LGR9Csjdsw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Xu2aOICF; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Xu2aOICF" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-64162c04f90so2816884a12.0 for ; Thu, 27 Nov 2025 23:17:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764314273; x=1764919073; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=lWBXP38Y0RctBSxgnReoDAFsYXDk+HV4r4KizoiM/N8=; b=Xu2aOICF7fjzCqdUJHKiMGZhgJByTzHUCQrpqYUskV/uw9ijbyFmSA5CVPAwPnfGvy /aYALz6XIu+6LdB8y5om3ogS8dgppr2y3/Tj3dAyAfAMl7GzRmouCgnWQ3VD8PiwKaZG HCn0LuH/ThQjryr2KLhyVwNbXT4V6c7qzo7QphfT2s4ub+petc0yYxXNEbUn6ZI9NKyP o0nLwW88OUlSZMRpu4puSK2PoGlSd2Szd08DRihxnCrNxcRkfFyf1iDofujOgzxK2Ayc RKcODEeXyWTUG+1q42WklUHFPeHgK7S4xKKgfmYPiAZczAWhR4EhkzackjXTJL1Zq3dW DNQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764314273; x=1764919073; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lWBXP38Y0RctBSxgnReoDAFsYXDk+HV4r4KizoiM/N8=; b=ehYfNeIcv2wGl+6PAol/NsctRafg4jJi/z2MTfW973413OTjLzsMa2Ro/+LwTuu+xw yUUUb9dC7wxHOw4CW1aSd0BvyhwXNFVTLFjcFAVvS7+S7Ak6wcn07dOz7JAreYxpSMGg h+s5ZNHOHqZ0e+FvvCYu5q8mWIpr72LfrTDuQhoKHgUQUK5J71JcxwX2KPIr8qL702Gy zhL6cgFHv+PyO+TFUTvinKVBgDxmXkZv3MlHbafeV0e1eVYiRTKCbHFuGj9tTXaerPbK SnOyMqafvHB97uTPgycLo+xo90pyGL+bnL3kXYf8O1zbh/GVzO/OkVJWypkvpNAK9MAk dI9A== X-Forwarded-Encrypted: i=1; AJvYcCUEkfya1aP8C9NLiCS7R6XD4sGv0toMPXudXi5Ah5TFRL7l33OLSUdCkHaeEXJp6ySmbQXlNROEJB5wlNM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9CIHzgj5tEKpOwjWOyiUr/2+49/UjbUZEq+RNU8fwnd4jobt0 +iypBreLN++5XXN3q3uHRRc97SeHupBQrQcLerYAoYpRLGwx7BAjtdIwKAk04pUvsTE= X-Gm-Gg: ASbGncur4Xi3/0xsjaqg9iHH6Ceg994rO/eS4QvZSdJdDtgX8tXjsS1bGFDUuyodcYi quvIwfJvUVhxvk00CKWjExFvCyPwHVOhgOeyhoJO+ceykj8adwMEPT7Ud3JUTEA797zsfppe4Qe bO8aEEcw75OnTzpmnsnFsQLNuQ9OxGpdTWx6sAkYDij9SKxin4W4KCzWDsSYYX2cGZzswzdDtin G4No7EA6/bLUaniQReiBIfeAZHAYUt/ZSh4xetG3T68lmmiatKkZXxFrCggONISxYMlSCVC7dc6 wyq3KHbsm7nZ2FktDY4a97iPbl6Sueu+OQVOEcBhW5beArsda7mwszh6N5ZqnoE5rYPrt5WQyoY Bqs13/7ZlrpDtg2cAKSEHQwX8M8itjuPLAn03k583hJEMEY3mJ3mrAu1A34bFTf/1QTzoleUc1f DPZxfPQf3Wwx4IiyV5 X-Google-Smtp-Source: AGHT+IHy8geHvQVdEZJYbb402+U4bD4Z1Mesx4KgjWzi1r4SNNgcwDUHQRL/pHelc2R7Ugk+0s5ETw== X-Received: by 2002:a05:6402:4313:b0:645:d3fe:8c57 with SMTP id 4fb4d7f45d1cf-645d3fe8d77mr16473812a12.18.1764314273417; Thu, 27 Nov 2025 23:17:53 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-64751050a63sm3611118a12.24.2025.11.27.23.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 23:17:52 -0800 (PST) Date: Fri, 28 Nov 2025 10:17:49 +0300 From: Dan Carpenter To: Dave Penkler Cc: Greg Kroah-Hartman , Michael Rubin , Paul =?iso-8859-1?Q?Retourn=E9?= , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] gpib: Fix error code in ibonline() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This accidentally returns 1 on error, but it should return negative error codes. Fixes: 9dde4559e939 ("staging: gpib: Add GPIB common core driver") Signed-off-by: Dan Carpenter --- drivers/gpib/common/iblib.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpib/common/iblib.c b/drivers/gpib/common/iblib.c index 7cbb6a467177..b672dd6aad25 100644 --- a/drivers/gpib/common/iblib.c +++ b/drivers/gpib/common/iblib.c @@ -227,11 +227,10 @@ int ibonline(struct gpib_board *board) #ifndef CONFIG_NIOS2 board->autospoll_task =3D kthread_run(&autospoll_thread, board, "gpib%d_autospoll_kthread", board->minor); - retval =3D IS_ERR(board->autospoll_task); - if (retval) { + if (IS_ERR(board->autospoll_task)) { dev_err(board->gpib_dev, "failed to create autospoll thread\n"); board->interface->detach(board); - return retval; + return PTR_ERR(board->autospoll_task); } #endif board->online =3D 1; --=20 2.51.0