From nobody Mon Dec 1 22:06:05 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1661A313E2F for ; Thu, 27 Nov 2025 07:14:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764227650; cv=none; b=rfVoHDMHb+mBjWfrSjYXR3fSD//JmUbe+r7b23eBIA5NOImMBWfuVfVqu9LkQigNOSHw73zbNpAZr+6Gy0fBfroNBuxh8P3lXt5aGgCSUAhApiC4YSUDVVpoqxIrXAGMUNux4OxvSKqUo+tidDdhUkrehbCF28LuW31MGJ+IW50= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764227650; c=relaxed/simple; bh=LegWMLbCeHe5PZm0Ub4p2iXUO58hksEwiYKg1a+m090=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Ze/O/lFEB0X65zHwGuXYQF6m/SqoVI9VbBT7sYR29AG1xq12U0bdcClhyeL4Agk3XHhSU1BlP9pjhe9l/0NFyb4CWesmdswrtq3B1pZ3W5eVX2d56zLgwPR/IXjtwu0oXjY0J7FUeUSmvLZq7abNcHDWUOjGCZ4B8VY0+sFn7YE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nQicIoEB; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nQicIoEB" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-477a219db05so2214155e9.2 for ; Wed, 26 Nov 2025 23:14:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764227645; x=1764832445; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=2dVF2KlYm35Amf2a5Gnk993yXcXd/prgPbjpDZiGmKM=; b=nQicIoEB6FreAn/bOXDbiTdCZz1KywcxZuyYTTbHKC+UJ3wSKnVZADyYxqvK0pE8Vm aYKq2h8JLOwZwdyiJwkK4Xi+F6dPCiLzKD7RuyoNBiLGINqQXfYEDgZ+AspDr7xgVj75 IPLrOMYXtINLikflVBFBlIJFDyYhQxY3Cr2Fhbl1bO7cB4IFwUCFFYglCs5MvUGDCIIe wwVsDplbugUYE1O35l3EEwNqiG2VGo4YmkDWAzpMU0e+OCQ/afNBQSvP45n6DFJ0u0Fw 0I68oTTeNPkBemuZs6YipWXjTHoMBEeXKHsxLr/E0pHsKA9pAUuNB7PgOOzCeDdt88CH ndLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764227645; x=1764832445; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2dVF2KlYm35Amf2a5Gnk993yXcXd/prgPbjpDZiGmKM=; b=s7eMvLZCH1qXOTlcle5+7fJr2rnTDnAVsbyt/FcIFtEUY+UE2uUDdljt6rpFGPb7do BejaAtNVV20/RArrCGKB+kAcO4znMJU+PVz+dL2eH+uF3CG15LupMgpfWP+4OMZjxgoQ I4c4xxLkf9wp+7pg79+nzi3+8H44+iqtqh3bXewGdw29G04POyb3QntQcCBbx1lvTiBb wMtLFepezOb9xY0w1T83LYGl7YeHgAxrUd3/RKvIMg60EadmUQTO1rOks7n+Y2B/EMSq SJMJv0zFxpEbMoEg/zET2wxPBCByvDRozqz4fj95jDu/kapwEar0who/4whUEDXipJ7N Qnfg== X-Forwarded-Encrypted: i=1; AJvYcCUgzodaiMyFqZzH0ycx8Mh70xLepJKLfnaYbNmQeQMcHKEDdbetZTmau6nzbhk2ODsKiO1rv2p4LKNo+y4=@vger.kernel.org X-Gm-Message-State: AOJu0YxT180pY7g5MoZ6PS8lINwVc46T55Nu9VH204Zg1Jifh9usuOW1 rRDdv2Yo5s0ZxKYYGA48orIOBPYDYn5hRHDqmPhPoVGJtvoH0jNQo+oq4t3aGUKGW9s= X-Gm-Gg: ASbGncs2X5mcGdBXoiXXXYCPH26HPAUHm9wn0Ea00A+XYcOSPJCPo3NUBYjQU/+x7AE 8R5R34T2XyB2NVJW4SJA+gP6dRLnuhoYjR9myj0lJ4VzQngknYQ6wNbew9r+wKIfqjcjX0JUNXl ohY7qRGkndGrTk1Q3GQpnY6mZVZ++MZChwgVMfmMN+8sCBXdaedWviB7Lvxr8o9TDmMe8c9v8zO Mgn3EYr31zObz5a/cd+EnVSW45UAFLsAfoQvdDMwPGR8B9Jh5KGpCGuTLDbowIqIok6UTCfIiY1 5L9SIbxn0yqRZH3pGim5BWFIlvYj1pV2Gix7Ay3Qx0peRSp5G2WG1E0IRXvuCMdzLeZQu9guJge CLlu12knCgjAdpXlp6qOrk4XMiKwlNVAqqu17A3VyL1qyQsUChHYxOmB+QT1/iZD7N79VvCAvdf 9w6ttnUtAgT943DvmT X-Google-Smtp-Source: AGHT+IHh2yafLn0h6WCQ3rAqHrBsqui/zuUk1dGdvyyNWo27ENOUkyCq/IzM8raGe5NR4RM82hlgnQ== X-Received: by 2002:a05:600c:1f94:b0:471:1765:839c with SMTP id 5b1f17b1804b1-477c1117949mr172473655e9.20.1764227645302; Wed, 26 Nov 2025 23:14:05 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-479110b6da9sm17043815e9.0.2025.11.26.23.14.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 23:14:04 -0800 (PST) Date: Thu, 27 Nov 2025 10:14:01 +0300 From: Dan Carpenter To: Rob Herring Cc: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Geert Uytterhoeven , Arnaud Pouliquen , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] remoteproc: imx_dsp_rproc: Fix NULL vs IS_ERR() bug in imx_dsp_rproc_add_carveout() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The devm_ioremap_resource_wc() function never returns NULL, it returns error pointers. Update the error checking to match. Fixes: 67a7bc7f0358 ("remoteproc: Use of_reserved_mem_region_* functions fo= r "memory-region"") Signed-off-by: Dan Carpenter Reviewed-by: Iuliana Prodan --- drivers/remoteproc/imx_dsp_rproc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index be83b5f20f15..5130a35214c9 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -710,9 +710,9 @@ static int imx_dsp_rproc_add_carveout(struct imx_dsp_rp= roc *priv) return -EINVAL; =20 cpu_addr =3D devm_ioremap_resource_wc(dev, &res); - if (!cpu_addr) { + if (IS_ERR(cpu_addr)) { dev_err(dev, "failed to map memory %pR\n", &res); - return -ENOMEM; + return PTR_ERR(cpu_addr); } =20 /* Register memory region */ --=20 2.51.0