From nobody Mon Dec 1 22:34:47 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 078B2307494 for ; Wed, 26 Nov 2025 14:52:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168755; cv=none; b=jLHWNkVn7mgX1+dlYL5CVPGxf4dvZQ22+74HJsMc/M7Q2rJPywNj8sQbWHi1iXz6jqAyWoow8LRghNSSlY87Jga3ORW9KwNT5No03WLzGpQIVr76RTTY6H/4CjTJkbRkzz0eYv9l+nU5wwkKABsGF18LNEfTgZ8paf+eAJMMJDg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168755; c=relaxed/simple; bh=3M73N2AariqTlY8yn8Twg3H8JvBd0HiNvIu4NGbZDbs=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=srfFC2xY/hOzL4mBjBYcq1cx25OUUwV8/TTU8r6mS03B347jyxJfUEK21TBOcAkqNxaX6QHFl2QKLOELpys00Df2Y3O1QOfYChb1Uq4AY3ETaDj5FMbmAPvy4ow3qdNxHKD6TkflbiAR3KlHZeIymM8JD+3yhYUC87GUpPNBGCo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rXeB33O7; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rXeB33O7" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4779aa4f928so56023885e9.1 for ; Wed, 26 Nov 2025 06:52:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764168751; x=1764773551; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=tB73pe6/NtX8eM3PTQbggN9wppvlKOL9jZo7eXvreFA=; b=rXeB33O7p8a1snjBMv/8ycfYNykMWnUIaTrZfcG6uSoz7uELyoIRjaZkRrmfjna65L L5ZoqVCO2ZWhAfprji5Dwr7k1E1igZR1rT8eTIH2yQ+61jwu5XSx0hVSE7LM3WLjX6wd ODTGQDS3rJYRCZchoQSZb4NQFyHJ1T6l0+T3DkJIKOO0D+p/7P2kmaSIDJCNmbM7ejXO iG5QiP+jGmWXBNY9g+Xmqe9tzkmAY3df50HRMdHFiu6mZ7QvSHz99USFL4zZUvcmEt+5 +SHcvUwDYY6EzSutb/2WCciXcTf3wk6Xd3FOimopKyw9pTSmoJRCGkXViR8QHIR0UpwI br5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764168751; x=1764773551; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tB73pe6/NtX8eM3PTQbggN9wppvlKOL9jZo7eXvreFA=; b=Vy5vmHtmxXRZKDHZOpWcYGZea5/SltlA0m1w9fPrTgswPESGfrcUGwl+jKBxsZNkKQ GysuzBhYar/dmb4XhpGPF7CiIAi9PgxVdstBXFXFsX3I8g66OfvhYgRxfnx+7xTqVI36 v335dwoiBq7xBkhmzxFyF3UVxxDtZOrt9Yy6j+/lBgYsyUV6RiSo6xUFD50qDFUrNn4e g2t9U8E5sHh8TuNoECF2awkH0Hfwt94559QkAQ05DQm9laDt1CJj4Dbng0yTHWooD2lH JJYr+++UeW2BIDv0waDr4CaORD4xVKt8iCPRYNnJ0m1kQ7d1a+9VrFx52jqCWSEPWd0G 2xlQ== X-Forwarded-Encrypted: i=1; AJvYcCXEQjvHS08nJUme8jDAWUw6whPjG03SNH2/ynAgSHcb6aNacECcb7PrHkeBG/YdtXr7jAlwBmNiV4BLOeE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxsy9M33Y1OBNkP/zF4WuHC0qvy0P9/R9Cos528XG6NVmk/hRyr ikRKZ9ECmEwBmF/zWv5nqwG5Lf9eiZRmk7SMMzya5HF0r6Lej3nbP5YWqDL4jf6LK7Y= X-Gm-Gg: ASbGncvsWF9LF14gqKNaykUiyKHo/QS9w+CayN3aZ5PpVteIn7COs26J9sVwHPLmzo0 9vNGvZ6OlaOQqVZr8PvAILXT+ddfELl4+GvuO0vkNfShogDYHT4ZLmYuPgR1GQEuNDv5c4HQau9 mLuXvE1ZXdTTs7o5/WaYGXFDwChSudEnn9ZbuESNxhrKzInDIfR0RMiFrP8QTeZBFIMWXv+Vjw0 UVT+MecuOcHfefhSotPrKjmaeG0oulNLVFqYl8bU+vXpBkWH5KHLEqQxo9wiWtyBDnrjQxSHAKF 6nPA/FuemHHU2JLmqxx/y2qvQqasLRLAWCAO1vx2z/d5zE2rRJ+6wtosiXvoZtFRAKDWV5J/pWA BjU87X2/LGseLrlWCF0EB7RSnDo9Tq6STr4nIxkcxB+YViCq354eCe1epWS9YUgMgzzOS7yvRB0 H8505Zv7hSSFxsIsA= X-Google-Smtp-Source: AGHT+IGCLmd8tRJyaKxnoPAOY3teB1a8/mQwQE4e51HEL7L4ZyHqrgXF4lwoEPkRwuQbHk3YrwrBYw== X-Received: by 2002:a05:600c:8b37:b0:477:9cc3:7971 with SMTP id 5b1f17b1804b1-47904b1ac02mr55156645e9.20.1764168751196; Wed, 26 Nov 2025 06:52:31 -0800 (PST) Received: from localhost ([41.210.159.101]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42cb7f2e454sm40974088f8f.2.2025.11.26.06.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 06:52:30 -0800 (PST) Date: Wed, 26 Nov 2025 17:52:26 +0300 From: Dan Carpenter To: Cyril Chao Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , AngeloGioacchino Del Regno , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: [PATCH] ASoC: mediatek: mt8189: remove unnecessary NULL check Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Smatch complains that the call to snd_soc_component_get_drvdata(component) will dereference "component" so this NULL check is too late. The probe() function will never be called with a NULL component pointer so just delete the check. Signed-off-by: Dan Carpenter --- sound/soc/mediatek/mt8189/mt8189-afe-pcm.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c b/sound/soc/mediate= k/mt8189/mt8189-afe-pcm.c index dcee8e11eca8..166ece74270e 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c @@ -2352,12 +2352,10 @@ static int mt8189_afe_component_probe(struct snd_so= c_component *component) { struct mtk_base_afe *afe =3D snd_soc_component_get_drvdata(component); =20 - if (component) { - /* enable clock for regcache get default value from hw */ - pm_runtime_get_sync(afe->dev); - mtk_afe_add_sub_dai_control(component); - pm_runtime_put_sync(afe->dev); - } + /* enable clock for regcache get default value from hw */ + pm_runtime_get_sync(afe->dev); + mtk_afe_add_sub_dai_control(component); + pm_runtime_put_sync(afe->dev); =20 return 0; } --=20 2.51.0