From nobody Mon Dec 1 22:41:30 2025 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBDB9EED8 for ; Wed, 26 Nov 2025 12:11:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764159120; cv=none; b=gC3yfUBNUgQosbN6O3THQ2rxxazgJ7iDonxPNOESlhcoaBm82ScyBckYPnPGS31iqG56kbf2ez/KsSRt+L7e5puCoKpddNFmKAcgx6/rmhj1EyqpFdmzErUE6E00OmbUGQlayUi9BjSk7S47jN3CW2RmUBjXHDlX/V277ABGm4g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764159120; c=relaxed/simple; bh=uvWHl978Y+rYvpiWI+Kt+Voue06IzDwvCCOmf1Gm9yc=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=LG6YvSUbawC46C9XGa+INdmCgcHlNuVw/I6Qp4jX2K8MWempXo6srIOOONttpImvccBc5gblhDj6mYgSR8g07in90a1HyC8wKP3JCYihVXlu6CVFA9puXveqiwUTFniOLKrX4dZW+x2BWxLlRwiy4SvaLJC3P7CV37mdPH0l224= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lp9sLamd; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lp9sLamd" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-42b38de7940so3336525f8f.3 for ; Wed, 26 Nov 2025 04:11:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764159117; x=1764763917; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=Cd+1Cagg6P/hQKqKcPtdTLVPLBxLVs3swxXaE6oveBE=; b=lp9sLamdXiEwhf+aI72YWz39Y4tRhuWK/ybMsP5RHAKFVPs64CIe9PfHH8SLkqOqSy mDw2iUOneKjxDJUXwEC6P6ArSgeV2D3a/kqCAgy0y02oEYOSM0kgCfha5VE8bGJ3+MH0 PPqHVfJprVtPGgwLYx5+7My0yTjxA8X7SFC9LcjDjsj47/214vUQXw7PlBNkxsG84/6Z Wba2MfL+XiX8v/nXAqfs8FwRSuxol5LigIvKqfmkO2XWn45S12F9tkt81jmS2/OW7qAt T39vq+00RckwmG44xNEThc0GlQOMk8c+AVzL4JKF8rHunK7kptROaXkvkfjBgBaPf6/y 8YEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764159117; x=1764763917; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Cd+1Cagg6P/hQKqKcPtdTLVPLBxLVs3swxXaE6oveBE=; b=j1dn1uIqBIb5YFLm/NYZu4Ag6BAM/BwZth6I+uun8SYLrpjNvTJa35ousBSgjA5TNb mrRvTimpGa0h4V+joxOBEjtFojzKlqECCq0DlTKc71bZwK58WIPeqGQH/AInUW5ERuFw NmrqqroyLqqXsyP7/c3Xui+TsMslPdanZCvR73C62cWarh0gkwOYd4mI0VLsspsr9HA7 pLQZ7Zk7JvnMMnJYjJkziUZfGXmGu4TPjQdwLe0x+iExyJIrWhSIyiImM6I2UZWE3lpT qRnkhZIZX4pc1ZUnvjUMg9kn+b2M9C3vt+nif5bWVlAZY1mQNWVThH0bfDgdDjbc8ila n0vQ== X-Forwarded-Encrypted: i=1; AJvYcCXQAbuSBO0xTHYcz/U5HD1/PZBke8XuQmBC/puLIfwN9k1m5W5MOE8qDs4d7X493Ef7YSs2HprX4UJSmE8=@vger.kernel.org X-Gm-Message-State: AOJu0YwExkc1K76a5ujx7s+NjN7HrIWM9ErVirdLDkxnpNRvnXnpzmb9 v1nOdjw22UC9j6+eTrYvjvcdjcvi0zVOFaC429X9OOL14WrNdNbhk6c1VzN6aA34sMo= X-Gm-Gg: ASbGncthzmYy4tcQ7bDAsa2F6IfaVDjCkKBny2VGyRnI475rtTG93P8WXlqIJ1hUUWW 5FKGW6a0LfCM5VSXB+0p8cwUT4tt1DbZJwgNZs4CY5HkbSpPaJbHnUBbgUVCO1H+lfnT/8S+ofQ lME/kH+M47cSepY/4YsUl5b3PUxT8gU8H+dcsmAAGPLcR0Rc4ifOuIPqZ3fvS3vrtqgvlMiCs6W UB0cQqBaOh+tKzMfdXsVJQ1+4n+4TIexjTYcSrZQIc+A9zzi5aUqcbfd75r6HImQoxxvnrxlsjd BOLXCKedj0EFjNoRw4ZvUmKMCjdJBUiN7yOdava0yT30WcZpSKFFmILIzmANL/fms/uTITlYTuZ 0Hm0g/Km0FFb4c8cNJF9D4TL+wTmtNfnXN6XsDwBQUshnFf9kHr8x87nYh0x1KA7F0DeN1kiCdv QJIr0C89YjiwRvUMoF X-Google-Smtp-Source: AGHT+IFWu9W4TOiqyvkdf1aDEOHe4E+V/s2R/oq+X48vwv7Tx6mXyt3EVJ8/GOWx1Thn6yZchN5usA== X-Received: by 2002:a05:6000:1846:b0:42b:3b45:7197 with SMTP id ffacd0b85a97d-42cc1d0c89dmr17865163f8f.42.1764159117033; Wed, 26 Nov 2025 04:11:57 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42cb7f363c0sm41102732f8f.18.2025.11.26.04.11.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 04:11:56 -0800 (PST) Date: Wed, 26 Nov 2025 15:11:53 +0300 From: Dan Carpenter To: Mike Rapoport Cc: Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next v2] nvdimm: Prevent integer overflow in ramdax_get_config_data() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The "cmd->in_offset" variable comes from the user via the __nd_ioctl() function. The problem is that the "cmd->in_offset + cmd->in_length" addition could have an integer wrapping issue if cmd->in_offset is close to UINT_MAX . Both "cmd->in_offset" and "cmd->in_length" are u32 variables. Fixes: 43bc0aa19a21 ("nvdimm: allow exposing RAM carveouts as NVDIMM DIMM d= evices") Signed-off-by: Dan Carpenter Acked-by: Mike Rapoport (Microsoft) --- v2: Ira Weiny pointed out that ramdax_set_config_data() needs to be fixed as well. drivers/nvdimm/ramdax.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvdimm/ramdax.c b/drivers/nvdimm/ramdax.c index 63cf05791829..954cb7919807 100644 --- a/drivers/nvdimm/ramdax.c +++ b/drivers/nvdimm/ramdax.c @@ -143,7 +143,7 @@ static int ramdax_get_config_data(struct nvdimm *nvdimm= , int buf_len, return -EINVAL; if (struct_size(cmd, out_buf, cmd->in_length) > buf_len) return -EINVAL; - if (cmd->in_offset + cmd->in_length > LABEL_AREA_SIZE) + if (size_add(cmd->in_offset, cmd->in_length) > LABEL_AREA_SIZE) return -EINVAL; =20 memcpy(cmd->out_buf, dimm->label_area + cmd->in_offset, cmd->in_length); @@ -160,7 +160,7 @@ static int ramdax_set_config_data(struct nvdimm *nvdimm= , int buf_len, return -EINVAL; if (struct_size(cmd, in_buf, cmd->in_length) > buf_len) return -EINVAL; - if (cmd->in_offset + cmd->in_length > LABEL_AREA_SIZE) + if (size_add(cmd->in_offset, cmd->in_length) > LABEL_AREA_SIZE) return -EINVAL; =20 memcpy(dimm->label_area + cmd->in_offset, cmd->in_buf, cmd->in_length); --=20 2.51.0