From nobody Tue Dec 16 13:22:50 2025 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB44D258CE2 for ; Tue, 25 Nov 2025 13:55:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764078935; cv=none; b=e/nCj/NonaunBAPHh1l1BPPeVmWao+o6OWAT2CTraNfGiUQkNTpW50cHyyrSFvi59P8x4TumSW8REqkwLAEsyYwD6qNN19mqazQ2Itu3WjXWazc0z+y+PdbwZCzL92AaJ993OFrdgU89jaGHBD3B0C0t0lhkxepvdRYOL8Hs3xA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764078935; c=relaxed/simple; bh=ZpJV2g4pswmR5fsLqMMJdtUaMVZFpU0lNRhxLnBhCuw=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=TSJGTFvv6YNDpLDkXPzdgIbysskbSaoUkd/lQmxn+ThnojLu/LCdlaQhS+FyG3LNBhJ8FvpqqNmGK49SZSZGsDAKvFvd/6khLodto8Wu2Vy5BnGtovPoa1L8k1g7i0hNw/T8UjLD8tQlWCniu/Esu9MUltNfvNrpwudM5byAdLE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ueksEoO1; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ueksEoO1" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-42b566859ecso4891039f8f.2 for ; Tue, 25 Nov 2025 05:55:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764078932; x=1764683732; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=Qj5l2CM22fDA1fw+7YXGuZnpUGxoc2eRov5FmLwIscE=; b=ueksEoO19hUTXGB4rL8xhRm6EbWa4xy0G7duVxt2CWVHeTc6Cu2ZFdQ1umK3fAcnCY v0CaKBjLoH2wTJXlSzieVmKG3XGXPVEqEQWj8R5mTlL24hikbcPhkxrl+Ozd7pICvP9B 439wv0g3vfM5xMnm/xVhMTNyamayipgrRQnH/cTgpndUHBsHRfY1NDpwxH9gdQnDpcen r9NODBDkqDMsZbAoU/eib0ymbgJRSaoOvOaowoW+mNQ+h9ap1NOQ5AbqF/VIJQqthxw3 mynMdmRHLRXYii+pFn6ifQmce+5nt48Q8fFt/jsmivMKv1N1t7ixzdZ09muVpQbsQIxn cfcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764078932; x=1764683732; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qj5l2CM22fDA1fw+7YXGuZnpUGxoc2eRov5FmLwIscE=; b=Nv48Lhx8d26oWv/Fk0ejpTgx7COUBpjazsWuOe4TavyUtAEMiGYBCY4VqW6S1GJ3w4 mwAHW26ZKKIHTyyvlI2VEh5jQSW6Dc1cYZaLorV/PFgjvkAKy1v1ehg/eR3vMOERgptr 2RR0u7CQBvZIFZpQEEl5KkY7Fyxp16s9Ut5VYuq8Z0cH7Ly9eJ5CP7zpowFSfxjToz4+ Hgv1jS8JFAlluuLhgARaeXx/me4LNoi96cUKeiE39cGfSZT34Rryzm8IK7MJNFNuQu2P dhEHA8Jvksizn6SFKEd32s87vXjYL/yiIrg4j9OOoiijK4+HIsALMsrkJEXQDuGpja90 i69w== X-Forwarded-Encrypted: i=1; AJvYcCWnKG0dcAHUvoLaQ7XaEM3ayVSXmiSkwkapzgp2A1N/mp+obRQ1HACRvvoMlqG1hxFxHod3DSrEmE3Fw9E=@vger.kernel.org X-Gm-Message-State: AOJu0YzvpzflTJf2JeBbQwm6IQ5uA5kMCoWPDrxFz59zvDQvmJXjMgTl oxSt8B1WFyDM9KGWxtpyBlWUHv3mzKXDBTpHljFSg5O994UqI5FigyGshSX97TZX2sL+yRtlGR2 LFQeX X-Gm-Gg: ASbGnctuxvVH0r1ytT0qBki5MYOiT2zeFDorOr4zW0CoJXhp8dth/yMLxWtA3DOH5s/ R9z5hrwkqDOl937Y9zQha6TilYiInak+mT9nwbu0bic0wu26g1CZUG8sNcaRMRRWMCCBg462vXb EBj6e26kSup2tVdOlEh+CsF1y3H2P3gRzHLVQH8wxPZMamy9XPGUhaafdxPRIc7BgvtM3uT38Jz ATXCBbrk3Abu1IR95CoPWNIx1jSdUDlOf9l8P52fHvQC1eyNr84lDDfFny8SdYGofDynsppwhVj uKeU5U5pjsxJat18GYL+GUG6S7zOc17GuSa3eteSVLsUkaT/Ae/P3XudxlAQAaSLqwLivt6Zbv/ kYyLXH/bArVQn/7G/bgjbX1MVIPaQMq7j//nla3b5oZZE9i6wPw1uzymxWTvnjYkIQN8uIKSbMa 43SVPUIq1ntaHMB+aE X-Google-Smtp-Source: AGHT+IEoviEwOKyAo/e7XcJ+LgAsfut7GBUDSalEwMV+33vddcxo7V7q+O0kWwVd3H/WFPuLBKzd1Q== X-Received: by 2002:a05:6000:1789:b0:428:52c7:feae with SMTP id ffacd0b85a97d-42e0f3492bdmr2780337f8f.32.1764078932198; Tue, 25 Nov 2025 05:55:32 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42cb7fd9b45sm34841588f8f.43.2025.11.25.05.55.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 05:55:31 -0800 (PST) Date: Tue, 25 Nov 2025 16:55:28 +0300 From: Dan Carpenter To: Pierre-Louis Bossart Cc: Charles Keepax , Maciej Strozek , Bard Liao , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Peter Ujfalusi , Vinod Koul , linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] ASoC: SDCA: Fix NULL vs IS_ERR() bug in sdca_dev_register_functions() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The sdca_dev_register() function never returns NULL, it returns error pointers on error. Fix the error checking to match. Fixes: 4496d1c65bad ("ASoC: SDCA: add function devices") Signed-off-by: Dan Carpenter Reviewed-by: Charles Keepax --- sound/soc/sdca/sdca_function_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/sdca/sdca_function_device.c b/sound/soc/sdca/sdca_fu= nction_device.c index 91c49d7389db..c6cc880a150e 100644 --- a/sound/soc/sdca/sdca_function_device.c +++ b/sound/soc/sdca/sdca_function_device.c @@ -96,8 +96,8 @@ int sdca_dev_register_functions(struct sdw_slave *slave) =20 func_dev =3D sdca_dev_register(&slave->dev, &sdca_data->function[i]); - if (!func_dev) - return -ENODEV; + if (IS_ERR(func_dev)) + return PTR_ERR(func_dev); =20 sdca_data->function[i].func_dev =3D func_dev; } --=20 2.51.0