From nobody Tue Dec 2 00:02:24 2025 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 544372459EA for ; Tue, 25 Nov 2025 13:55:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764078927; cv=none; b=MHkWUidTiv7d1zgJbcn13z1SvExSlkPIsqv9Lr9IHnRtcKmuLuLeeTREjzfgdfW3jv7T919TB2/qXUkBxFos+HEmbq08QNh0CoWs1+KdKElY9GcL2zwWuhxY7R4DGYJBuQrKGHDQbKShJdCPcztBWzOjN5EOIgpo28KXSZduA54= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764078927; c=relaxed/simple; bh=ojcJW/WkscbkfFpX31lO1PLLIJu+wCGNE6fCS14Bl30=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=DTCtkTmHbcbgyA8blydQJcUMNx0FgoGTjCMgNMzZCnqEvOQDuieSv/YyiHDTRo0ufgshaonmg8jy8lXmOmW9RwQb42r1WvPYkfMwvP5LpKwMisKJUCr6MtqVo8AozlZ3ab2sTTmtHT17XTxqzAskPEfd9Jdcf3OEI7dK0cLaomk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kVebjkyX; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kVebjkyX" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47775fb6c56so46491865e9.1 for ; Tue, 25 Nov 2025 05:55:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764078923; x=1764683723; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=OZUPcDyU6xr3mdB7gZ6zkmVa9aLNEQrMFyb5L16xk/E=; b=kVebjkyX4X3ANANzh8BG44q33exDDMtE5VqdkXX8sW/iERvT+e5nV8oJV0iulaiViV IzcEIOQM13d5F/YP8/gy4wFaK/KEp56aAhOcIsBX47HgDvwK9przbRcvr849J8qpOocq 4Kfn6XI8Sb1aBaAZzbjhSO/tljveTP5i9d20scez80eG8jsILsaHZ7vNpvDdoN7kzjcC M1KJDtFDlPcKr8o9Thmp6t+4pO9BFvJ8jOfRO4x9y4yiUdJ2gY2psxvcb2q36iKs4bvE H4n2WUbQ3ODtChdBfn74zVWo9hQL7UTcW3HUBkDI6CRvXv6mTUCOKX9XeyDXY0EYE2CB zo0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764078923; x=1764683723; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OZUPcDyU6xr3mdB7gZ6zkmVa9aLNEQrMFyb5L16xk/E=; b=sYCD25DVSOTNm/fjdkF/m8vcn2QyvkPn5wL+QROIaNeZglvMhwf3yIvwAM3305StHC z1A1Iy/6mvNtBZCEjd/UwolZQGXUJGll2ArSqGb6aELsNTtGEI09NMqXM1beA/FMANFg fFMLwZ12KEaPDK+1/o3kw6dJnQ2DOkIcXVAH3S6pMZOkHoCcKAQ0J/UqfyQJyO4rS5iN SGOMI0VcesK+fn0ju3ZJk2X+PJ3bPb7w+b/UjIrCMBsCmi2ad0cIcWTr8xbGBPunlABE p3mbcXJ4CjKQrTmUidJ9dvWKaBsf5/4p6XrahyC9ia362hEFmNXK1b6eM2qTeGsjIYiY /DNQ== X-Forwarded-Encrypted: i=1; AJvYcCWU8Tv9eVg+nz4bVzXsxP4OpLDW0L5soS3phmCN0EhRAfG6GiWSQE7mKHoFYM5GXjbPNcQRMeBMK/jGlYc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6hNI/i+ac8sg2yCaEKq4A+7vDN5THEthkqiXpEaSuXjumpUXR YVwGZDl+CsqELMP3Nkx1CxKCtp7cCZwpzWV46opIqY8QdXdfBI0F+mRPaqJ4hLHNhYw= X-Gm-Gg: ASbGnctipb7voHy66KiMJgiEeR+/ARG6JGo8QydorxdxpRRTufti3qHFqIZSuRWbxeD 2vGuCm7Silv0ySra5l2xT10jyoYz6fx1v92RuKzr+qnuCrWKorzJfzujGRqYInRKB/p5sWSvWJi IfTPeMq5im3xW32CoMhHkjULAyJ/VGEbk0mQVlirU7mJG082XGQaC4mVNAz0l3GkBfpI56Y5cNC fNJVzW+nLpRh3uCL0TWrTLzFoXMk8RrmHdcYwf+pYAkplMWeailr7K6s4RzLjKC39vmcAS43lKp +X6++c0tPR8XpO00LAvBd5TltfqoNLSi06gcvsFUtkbHoLyAq8lENPfGuByFlI/DpqN8FIzYnCh QEJQFDAmT1V0O8yFV7XWDsKOVJ1JldVTYRqrk893hdzVnS5wbTD5rnEgskQWQwNdBjWOhyb7n3d ZjPgdHLL6Z2YyFsvxv X-Google-Smtp-Source: AGHT+IGOdvw3USM3p9Dabw1EjvJTknTEGkReBA7/KiqIqk8VtB6dVoTn1QMFTGxLgVyawmDqGUyuzg== X-Received: by 2002:a05:600c:3107:b0:477:7b9a:bb07 with SMTP id 5b1f17b1804b1-47904b2bc7emr28643045e9.35.1764078923506; Tue, 25 Nov 2025 05:55:23 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-479052c9621sm17162665e9.5.2025.11.25.05.55.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 05:55:23 -0800 (PST) Date: Tue, 25 Nov 2025 16:55:19 +0300 From: Dan Carpenter To: Malaya Kumar Rout Cc: John Stultz , Thomas Gleixner , Stephen Boyd , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] timekeeping: Fix error code in tk_aux_sysfs_init() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If kobject_create_and_add() fails on the first iteration, then the error code is set to -ENOMEM and that's good. But if it fails on the later iterations then "ret" is zero, which means success, but it should be -ENOMEM. Set the error code to -ENOMEM correctly. Fixes: 7b5ab04f035f ("timekeeping: Fix resource leak in tk_aux_sysfs_init()= error paths") Signed-off-by: Dan Carpenter Reviewed-by: Malaya Kumar Rout --- kernel/time/timekeeping.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index 0c8b77ee4a3a..3ec3daa4acab 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -3087,8 +3087,10 @@ static int __init tk_aux_sysfs_init(void) char id[2] =3D { [0] =3D '0' + i, }; struct kobject *clk =3D kobject_create_and_add(id, auxo); =20 - if (!clk) + if (!clk) { + ret =3D -ENOMEM; goto err_clean; + } =20 ret =3D sysfs_create_group(clk, &aux_clock_enable_attr_group); if (ret) --=20 2.51.0