From nobody Tue Dec 2 00:02:26 2025 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0263523D7DA for ; Tue, 25 Nov 2025 13:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764078851; cv=none; b=eviqOvsinHHRIjO+g0KV6W5+NQNzRXWLfGcUoRgC712nMFaI+5bX7SgQxZ9c1I1uIFgH913HHYApnnBnjG/5Cmve2qMYnDiRbV/ZfZDCeS9pPqmo58XAQaDGyMhDb8wMmKUraS1B9pc6aZRrkJPoMKYsXi/+fv7+gnhtjKBerrs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764078851; c=relaxed/simple; bh=l6KJEbEVM5y7rexEcKSpqScYa9AjmZUzszGRaxbfMbw=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=G5n/uXenVvTTG1ORtC1SxC5znFeR00KJIlClyuDEDtDDroTl1bMjJRj5T6ClIBn0cb5b15y1qDpkXK6XZnsgiprHdjjWvh/IPDporYBb3wogsHsPo7kO/inM7sEAGaDRt2XIEEqCnt+db5Df7A7auQOR6yUEEarDELvq9kvpTfI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HqJu0BFW; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HqJu0BFW" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47118259fd8so48681495e9.3 for ; Tue, 25 Nov 2025 05:54:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764078847; x=1764683647; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=PfZmCnQkSgXm6bGG1U92mqMyyCoId2oi/fIXBdd/gDE=; b=HqJu0BFWe9MX0qrV+e/NVyrsEUydEMR85WYJ4asEA8FTDuB/EBQD5OECI9VG1MERT2 km7KIBGNQ8T7smH2Brj7tfpScbljbanTXgoR+BZlnUqBjgkybHAClgPvkHz0GcuIOLcn M8OYDvUOkQR3urYeh1DLVmqusMWbsDM32cOeSBN9L/mU3YNyzD70IzT570SFnuO/Sni6 MX2w1ckDcrb9k/mQDQdzXOtZkgc4mwEF6+VvcxiEih2OLb0oTmlgyKRYKJO4p3/r9G+J 9PF/V/+tRhGbLl3m0RQVazcKk9Undz4yw9a8RFYtre2VuJoMUvem5pgtbKMMNe4Bpq5z yv/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764078847; x=1764683647; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PfZmCnQkSgXm6bGG1U92mqMyyCoId2oi/fIXBdd/gDE=; b=wQwYuqr8jhNoXkpXivwn0+YzG1OhU8NrmRLhOsU7dtyVoyOjRiQtisDFImp4+AtBy0 DYcg/YyKERtZ8DtJR0DquH9RFjiB/NbA35WCE50xydqXz7ZB8wdlNvj5dM4UblvvxVTU 56Y4kJ2J1jTGR2a3WskhhJNbyleEKOl0JZH8NI2fcGhs+c1M75vkdkgT9mAfu9dbN/co C8sZsrsKca5kmQ1UpCwyv9nhNNSgYlAEoAQNX3qhAKuY4K8QJgOzKa2NlZevPFqB6/uG eSszgD9lkqADLcNfiWXyc1ydSu0u/Gaaj+pBA/3QM+5y1xEdYdHyC1i5tbQfThFtw7O7 3QkQ== X-Forwarded-Encrypted: i=1; AJvYcCVOXbHBV7Fb0HIRBr8pDpB48PQhJbHjBNWtlLIdkpy70/x9RjlhWwP8kFDvRELWU6wrpsmEyg+JdU4kPvQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzXcF/XtVEikPEFqjxLMPJd20Nkds7YC2GhJPBL5zssFSxDz+74 GCAowJU0XTKtk70Cjcdw4D/qVJiG6njz0RkilNkh+TdzlsVERRyfW0yPcT+U4wZWo3w= X-Gm-Gg: ASbGncvMa/uCZ6x9QHBuGMXyJ5hfQ/3dpAQEMk32Kf4A0AJ+jaYN+JXai1CIIWvkaaK M1W/IS1BdXMSf3sKbCGlKb+bBcNOARjTNAtjrL7wzYn//Tcqhd1pKF/kyi2EOQKr/Gha3KIU0tQ WcAYTZWCiOhMK6L/FypEHbjKB2l7BEn7eB03f+hMknI9HpvY0lVXYjik9yHfRa2JrFBTe60BwoD sNtqrtZuDEB+d3rLgZ1MVuVYG2HIfR7HfsgJNpOYiGmhKHOuLCga3Nhxi0ql/RNeGlQkjJ01oys ssrtWC6nKasNuFY10YO3SfO8e50XXL8NvdKx5e3QbYbiobng+n32HQtHUXGtvs6fHKpFLJo2uBV JdpyhUP37iMzSGD/0tY0XkZoh8gELu9+3eJ0pp5pKBvLNjKQRazTz1MM+Rq9RACENr1X6QneXGO JITwqgJkbMPEWlusRw X-Google-Smtp-Source: AGHT+IE6Z/i4LBBFZymostPyZofb9RWGBQcEhAavUgAtLmc+CAwBQkdpZHZEouVOs2i7Ai+1mMZV8A== X-Received: by 2002:a05:600c:3b9c:b0:477:af07:dd22 with SMTP id 5b1f17b1804b1-47904b24243mr26387045e9.28.1764078847095; Tue, 25 Nov 2025 05:54:07 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-477bf22dfc1sm250227535e9.12.2025.11.25.05.54.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 05:54:06 -0800 (PST) Date: Tue, 25 Nov 2025 16:54:03 +0300 From: Dan Carpenter To: Mike Rapoport Cc: Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] nvdimm: Prevent integer overflow in ramdax_get_config_data() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The "cmd->in_offset" variable comes from the user via the __nd_ioctl() function. The problem is that the "cmd->in_offset + cmd->in_length" addition could have an integer wrapping issue if cmd->in_offset is close to UINT_MAX . The "cmd->in_length" variable has been capped, but the "cmd->in_offset" variable has not. Both of these variables are type u32. Fixes: 43bc0aa19a21 ("nvdimm: allow exposing RAM carveouts as NVDIMM DIMM d= evices") Signed-off-by: Dan Carpenter --- drivers/nvdimm/ramdax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvdimm/ramdax.c b/drivers/nvdimm/ramdax.c index 63cf05791829..faa6f3101972 100644 --- a/drivers/nvdimm/ramdax.c +++ b/drivers/nvdimm/ramdax.c @@ -143,7 +143,7 @@ static int ramdax_get_config_data(struct nvdimm *nvdimm= , int buf_len, return -EINVAL; if (struct_size(cmd, out_buf, cmd->in_length) > buf_len) return -EINVAL; - if (cmd->in_offset + cmd->in_length > LABEL_AREA_SIZE) + if (size_add(cmd->in_offset, cmd->in_length) > LABEL_AREA_SIZE) return -EINVAL; =20 memcpy(cmd->out_buf, dimm->label_area + cmd->in_offset, cmd->in_length); --=20 2.51.0