From nobody Tue Dec 2 00:46:22 2025 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AF1E2E8E06 for ; Mon, 24 Nov 2025 07:56:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763970970; cv=none; b=sML9Xu4J3MbsN05rszuGpBxfP+vadXses+o0Eoe2k5llAQ2XjWtzkjEBOndc9gP0SaNaOgvljPgR8T0MLdbCKqwE5slF0ZGeUrvw2XL3KpgN1Yl4lEOx6poW/6BwbLfoh24RPMwmFZVEErBXMp5UyyRb3ZSVaRpyTuarLDiMjT4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763970970; c=relaxed/simple; bh=BAKV6mRJkamAvDuhdXunfVVuTbGwv1bU3qmP8zeCm1E=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=ZsY2se3Px0fVShguPn6y0ms/6QdJSbHLeeWrZ1Z53hV8w5mhdeTx3tFZ1FqI6DOHGIeRePIPKkLlSaMa9CasbGRGBV57X+O2fut/IGbeAtgIB3SVxiRamqIMqdCYSgdpL8BSytK/XGviXpOwEJvvcqaGeL9sTs+TH7NlHt3XWug= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wR7nhKof; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wR7nhKof" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-47790b080e4so20512075e9.3 for ; Sun, 23 Nov 2025 23:56:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763970966; x=1764575766; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=jevOMx3oLEe1om5TMl1VbYUf8BPerVwJX0XKtmooeDg=; b=wR7nhKofia0h77DUmvKWBTI+xq/DPk1OKIyVcWAfZ4Aeil0ORm91MdT5w7XWAFUZeR S8Ha7Vv/TLGpz3iL62AcGxIAvcUnxYLNwIJdWUPwgNls2HqhyNCcRxZYkASQUi1u2PQj QeQpPGxoal7Hy+BozvdfYwj9fNlhySqiSWFIng4vgsIPtzanwVSPrUkAgLfd1uJH6j05 WLyBTm+DcLJb2VhxaN085cUh3ITH3SJflRE+HUh1b0D35v1BIwY8MAwI7gJ5BUylg8jN HZPbtxh2BmQTsANg7YGH6WgKwyhK7xBhlLJgGsrGpnul0u7qQXAmeWM8yAAntuB+hAoR cjoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763970966; x=1764575766; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jevOMx3oLEe1om5TMl1VbYUf8BPerVwJX0XKtmooeDg=; b=j1H0dZYB5aJHYkkWxzy/P8PtSqks90Ys8plxm+hFubv6SnBJ9KjgcJntKDxOCZKVvi +vBpDG6wHmoJq85zIb6uCaQ5whnKOwqmq3RztW8wTKJimL1Zg2UDNp0Ox+iM6hEL87l8 xDAv1W8XnWnK+hkUE7D4+L7EbzS/qJQHXxQGIvD+f7woYc2QdSP/FmJoVoNhnMR4dpzb Edlw7A1W2MPIP9C6v6Z92RVFHm1XNvx1SB00MPg5TnqLBr9zy2juCphIVawYzUg8Ee1Q cq0R9KzOY5dQ73otPh0SL3WKbbQH/NO3PhjLShBuj8gHzP+WpYwnO94n48quC8UyMt6m CNSg== X-Forwarded-Encrypted: i=1; AJvYcCUEjei614G0TeAeKbN22HqZHn53aruHgxb3VHRr2pDJL6hPrdkWYhfdOWFfmQFOqhq9aXfNMQHPBsx1PnE=@vger.kernel.org X-Gm-Message-State: AOJu0YxUKG2PRCNH2Y9xgy7w6JsgLCYzRLNqXG3Aye502Y3v+QRjsmvO 5pf8wBAdzdvyht1NVesrVbFBnz74c7siM4CvHQfHSYyvuES+iyLDaiei/dRogN7wmCE= X-Gm-Gg: ASbGncvfycEwF+lDdakjBpjJjsnhxG/Ahu3T83UPeKgeghCYuetbLWxe0C/F2WxwZDd H64u0d6hfxvvRFhh6ngwL5Wl6sugMbhxlZY9N6PNN2Fk14Ijnf1mXYX1GtZHuFPuU3b1sZBvgkO WjJo885nZkENotXVTc7Fj/jsBTa/CYaeL52SmZ4HlKncv/Czcgic6pjXK6Ib3olQ7AZY009WBO5 Fs5DmrmOjJhA45+t+rNV1lJVMcLZMlfSYYK86cVHxLBTW8k624fVIBzqNuf7ff5t5SKlPj9t0rf yiZYWxpYHebRgFVpGN0dPILeyZhg4eNaAgTLOrbaQ5mRsXefXmg9SKXE8hxr4GGzaMhdKqXr1l+ FJscbVh7vaVz9LOWPN3wUCB1InP+bsvVEAEEzyn0gTOJYDwLpQhLIr2T+9O/qd0KSq3DgFdnycL p3c1YKJt4fLID+IxHO X-Google-Smtp-Source: AGHT+IGauUJhBlDbnXjFSxEh+PpKEMlvDKN50dHKR7OGhLF8ypS/QohDNva+MjmJzH5ntpRg3haGng== X-Received: by 2002:a05:600c:1caa:b0:477:8b77:155f with SMTP id 5b1f17b1804b1-477c10d4935mr107988885e9.8.1763970965580; Sun, 23 Nov 2025 23:56:05 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-477bf1df334sm179780935e9.3.2025.11.23.23.56.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Nov 2025 23:56:05 -0800 (PST) Date: Mon, 24 Nov 2025 10:56:01 +0300 From: Dan Carpenter To: Prajna Rajendra Kumar Cc: Mark Brown , Conor Dooley , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next v2] spi: Fix potential uninitialized variable in probe() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If the device tree is messed up, then potentially the "protocol" string could potentially be uninitialized. The property is supposed to default to "motorola" so if the of_property_read_string() function returns -EINVAL then default to "motorola". Fixes: 059f545832be ("spi: add support for microchip "soft" spi controller") Signed-off-by: Dan Carpenter Reviewed-by: Prajna Rajendra Kumar --- v2: Add an error message on failure. Default to "motorola". drivers/spi/spi-microchip-core-spi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-microchip-core-spi.c b/drivers/spi/spi-microch= ip-core-spi.c index b8738190cdcb..16e0885474a0 100644 --- a/drivers/spi/spi-microchip-core-spi.c +++ b/drivers/spi/spi-microchip-core-spi.c @@ -295,10 +295,10 @@ static int mchp_corespi_transfer_one(struct spi_contr= oller *host, =20 static int mchp_corespi_probe(struct platform_device *pdev) { + const char *protocol =3D "motorola"; struct spi_controller *host; struct mchp_corespi *spi; struct resource *res; - const char *protocol; u32 num_cs, mode, frame_size; bool assert_ssel; int ret =3D 0; @@ -320,6 +320,8 @@ static int mchp_corespi_probe(struct platform_device *p= dev) */ ret =3D of_property_read_string(pdev->dev.of_node, "microchip,protocol-co= nfiguration", &protocol); + if (ret && ret !=3D -EINVAL) + return dev_err_probe(&pdev->dev, ret, "Error reading protocol-configurat= ion\n"); if (strcmp(protocol, "motorola") !=3D 0) return dev_err_probe(&pdev->dev, -EINVAL, "CoreSPI: protocol '%s' not supported by this driver\n", --=20 2.51.0