From nobody Tue Dec 2 01:03:34 2025 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 652C122AE7A for ; Mon, 24 Nov 2025 06:05:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763964304; cv=none; b=fpFR0uXomE4uy4wwtVh3mORp5UQ1HccF3+I/BadR5LE6l59D0rrHTf4BswVNt93yV1mu9dzNVwFe7ho6XM+RzLVkZ5yI+kyDe7C2BEM83FYY+sU38xSXIbLJa98lmM78FGosU1KPK7ULffAT1t5VGT6pkdQF+7Jk4ca23f5OOWA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763964304; c=relaxed/simple; bh=uwW5/7qGULapL1sVMLPb1Xc+6mdWxww9p7V7V1LV88Y=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=EcF72KLY/0BlS4xjQOgj54r+Z+vBJ9HGuqOm0zCpRBfl9FjQW1xyGJp18OlZaMemfTzyOrp2wWa7mzLoGjwvhQVn9WBrhtb+QI/UUlXWkdHmb0dFaBYTl7lU0w6RSe7ubCoNq0mIU6L6L0ODYvIZ4l0h7osRmjNlnNdCWGT24H0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qx9Oav8k; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qx9Oav8k" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-477bf34f5f5so20159115e9.0 for ; Sun, 23 Nov 2025 22:05:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763964301; x=1764569101; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=uH1o7GeIwYc1DYoErssPphWFX52WlisMeq9xtONgZz8=; b=qx9Oav8kq/eUyg4PMAyVbAa9TYkOJfPG4CLU41YDrLYNTTZrseRzKIOrjCWVHsooYj xENKfb1e8hKuWxpQmiipL1jeehc9rqnWL9prnV2IHHbyyIuByKyEmQZ8rqqzqcHs32mj 47/OBWOk5QONOwVeLgnnx6lSCme3Y5OhQOYlLjPC3/ROwUfloPLPSua9FhnNSAU0MIKL 2dcdWC72e1eEsrFc4iMtuAjM53rxbp3f/G126AE8RO9nq96S8ZYgg4w+uYYvmARlD0Gi tCoF7sl2WZmKrkBSZZcx8/dVY3mzT0ih6L/1MnV+6DB9Qc+CFI7E1Q7g3NbaqBFvDVta LzXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763964301; x=1764569101; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uH1o7GeIwYc1DYoErssPphWFX52WlisMeq9xtONgZz8=; b=i6+/mqoeyeuZkzGnJTKsDLZJZGpPvOnRLZPZ1f0fyvKDVmFMp2tFiA51WKekHJDCJh LL0jDRuoNdpe97h6LeC0ofzzzf11h/e56Dq6t06rH+4xogekRCKP3yEgGe3N8qYahw29 t4j5SN7yfOsary2TPedg4VOiJrJBI3IBbBs0QqhaBe67AAI9jauhwCwV7jFctLAxuwPv siWCumbB0ujIldgPbQkMeOHQ3Sqy82tOHXBW4+BC/434RomDCUC9LTS6OU0lz9+z6yFb qS1UN6cdAJ1J1EmWyxCfw0IarNqh9gxAdXhXHksiUtY0guOaTYH0L4/ikK1zP7FKfH4Z ++2w== X-Forwarded-Encrypted: i=1; AJvYcCX/PjnMskjC2uCT+KvIxgo4WPwqxCHED/UL4HZNvdfabnNfIIgvTCTM4LJjOQmJiUVJYcPckzSrhk2y5MY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywket4fXbse+RNrXwFqZ8Pq1klOwpa1tCJHThfFCjYVMVwdLPZP nqzfpolNNRScsjbF9Agt3eXKpKaGUCUa+EOQ8wc5oSGe3gt4jUSSiacRYbEgKEqhr2g= X-Gm-Gg: ASbGncuC+G8RfTd42saPr+NheCJxIllGYxDQCaT6eIv4rfQjTBZ5B2Zt9IwECFXuIGc /a6+6MoJS6rc2LM8j+fpYMVvK0bfSf55a0jiMBOdowbH3ngSsiNfVm0j1S581cXPvihupOfL/vx Ap/4HXim1ShJ15fu3YeR+OSG8km2pf5BmLuOHb8zrHwjZ4KL49XqqAhHpO/ipuJope/Hnpc99oj rnkW5sgfh55vYlHAfCZSvHIscn8aoGp4pZ26s0p0xkqJq8KcyG687J9UQf9vqwgHk3xVDNwZynJ 8Mgfrr5t0V8EXaJkrcS77yCwYYCZTG3blUdjcWXk5vFjPuOJJU1T8AK12EUBuhA45r1dEFBAPhC TdFEFWIW/xzCuK7YD1uwuojjJZ7ZpAvvvvTE3j6GrVb4Py9xe/VxLmliPsjubnCrVElKF97tE7N 2tlAxhCiNWXhI/uStCTzWm+sFg3sg= X-Google-Smtp-Source: AGHT+IE/1JX/nps0nusBrJi7ArbL72409Zg8vYjuZAApbr5lk5tocgbNd/CCB5XgbxxXSuP2QUkiXg== X-Received: by 2002:a05:600c:1c98:b0:477:6e02:54a5 with SMTP id 5b1f17b1804b1-477c01bcf3cmr104847785e9.18.1763964300525; Sun, 23 Nov 2025 22:05:00 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42cb7ec454csm25365196f8f.0.2025.11.23.22.04.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Nov 2025 22:05:00 -0800 (PST) Date: Mon, 24 Nov 2025 09:04:56 +0300 From: Dan Carpenter To: Luis Henriques Cc: Miklos Szeredi , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH v2] fuse: Uninitialized variable in fuse_epoch_work() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The fuse_ilookup() function only sets *fm on the success path so this "if (fm) {" NULL check doesn't work. The "fm" pointer is either uninitialized or valid. Check the "inode" pointer instead. Also, while it's not necessary, it is cleaner to move the iput(inode) under the NULL check as well. Fixes: 64becd224ff9 ("fuse: new work queue to invalidate dentries from old = epochs") Signed-off-by: Dan Carpenter Reviewed-by: Luis Henriques --- v2: Move the iput(inode) and re-word the commit message fs/fuse/dir.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c index 761f4a14dc95..73a46b0be09d 100644 --- a/fs/fuse/dir.c +++ b/fs/fuse/dir.c @@ -199,9 +199,8 @@ void fuse_epoch_work(struct work_struct *work) down_read(&fc->killsb); =20 inode =3D fuse_ilookup(fc, FUSE_ROOT_ID, &fm); - iput(inode); - - if (fm) { + if (inode) { + iput(inode); /* Remove all possible active references to cached inodes */ shrink_dcache_sb(fm->sb); } else --=20 2.51.0