From nobody Tue Dec 2 01:31:58 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62D0D347BC9 for ; Fri, 21 Nov 2025 13:35:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763732109; cv=none; b=Utlj3O4D3hNnAOP+nqAnMwDDAEGIryIuSeY9R7HOVpR22EnFP9phy3OkAC70e5VADhIqWDDscP2oAhyxPASJky+/6Z184Yju8bDaBMoIANf6s8NXewFsoefD1ljIvdliztVuhVJtaU3/oOD9/NyFVG1MYXVmyF3gKqd/4bD0Je4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763732109; c=relaxed/simple; bh=hktJNp5r4PgkBcqCirMqTHzK016VyP4+D5g6LVifXys=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=XJkI4Pld3mRwv6OnWMUKtY/4Wqw+/Ke8+COzd3QTttjg+Gdf57fDDWiGSY/xaYzca9jmYnKoqfrL/9WxsBhjnk2zWh4NXau/hX/o5fESt+3iECagNIuSupXRthnpr6Y8fIF94NW/370M+31v4vFSiJjpZ3qij5caaFPFFbUqiI4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=x+L1LBMS; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x+L1LBMS" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-42b2dc17965so1952137f8f.3 for ; Fri, 21 Nov 2025 05:35:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763732106; x=1764336906; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=nqvrWwIAH98E3GCNn8rbqv0Z1nqQqruLCAExUktrPVc=; b=x+L1LBMSKE8b6NZH1KVFUhR+Pknn1Y//kAjS6KkwaBNO+loLZh+VZCSoLQe7MMmXa7 Exp0tSyzmpWtBfUt485jNDZ5BtgC8K+6Aht1ct5mSXRAKitzCQUw5fmh82FcAgMWgxGP UIXFmeM3DA9EoyaornbeNVAIpSM3EjNWqpqGW2fQv8XA7X1IhTXNMnaJuZITPu3lG3RS SzEOOlZ3ZTMG7LPP4Bc5JIyO0ub/RQSSZQqJXcFlZTbcjSKbpr68J0U9STMcrvpppKJr zzrr5oF9ZzlO5GXJ6wIF+9kQlQO0KNWqmEMFnFaqt4+IaJEppbgpBRAP4efdMt47P7Mf Qkgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763732106; x=1764336906; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nqvrWwIAH98E3GCNn8rbqv0Z1nqQqruLCAExUktrPVc=; b=XzBgq9Gftsk4nVrjw95ctM9zSmE6EvFr8k0o6GvE6JIjCgnF8D0rCyLP32jLsHJZVY ymqb11iaqGqBsU8H87Abv8Fcp3XNfBjBV1kstyZBIT74+/TY4qY0Z8Q9G85YrTeHDayl bjckQBXZ3jVxn1grkJe0zeTX09/HpcpMvepK+nUmey0yS6ofQ6Zaf57J4BjpYw4Y658J +ur1ecPqfIFLze3uVfIJT89uSIIpzVE5LFfS5czFUxpw2eJBaea7Z526bM4+4cWiQvZv td0sTCOl6kmD4OgtJOkAXnZUY2DDblPwxrb8J6cnZtwu5HIXKmxDIyftpuOTHuasI1sy 0vQA== X-Forwarded-Encrypted: i=1; AJvYcCUWiuOtPlbeQKi1oRdy6QLw039c6rsFfJKTHY/jEXP50rJ0sMG0kxizVaYMlFe7yKM9JRb5f1B11iEkqxI=@vger.kernel.org X-Gm-Message-State: AOJu0YxvdlsOQQMhwCHLZcaJrV9n7Q67Ujj2+tUhJyT/nLkwRQC/r17h YGS7Qv4ARg+ki1pisq5xe1JxEcQLgflao/9ZqIp/6NqemDyWsOfY8/Sz+FDXIsJLZG0= X-Gm-Gg: ASbGncthIRwQzt2Da/YFWsMCgRSmoOdnNJAMtpU43gnF1g+NP8vBoLTUOQUMSM5DvXN /syFaVgQW3cc1dv7jsO5KJRU1iqPd+Hcnjq8o53EkPciAQyy4+I8kaatdSpN9zPzsfh6Ve+FeTp xVsU0SXAKkcJq/siyDqHMnsNogMs1McQawMZYT8uSEkQnoeRuYF2nZ5DPbypMQdLSFEgZwkAuQs VDZJTQKdwVEMcIhoZLWtbDFYHYqMDLXUKfumrgPrGg+KU9gd/ZDyzLg7PwOGhjfpcv+/Rvxq9YU /mOgTZ83l8fmdhlEokLml1GyLoZUfVCggrK7cadQnpiUGMxgL1peaEeXDEkMGz/Tmtl/iHXNH83 kC34Blpk3Zs00XGfBdNYsWTTOW2rTFFk8fLyErNs/Fa+SngvwVkIwy0avrwo/VgLLqSn/e9tECv Z+sHuNGASi+JyFoIIvNptqTB36o1c= X-Google-Smtp-Source: AGHT+IGAAZuJMb35YVwVd0XVBpgFQcFth74Yu5RjXUkruWgElazXjr2FU56f062qpHqju9zFoGQDCw== X-Received: by 2002:a5d:64c3:0:b0:42b:3825:2ac8 with SMTP id ffacd0b85a97d-42cc1d23eb5mr2641946f8f.59.1763732105589; Fri, 21 Nov 2025 05:35:05 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42cb7f34fe8sm11150653f8f.15.2025.11.21.05.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 05:35:05 -0800 (PST) Date: Fri, 21 Nov 2025 16:35:01 +0300 From: Dan Carpenter To: Prajna Rajendra Kumar Cc: Mark Brown , Conor Dooley , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] spi: Fix potential uninitialized variable in probe() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If the device tree is messed up, then potentially the "protocol" string could potentially be uninitialized. Add a check to prevent that. Fixes: 059f545832be ("spi: add support for microchip "soft" spi controller") Signed-off-by: Dan Carpenter --- drivers/spi/spi-microchip-core-spi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-microchip-core-spi.c b/drivers/spi/spi-microch= ip-core-spi.c index b8738190cdcb..e65036cc62f3 100644 --- a/drivers/spi/spi-microchip-core-spi.c +++ b/drivers/spi/spi-microchip-core-spi.c @@ -320,6 +320,8 @@ static int mchp_corespi_probe(struct platform_device *p= dev) */ ret =3D of_property_read_string(pdev->dev.of_node, "microchip,protocol-co= nfiguration", &protocol); + if (ret) + return ret; if (strcmp(protocol, "motorola") !=3D 0) return dev_err_probe(&pdev->dev, -EINVAL, "CoreSPI: protocol '%s' not supported by this driver\n", --=20 2.51.0