From nobody Tue Dec 2 01:28:18 2025 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9E5C335541 for ; Fri, 21 Nov 2025 13:34:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763732074; cv=none; b=ouS+gPoRRTpmJ14uzf0rG8OUWFcVUxiIQfiu0wBudJ+pqxoFEBVOtCjrC3ix2q8xRoqVwIcyWtywTpnMcK+1S+F34QlnxBS9HjE6obUAH5QRL9pUjGB3GBQcSwK6iBIKKFLY/Q3+yhRt5yoM8iIbofBannRkscnSxWBKFqjgiNw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763732074; c=relaxed/simple; bh=Oos7HIGTn/bwgg3Teeti/x3pmf7pNso68OPu4n64u/o=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=O/AcqFcmYDG8vO9VCGTA9TNHr9fQxIeYnkDBjkSoV8lNYwBYnyQMkkMIDutS5uAl5fYdYH2i2xT6znSycgi5GwvCEYFgNTBLsINB2g9I7n8JrHY5NJCWtNhIA8alpr16Zj3TlhdnpUN65g3w7rKIzw9nTWar3dT3q/aeE/ZPgdg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=A0uRsbVc; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="A0uRsbVc" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-47755de027eso11536055e9.0 for ; Fri, 21 Nov 2025 05:34:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763732066; x=1764336866; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=J3CEpaA/qJ+oGSKReLG4S4q01srEKS4qUk5M4KQAAlM=; b=A0uRsbVcFLccWUhBfOJDPkZ8+jMKxjWuUAVm0oi5beAfOHaClvo0+0a+ivn/6MWCzP glKIojLaiKe6w6FRs5wHNX+BJHxrxmcQOiD6wZKjqSfP0bc/VGAj9/J3m1zWbQ+0ig0W dhEQndWFDMe1Zs/rQPfh5z+PHKRNJQsGEe6pcgA8cJWk5i98LtVey9conFFicpYXRSeo E5zP+WFlijU1nAJhPjFgvjoVx+HWmSu9zKIBJGv4ErN4iafPuLMNDpaxY+cAQevsR1FS Q7KUVESbk6wwhRJclPbXH1RwAgBgsN+trYMwwL7YRWS7T2/ztMeu7mNfKFnIrfs+/iF4 COQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763732066; x=1764336866; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J3CEpaA/qJ+oGSKReLG4S4q01srEKS4qUk5M4KQAAlM=; b=TiwBwuCjNBF+DA++WVSqHzULQjoLvVml+r+dRVK1ywoeMi4qypHztJq6QUQAJB5ZBz Wpi4lEEbBkWv3/sZ3/cApoXYG8vjJsP2dD7lv/mSy5nyt+jbUo0kVuCR05Sugc+Q8itv OdBqYm/PghRLNJhLBP2tIhBvLbJ21b9ksYV1z6cJ3JPzcUKxjXUofl0MjmObtF/EWC+d hVfcpOr/JoUtxtbRbURuZoDR4QaBble17mDldMNcqOMyGGUjhW82ZM4qxEe94pqhMge4 9EQB2g4PuhjOougeVkv7+DwWqSif/6hf3zyaHxRMFC+R1SMpMMYNwh2wztzgHQnlnk0E l6pQ== X-Forwarded-Encrypted: i=1; AJvYcCVARu9TQRNE9dAn1SDoRUE6f4kRxAFammTLQ1T5dYqQH0fUURRN2vt0AkQYDo6qfLRm0TbGkdtBNyXF2aM=@vger.kernel.org X-Gm-Message-State: AOJu0YzMr71oCP/wSKP46jccCXkDiGA2Tp5qZKJNDbdQOBde+uzQfGpX S/+vb1WVqaVtj51sUhBDlhHUmE+VrB78MTSzUPH/Ua3Wuh0nQ2OGA2sn6YuJgwq32LI= X-Gm-Gg: ASbGncuLRDFuvTguBJVaKeiCtssdnddXG4hwouAQm9TYVam6FzlpExW90Hzng3enlJ1 uwwDJneMqzpEWMNb7urcjSZN+ppljPxRLnF/cdx/l8yx15Dzk4E2IyGd7uKLk1/XXZns6ulES0G GcEpOu+XcDdeFvQgy+dGLR5Pw5/iRV7gQCydbSjZQ3OWH66k5WU42KgbZfsCtnVBSSoEJ3YP4gs ieLNFCzzl7aFNJEzkBqX2FNR8hhklb6FUmga59tKXX3fiLiGTCcvyQ3FxVMfdoEl/nIm4BAKwqB 4mOdPAvrofUssxDpfOg/U8s2KJb+zvx3tvT2+osqJ6LYnpkTBpbff2me0uiyBl5B6tspdmFcINj JYWuAlHKVmrcHDPvooKeaH658yfXGQx6r1w0iCsAfm+S9BqO6Xj5RnWRP8FZ1WGQIslueY9FJZr ucFGhFYzhoh6UK4it0 X-Google-Smtp-Source: AGHT+IFEY2c4x6XIWLbZF3xrWJhBqpdxwAsK0LObkYinXP4JTX+8TruP5faN5XWGNC0J5oEbJFCbWw== X-Received: by 2002:a05:600c:1f0f:b0:477:8985:4036 with SMTP id 5b1f17b1804b1-477c016bc96mr26169455e9.1.1763732065926; Fri, 21 Nov 2025 05:34:25 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-477a9e051d8sm87690635e9.5.2025.11.21.05.34.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 05:34:25 -0800 (PST) Date: Fri, 21 Nov 2025 16:34:22 +0300 From: Dan Carpenter To: Qipeng Zha Cc: Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Andy Shevchenko , Darren Hart , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] platform/x86: intel: punit_ipc: fix memory corruption Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This passes a stack address to the IRQ handler, "&punit_ipcdev" vs "punit_ipcdev" without the ampersand. This means that the: complete(&ipcdev->cmd_complete); in intel_punit_ioc() will corrupt the wrong memory. Fixes: fdca4f16f57d ("platform:x86: add Intel P-Unit mailbox IPC driver") Signed-off-by: Dan Carpenter --- drivers/platform/x86/intel/punit_ipc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel/punit_ipc.c b/drivers/platform/x86/= intel/punit_ipc.c index bafac8aa2baf..14513010daad 100644 --- a/drivers/platform/x86/intel/punit_ipc.c +++ b/drivers/platform/x86/intel/punit_ipc.c @@ -250,7 +250,7 @@ static int intel_punit_ipc_probe(struct platform_device= *pdev) } else { ret =3D devm_request_irq(&pdev->dev, irq, intel_punit_ioc, IRQF_NO_SUSPEND, "intel_punit_ipc", - &punit_ipcdev); + punit_ipcdev); if (ret) { dev_err(&pdev->dev, "Failed to request irq: %d\n", irq); return ret; --=20 2.51.0