From nobody Tue Dec 2 01:28:17 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B431C34D396 for ; Fri, 21 Nov 2025 13:36:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763732205; cv=none; b=TQnN9ZN9PWBWLxfBL5PTQ6pDRT1s5E4CSaSCYV17k1zqUt8ayRRP44VI4ZJfYlhfRMwNxAJKItcjVc4wgberXEPLnO6QK8TAencCB9lxgc/k89bbcT7Qxa0V4iuKY0VAU/9nERYvTS3Yqrb9Eyn2OhB8QnrSvC0+m63wA6GjYik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763732205; c=relaxed/simple; bh=uE4HXHI9Mc6ljZxrgmkbsKbCZ4Sosf3M2ARYwEUQLlg=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=lj6h0jSEq3OEUv5dxXP2QYyBY7V5CV8SeNZp32ErwHrZpx4jLwPdkHHCqCiNvrZ31lLuWcYfkmY0LT24RJCqysiGFpZRwjeYjpXPtedfqcd3mFGmtbDvSMmhgsxVlyaL2khCljE6AXHqa3GWfRilRp1B/s234Hxp1fb7GZpZjwQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eyYRYvTi; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eyYRYvTi" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4779ce2a624so18440145e9.2 for ; Fri, 21 Nov 2025 05:36:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763732202; x=1764337002; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=TzEyBCas7IooWk+MKSQXAh7ZMi3I77yN3jnhiz/DdHY=; b=eyYRYvTif7jhkC6JXRvPfHTpJQ8u1zzc1UG49YcTT3rMWYe/wWl+aziWGD6MWczsMT PHCTJSZ2JQuLXcPN0lLN8B5W3C0KEW6DahfqcS7xej521azRDgHLIpfcoB01J3ycqiPp uQ8h7x4WUEBwMZQmydNH0e54iAN+lM2ECEcD22mYvsJTSs90lDahz5Ms6E3RIEtS+VhV jTlyVSCx/8/kVc5hw9Tn6S5v4xkjhfALdyzxW9NzJugAitlManU0/tRKHwZTkG1jEvVy UC87uaLuh7bUvG11tpcxD1UUDHnwV529xsObi60wYDXHABS378SUW9UCTtvFWNhOu6P/ n+Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763732202; x=1764337002; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TzEyBCas7IooWk+MKSQXAh7ZMi3I77yN3jnhiz/DdHY=; b=JppbJ4HKufsoJaFBvTpZWfQbHjTOvpxzZZNm8GpwFRYugoHVFyX1VJn3pbPQCui8lt F/HGEUqebZCAsPVRvhn6atnH5FFfIkB3LipZal5++grao+Miq84WhYuvXUFqoTzuFXFn n9gm6u4VsuLtpmhm0NXP3UaD+42KoaKNtvo2HHTz04MRZFlVpNAK4DSdHPUlKUmskOZY KJgAC0TI4yNgtpWEXFZna+uw+EHMunTnw90iR+5/pBoBYrzO+mR46MOBqe5olGpdMItn W3Kfq0tuh/FVoZDavaD/qXWTL0/w3JztSJZPaZKmvNRluML3Qr0A/W9DeFwDY6frZiT5 SQuA== X-Forwarded-Encrypted: i=1; AJvYcCWuDyiY57S9izzBmMhQQs1ox+Ht1CYspqtSw2fT8FUzJizFIun2i4RkEYCRkBs27nkKUklvkMWK6qbvrto=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1wQCPev0Gr/4T3aBnX8vLGdBG66l/XB9LWBfQTC8Wxjr3hYfE avNrL8fN2/aoQ5aaoOdbWYAZJKkc2kMEPuTPfyNjsarjRdTvJlHoWrqh4u4P5uWgL4w= X-Gm-Gg: ASbGncv3tNDV+5f/kZxtoMZ8ysMnwq5v5JGL/xNFt6QaFXwJChzydIltK0NAmmlRHyj EDxu+jrOI0ox8Ui6x7YC7ymA+Xxd6uR3hGJsUiyVBj2/dUFMQhigv/AQq8SNg2Akh9T7QBHdUcr +bEKvAA3ay6yVwLRePXLCMsASY65CCX0SLIVtIuOcj93tZwLlFw4sRJ5t+L5W37gRT9Z1XNSzMn sRsbESCyAlkd7/EkcMEf2oN/ICc/0d3k00RGSdg0h2GHWhCHNwVxMbRNlGybACX1AtUnXK4WLCh oIPGz5GOSfbfK9daDpo2duWRonVZO5j2RIG1H+DlMXz+6e4XnflT7z5zePpi8U71LTfRVsnrEcX FkX8eiTfp2xZzA4r5iDajaaPl4N6KNZmqZqJK8Hp1p18ySV6ElQag/OTB5FoXvtZf60ZWX00U3u 9A2IZgq4p58pSo4czs X-Google-Smtp-Source: AGHT+IHn72BgHYyXBAFrHrkEPwDLpmHZJhWH76OVXgjki7oj4pfilEmGcsYHhJxsG+r/JbIMusA7sA== X-Received: by 2002:a05:600c:470d:b0:477:89d5:fdac with SMTP id 5b1f17b1804b1-477c01f4f4emr28632935e9.31.1763732202028; Fri, 21 Nov 2025 05:36:42 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-477bf3558d5sm43686925e9.1.2025.11.21.05.36.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 05:36:41 -0800 (PST) Date: Fri, 21 Nov 2025 16:36:38 +0300 From: Dan Carpenter To: SeongJae Park Cc: Andrew Morton , Dan Carpenter , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] mm/damon/tests/sysfs-kunit: fix use after free on error path Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Re-order these frees to avoid dereferencing "sysfs_target" after it has been freed. Fixes: ee131696794c ("mm/damon/tests/sysfs-kunit: handle alloc failures on = damon_sysfs_test_add_targets()") Signed-off-by: Dan Carpenter Reviewed-by: SeongJae Park --- mm/damon/tests/sysfs-kunit.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/damon/tests/sysfs-kunit.h b/mm/damon/tests/sysfs-kunit.h index ce7218469f20..0c665ed255a3 100644 --- a/mm/damon/tests/sysfs-kunit.h +++ b/mm/damon/tests/sysfs-kunit.h @@ -76,8 +76,8 @@ static void damon_sysfs_test_add_targets(struct kunit *te= st) if (!ctx) { kfree(sysfs_targets->targets_arr); kfree(sysfs_targets); - kfree(sysfs_target); kfree(sysfs_target->regions); + kfree(sysfs_target); kunit_skip(test, "ctx alloc fail"); } =20 --=20 2.51.0