From nobody Tue Dec 2 02:42:58 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BCEF31D730 for ; Tue, 18 Nov 2025 10:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763462944; cv=none; b=YtRU/GazeTbkvEJqGkz5i0jaA9CZgswqWuS9r01m3GTqvOIbgRU7NELsQLc+mWJgZDTZZX5J095R7BvW/mwi7IcjY2dGMOSXN2qbqOBy15ypoTxKu6rK8u6a8+dbYg/VOkfFyvmKM+cT0AyigaTUDm2YiZHbAABiv27mD8WnJNI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763462944; c=relaxed/simple; bh=pSacPUfTJqdVOpSE7Tqm0QbIDxP64e72/O29IF4V3js=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=BpsVb5hzV2oGvrfbZYc/WN497MPWiNmdQ7KFEFPufX0Ypoc5kYBhI+c7yp7Ylx/ULf2BkYPnMbR8Wh5NEfEkStAM7YnvgpOY/dOdc/RfTm5TTLMeDX5CaIU0o9tRzn54Zk86pHt/gvEfJBzx+F0W/jFMWnPj0HI6fXRvzMq49yg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ukvmWUg4; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ukvmWUg4" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-42b3b29153fso2925418f8f.3 for ; Tue, 18 Nov 2025 02:49:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763462941; x=1764067741; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=s1y/mR0RQcwwMGAg4az+yXoD/LmwVs8/J1VOM/Bo49w=; b=ukvmWUg4dwwnJ0JXXinhYfidVnPXVz4EAAX3kZFoJUGU4b1Jj2vpuyZ4xbsvhbpKmU IUrvkL7GukMavnHxkTKILfL+VkRtmWfVPqHiguj6fRODXp5gmPaqs6Amv7DZ3WXflhTq nYGoSzjo7mUYdpgPA1iNTZ0N//hFfHVeiJ4He/YsvkdzAyxKBZeeoXbZzp8LLIOjx8uw ZfRqEWt91Aa6Gq/hbsDD5skdB55ePq9T+c/afYZPi8V/NcP8sMyVOiIcKMsAwJdZYqBE N3jcRFOw8LeYVz48K49ukbcHmPFUZxgGOMHQ2rxsUk/Fkaoci2Jaovn0Njmzwz3h+n9C 3S5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763462941; x=1764067741; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s1y/mR0RQcwwMGAg4az+yXoD/LmwVs8/J1VOM/Bo49w=; b=VIvZ4HCVr76Pg+wCj1Nog7GW98Lwxt71Cs+OyIP889H8EQqzwe+ThTfUDFRdm83+Lk m4GB6jmy5w8AHvMkJaptEqalsJcT7/lTm6pp0bQWU1vsYt3mMWBvjCg72aBkVLwjpj47 QNJM5t2QoXBDVyqeAVFZmk8eiFZIFCIQ3sM5C3QKxVOh6dNXTW20hbrlHT8UVUoXnxEk jF1YVKdRyQLVQfpsplKuO2GEfFGdfLs5mzreobBCNbjZZAfReam5N/UD8TmoApd6KEAN yRnslBL5oJh5+6C0NOd+m1OPGowekTBybSH9x/FpDFTiz/JBqGvQFv3rsHWjmNNfY9ws ncmw== X-Forwarded-Encrypted: i=1; AJvYcCUyTL8RJZ+jIwOUejP3G6Z0Vz9depzsulS5YZicG0ulRcj/OYP75dPkAvlIy0mBNNfT1lVjkEOfLzrFWjc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5nWCscEoacPf4iya8+JpACSQM8JamvKykfVOBXOE38/8euVso CATpi4goATgEs99bc6xSGsoZQ+CDoeCLGPpXlH83Zau4+oaCG9Bohd1XudooC49GznI= X-Gm-Gg: ASbGnct+tjYLtbsCEPxrDpc3eIcPB5hflM5SpEUy1Fn/z9MV8HvzthpQtO0iJvj4672 84fSW1og/vlDBrrm01qDjZoeqzqtsVCuPLoImJqjMW8fOAsGtwg/dtcu3b0u8+Kxs7EusXtzUKn RPNJb6gfWvvzxXVGUEPOMAf0cXOZl9gaQYo9vQ+19KM2itafmVdCZkXc5nv6XO1e3quoo7Wj1jV nC1dMB+p4VTS44hYaa0fDHqzkK9hjaRRi/XM2/uepg+priwqGuO6t3/fydu3eSszmHTfhNgd3Zd rjy/D/loU1VRlcBQK7cM7VCpc/ZVwcv1v7IekDlJXF85NQGDxhKoE0gqYVdQFgSF5Yd7P4WZe1p plTHOtGoILHK9djI4mUTYuyS4+hDQFW0QN3YfBa3SBFbMeMhefUEPF6wrsvyqDkYPgL2U4nepe5 ZP1NIDOA== X-Google-Smtp-Source: AGHT+IE+uO9N9ifqs1Y8ygDQTWEad0nnwpu/28efWIWor11GJUehCS6HQAbsFian1eY23T6Y6M2COg== X-Received: by 2002:a5d:5f42:0:b0:429:c711:22d8 with SMTP id ffacd0b85a97d-42b59339b7dmr15233727f8f.15.1763462941281; Tue, 18 Nov 2025 02:49:01 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42b53e7ae16sm31647134f8f.3.2025.11.18.02.49.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 02:49:00 -0800 (PST) Date: Tue, 18 Nov 2025 13:48:56 +0300 From: Dan Carpenter To: CL Wang Cc: Alexandre Belloni , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] rtc: atcrtc100: Fix signedness bug in probe() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The "atcrtc_dev->alarm_irq" variable is an unsigned int but it needs to be signed for the error handling to work. Use the "ret" variable instead. Fixes: 7adca706fe16 ("rtc: atcrtc100: Add ATCRTC100 RTC driver") Signed-off-by: Dan Carpenter --- drivers/rtc/rtc-atcrtc100.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-atcrtc100.c b/drivers/rtc/rtc-atcrtc100.c index 51933ae1a2fa..9808fc2c5a49 100644 --- a/drivers/rtc/rtc-atcrtc100.c +++ b/drivers/rtc/rtc-atcrtc100.c @@ -296,10 +296,12 @@ static int atcrtc_probe(struct platform_device *pdev) "Failed to initialize RTC: unsupported hardware ID 0x%x\n", rtc_id); =20 - atcrtc_dev->alarm_irq =3D platform_get_irq(pdev, 1); - if (atcrtc_dev->alarm_irq < 0) - return dev_err_probe(&pdev->dev, atcrtc_dev->alarm_irq, + ret =3D platform_get_irq(pdev, 1); + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "Failed to get IRQ for alarm\n"); + atcrtc_dev->alarm_irq =3D ret; + ret =3D devm_request_irq(&pdev->dev, atcrtc_dev->alarm_irq, atcrtc_alarm_isr, --=20 2.51.0