From nobody Tue Dec 2 02:32:10 2025 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F61A2F12A5 for ; Wed, 19 Nov 2025 08:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763539802; cv=none; b=jA9x6lzCR7KHpXQuiEOgpQ38INH0a+PO32vDy2gddjHzTMVp/QCQGTvoImpTH8gDAuDj5+gsIaHu4N3sJZV9zer5nBc9Vbm7/yQiOEfbk+oeiXa2tvhizon4KzEQ1rLSEszaxyVsGKsPrXlwNLSdDYhOGlGvMx8Ojz3yHC0UP3E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763539802; c=relaxed/simple; bh=Yut0WA+8SDFNziooZRQDH571zlB6+TkPVIIMdys54mA=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=QKlBTmDwETk734b+t3yqGz0kC2eUkQEZfdQm3DcmD+MmoDr7JW9vzUSmid+Tr5G5wHVfKBhuxMHgqlrCao/pZF6qkcWGjs98BXl40TFeJyyM4RB9MMsj1CVRuudhUQrWq3Gql7izdMBr4r1/jrKd1n0eAeVNWG+K5BYXpa5cS2c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qwie+VBY; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qwie+VBY" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-42b39d51dcfso3593623f8f.2 for ; Wed, 19 Nov 2025 00:09:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763539798; x=1764144598; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=FiIFVMX2MR+XXmvXnG9d1/8nmYiayzPl3ENasC1cOTY=; b=qwie+VBYVnit58cr33wDwSb0UtHxPpvJua6ZfibbsqhWxHley4kl++LlnXRnzXmHAW SScx65XfAydUfNQAGf+R1oH851gLQx88h/qyRRaKtKl42P2OOphSkuKTgH8kxoGCrSpo C0taVxK9D22K1WYTyBpe/affBidYcBzWP0KXLX7vfq/v++lBBpkuz0JVpCgWCxTC5sxs QRKNagCXUWBcUKZDnr1jbYFCwdm0W9rmMiKFYWFu+693iLYehmw+vtN/7hdqntAPn+h8 QOT7QKfY7QY2N0H/Srp+vUOMW02PyFeq23KKYrsxdTLle8XGQSVuuHz7RSgWf6dxQWJ7 Wtig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763539798; x=1764144598; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FiIFVMX2MR+XXmvXnG9d1/8nmYiayzPl3ENasC1cOTY=; b=VjORanJMobgwInmqy1ttlfL20+an6lAb/7gQUZvbco5O6uC5DDrsvqFSMppbvzhQ2u nGmCCLp3Sgp+jRJnEWm6DEhnUxQ1dcMFMm+Q/AERnqO+2b18IesNv8/XaPeok7nRJKt5 OJeV3LVsYXE891aD7cLqc//ssIImgosln0R0qVkFZRVG0uSVxjKOmlTIpPVpcKlUzhZY zhkN6TSrMjjdKnY8QBEPbGN5JArQfEEBR5CfJBbeoL4S94Lh15UdixNkfEIoOVPTcRN4 yDbElPBNtyaIQ89ytaBPv32e/oZJa4ZZO0NquijAEhYD6ecUi8WkU4xnaX+YuMHkt9Z9 e3cw== X-Forwarded-Encrypted: i=1; AJvYcCUqAjZcHs3wn4tfjrC3ryRqmsDOLXCGEuXNLwRvyVYDFEeqpRrHv+ZwW+61ws7RZGpFq/ufvqOQlzT/w9g=@vger.kernel.org X-Gm-Message-State: AOJu0YyGfNzJBP6pabwYT/YB4E9mjxuKeMDauABqjSGSJoOuZ/wonTz6 YMb3UhP1Tx1kW5S+6os779WD6i77YTwuAU9hM8T3YTijHIEw8PXOcyTO43x3YgCbMaelnl5WesS 0sop4 X-Gm-Gg: ASbGncs681O9aBjqlWoBD2CQWEihjMpm59sBRAbHujVlvGCF4w9gddHRMxSQndWawKw QXvO6I33OiWX89wKGTGLZ/Dp/9k2oR4FYStLUbX94KkLpPD+3zcxTvit/TVFZJALwTEZ6b8Hyip hMi7Jphk0pDp/xFNOR9rvJYyjioYSFiDAaL2GFogbMPUtlk7THm3T43HmsLGWLoP47vX5WIOpFO j98P3XWfTbXIY0rV8MAg2Zk1hMEzqSuf0/jSvfBUYA8i2R92Pv10CvQ0FpJWFChsjj72w8ZklCp 9+QbK/EBLYnM3MBg6hnTTmoWqvnXA91rBwuvylW/hsuVQXwjmUKzOw1m2fzhoSwyozPr6oVfq/H Ah4ARH4sjLG4dDYKEFyg449N19/j92ydFIGc3qp6jKeE2yEmLfVgtcwCTjiKbjqpzYkzOziGHkv qQaYMkdugYEgInsY0/AsoiShEyTkU= X-Google-Smtp-Source: AGHT+IE1q82L18y3VRPhHfEId7f170t/V5fSl9Cnt7w8NWmAat0eSm35Q1/LPz22OoVfb8I/7QAR9w== X-Received: by 2002:a05:6000:4383:b0:42b:3c8d:1932 with SMTP id ffacd0b85a97d-42b59345301mr16798960f8f.23.1763539798470; Wed, 19 Nov 2025 00:09:58 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42b53f0b60csm35501317f8f.22.2025.11.19.00.09.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 00:09:58 -0800 (PST) Date: Wed, 19 Nov 2025 11:09:54 +0300 From: Dan Carpenter To: Michael Riesch Cc: Mehdi Djait , Mauro Carvalho Chehab , Heiko Stuebner , Sakari Ailus , Hans Verkuil , Bryan O'Donoghue , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] media: rockchip: rkcif: fix off by one bugs Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change these comparisons from > vs >=3D to avoid accessing one element beyond the end of the arrays. Fixes: 1f2353f5a1af ("media: rockchip: rkcif: add support for rk3568 vicap = mipi capture") Signed-off-by: Dan Carpenter Reviewed-by: Michael Riesch --- .../media/platform/rockchip/rkcif/rkcif-capture-mipi.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/rockchip/rkcif/rkcif-capture-mipi.c b/d= rivers/media/platform/rockchip/rkcif/rkcif-capture-mipi.c index 1b81bcc067ef..a933df682acc 100644 --- a/drivers/media/platform/rockchip/rkcif/rkcif-capture-mipi.c +++ b/drivers/media/platform/rockchip/rkcif/rkcif-capture-mipi.c @@ -489,8 +489,8 @@ static inline unsigned int rkcif_mipi_get_reg(struct rk= cif_interface *interface, =20 block =3D interface->index - RKCIF_MIPI_BASE; =20 - if (WARN_ON_ONCE(block > RKCIF_MIPI_MAX - RKCIF_MIPI_BASE) || - WARN_ON_ONCE(index > RKCIF_MIPI_REGISTER_MAX)) + if (WARN_ON_ONCE(block >=3D RKCIF_MIPI_MAX - RKCIF_MIPI_BASE) || + WARN_ON_ONCE(index >=3D RKCIF_MIPI_REGISTER_MAX)) return RKCIF_REGISTER_NOTSUPPORTED; =20 offset =3D rkcif->match_data->mipi->blocks[block].offset; @@ -510,9 +510,9 @@ static inline unsigned int rkcif_mipi_id_get_reg(struct= rkcif_stream *stream, block =3D stream->interface->index - RKCIF_MIPI_BASE; id =3D stream->id; =20 - if (WARN_ON_ONCE(block > RKCIF_MIPI_MAX - RKCIF_MIPI_BASE) || - WARN_ON_ONCE(id > RKCIF_ID_MAX) || - WARN_ON_ONCE(index > RKCIF_MIPI_ID_REGISTER_MAX)) + if (WARN_ON_ONCE(block >=3D RKCIF_MIPI_MAX - RKCIF_MIPI_BASE) || + WARN_ON_ONCE(id >=3D RKCIF_ID_MAX) || + WARN_ON_ONCE(index >=3D RKCIF_MIPI_ID_REGISTER_MAX)) return RKCIF_REGISTER_NOTSUPPORTED; =20 offset =3D rkcif->match_data->mipi->blocks[block].offset; --=20 2.51.0