From nobody Sat Feb 7 18:46:49 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE3B6288513 for ; Wed, 8 Oct 2025 15:09:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759936145; cv=none; b=Motpgf5rz+wXG8p84ivPHIY6P4iNWsoUyOx2p6qUpPEvLj+YXyvmHDZ3S3IRTxdOUlhABkkkigYsVWU2+0Z+FSW9nHQkbh+wB9IRbrdlPBx47xfMHRcORaABK4CtZomRK5jfz/RESnKkCnKK/vLPLPCxdZWaga7hcmk6+46aH0A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759936145; c=relaxed/simple; bh=1K+mZHhUUT08Buqc1WIo7B/dy9RfBBDC35AAmiVX12c=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=TzHBnkpNLPy++3sYg3Bl9ovzIcda+wheA8PsRA0pzpH7nqstOzFdzOHD/ZFnCvY2kxfPvXAY/M4l1FoXM6Jyrrxku/dP/CZAI9CxAVmSufjXSiq1fmHkdDEXsACY+T0FGANimubundx4l59j/oDQTePMNuYGZYnE/8viHqfMRtQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mI03c5Fy; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mI03c5Fy" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3ee12a63af1so17364f8f.1 for ; Wed, 08 Oct 2025 08:09:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759936142; x=1760540942; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=6Lsv/v4r6+foGJWr+qrH8p2k9rjZsdGH+FPsXAlrkVQ=; b=mI03c5FyBkiUk2gVEx+fgak9+cVGldj/HtkrA540CoKE3m0m5NRX5kvSbwN80sGbAf KhvWqYI0G4Qax0E4sqGApnMAXK9MTQaV4BjDztbMPtt3dtdvby/pda4dPBbgitisniPC 3qXXO2tQC5uufYxsSrnsCe1Iu4MR2NJCUj/sE/vPxci4lbxiBWDtvBD0H8iUajnYQOoA wshAese0+/HFGjHL9kiBi6MV9BkRXKR7WfJGNQ3dgjsflrOxNCa5eRvNFDPfcMb0Jb97 UsOdPYWkSmSwev9urvcwEQrbTAncqCr0k8nELaAq9ozoUB4gSM2WwOAW/2g3EAT57235 Jt2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759936142; x=1760540942; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6Lsv/v4r6+foGJWr+qrH8p2k9rjZsdGH+FPsXAlrkVQ=; b=f719FBPmkwteVvOvZR/qg1eikGPkn2gDFn+xdJT8l17dzevy16uZQd2yOn/PAh1R1a fbBpXiXecIJnyt5akyITo0WjJgXVtCiI1uqJ1zj5Ss/8MGQy2StsixwayHsafs/Kr5gl o5+feLQ6YBxIXIMeC0ZNB9qosZPO7YVbLorTakilieJvzKDfcK/7oCUTm18VieGS9Eha ciHJqLbAeKPwF6WO4RsHE4m213+KlEEEILNFodL6nVhKbljBNSpFQ87xUU4k2jpf7PCc KRB9+5SNsXs0fUyZhjuHHGf55VUBrFnWNmsjRs8brwzMxXpzC6Kl2w1PvRUzNbIOcL8D Yt5Q== X-Forwarded-Encrypted: i=1; AJvYcCXgPzvaMb6flkxXZZbUeUYp3VFy3OtAj2Bx+5wqcAWeTpSJXK7gk3gkhuVw0G+NdqjZj0NcVuwVv4337Yo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6X1y27fb+kVDzfDa4J9pp3hpVc3x0pu/imJPD0a0Kja25ugFo yMwX43hfrTQd24UIhsmTDgS+IF/iix/qZL8J/7LkrIDepNib9KDKOb4LidSQIIDyeZI= X-Gm-Gg: ASbGncu2OnnQ0TDrvMDzxzBbo6vvCA/7QX1GkktNjwEPkno2sJiJD5CgtavfkrAvBgY ka1LtG6vZpm5+qEs4vkwZ+cZRf2+wdpQ+Pq0avnYIuXHj710USoru6dG240wnmGLJhhc76YJIrB 8n0Co2LFxLqRO+BT0xIY1Cm6Tv5WVpr3wDCrsUee0VUZDE4xHpppGokIkpEPGx2Bb+v1kIrLLC7 VYT7X2uWfKHPDgiSUroowNwLhQRICa/IdkfBk5KpIiFnseGiEREz7hRGv7M0OJoJKHPCH8M3VNM vovCjwNw9UGZ5MXY4tiSWZ3ljt7KETDB3IrISBrQOeRePoMbPVdjvtG3Or5izr6BTbFqp9SEErw pX+pSw9UfshXjByK1SKsn7pMK8fwe/JT3LxQj4c2DOjQuX2O3f2voZD9h X-Google-Smtp-Source: AGHT+IHYVsHAe0/w87MtOEqTgFE1mT/tsUBsMdlVHgFGbcOBnMrbBTOagFPDRArfyaH2aIEMb5EBvA== X-Received: by 2002:a05:6000:2c0c:b0:3f1:5bdd:190a with SMTP id ffacd0b85a97d-42666ac3a16mr2508780f8f.3.1759936142001; Wed, 08 Oct 2025 08:09:02 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4255d869d50sm31248166f8f.0.2025.10.08.08.09.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Oct 2025 08:09:01 -0700 (PDT) Date: Wed, 8 Oct 2025 18:08:58 +0300 From: Dan Carpenter To: Qu Wenruo Cc: Chris Mason , David Sterba , Filipe Manana , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] btrfs: tree-checker: Fix bounds check in check_inode_extref() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The parentheses for the unlikely() annotation were put in the wrong place so it means that the condition is basically never true and the bounds checking is skipped. Fixes: aab9458b9f00 ("btrfs: tree-checker: add inode extref checks") Signed-off-by: Dan Carpenter Reviewed-by: Qu Wenruo --- fs/btrfs/tree-checker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c index ca30b15ea452..c10b4c242acf 100644 --- a/fs/btrfs/tree-checker.c +++ b/fs/btrfs/tree-checker.c @@ -1797,7 +1797,7 @@ static int check_inode_extref(struct extent_buffer *l= eaf, struct btrfs_inode_extref *extref =3D (struct btrfs_inode_extref *)ptr; u16 namelen; =20 - if (unlikely(ptr + sizeof(*extref)) > end) { + if (unlikely(ptr + sizeof(*extref) > end)) { inode_ref_err(leaf, slot, "inode extref overflow, ptr %lu end %lu inode_extref size %zu", ptr, end, sizeof(*extref)); --=20 2.51.0