From nobody Thu Oct 2 09:18:54 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83DFE2DA76F for ; Thu, 18 Sep 2025 09:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758188755; cv=none; b=LWcK+VsMVguslhUMKuqZWfBoWtq8o2FZ/FA8cHxvIDA1jlSs5FDz3XGUXLms1LiZFMJTFGuyoC3Uk2/bSu2qOGTJQznDell6X1c92bihXMQAD7ZGki19jWsgxCBk7q9FOGPs+IpbdJU1bMNSRyiI1KHmbWMBW3yxFM6RMxuRoWI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758188755; c=relaxed/simple; bh=JoL6E2/9aXfXnQcGR6Zu0injdoly1JOaaGDXQAf0txc=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=gXv2qmawh/kWQaUpJRIYOmnFRM+jeFFNRwXF9X3p5VmXlJOt0xy1FwRUEHQ15OCbYevlzCXFmcQH9Y46FRHG9gaTTcf9+GaCcjPIoNIaelt9fCN9spZA1d85eVYeTXDpMxX8+HZzg8Ff4NqNybw12zRbxwnhhnOOlASHU8E3Mfo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kpIaJive; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kpIaJive" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-45e03730f83so3304155e9.0 for ; Thu, 18 Sep 2025 02:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758188752; x=1758793552; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=7IBogLcogZtqOzPSFPIn7J8AJq9IuoFrHlKGrmKVoeI=; b=kpIaJiveFjL9cP8DJTNPybUcDI+i0gd/iQV7B0nJuZKzeeEXOcWjAWcvF7gDXw/NC9 sQh57aaiAKvjTixO4lTpag/AwR8gh197SE3yyYwH/xRJ5qJ/QVCQ8Q1Y+aEeJP5U2r5M yC9vzjdJurmmObp6WmywgFBl8MtHWBieU/D1gd3MfUD4OtQ3i3qDW04YwUNOs7DVAJJv hxV/ggOe3c6KVlLrNfFu9UTdR1LkcyL5pAP3XDLbSSE/W7IlUzGNx0IwTI7jBTtXiCI/ h5ZEOYr5HzFPDHdBhK84H05Cpu+oLR43tYaNwqUonpJhpyOUta5NnlANu5qWyU+Gh03h 5eSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758188752; x=1758793552; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7IBogLcogZtqOzPSFPIn7J8AJq9IuoFrHlKGrmKVoeI=; b=N9l69BCppJRtg95Jl0ZQxgx1wlttuoKZr1IH1cMJKDYH62NfzeqHTZm9FrxOA8UMGb 0hxFCJztAIAdVUkt3YPz1twy8Ly/EW33mTUa0XY+3wof5nXjeJJxOxBNxPmLMmd3vxb/ JwYYs3YQ/D0ZtPaSJlHzdFcpPKRllQ1gh2c4gi1dVanSbx5cdwjE6u8wRxKdDT9iGRLe OIauAuiZBo52tEuP0SDm5KNkbG29+3WGD+7GfYMlWsk+hGZ6GWbzOtvKKzzb4GR/Barc pDoADOzmMr3J6yDzLkTyS+i4TnBxe57NEiWXYQsIc+mf2bbwEwX+d/bOhpJAXqK4cbYL WnYg== X-Forwarded-Encrypted: i=1; AJvYcCXeSl0AelZdYyfFcxRhu4x9g3qfYBRl4emqCc71orD+THfMkMab9Own3x5cs1mBKVz9X+YlzT0J52a31CE=@vger.kernel.org X-Gm-Message-State: AOJu0YyyuN6+lAKr7+9eJwNRvBYc13VjmNzbeNt0w3f9C22sm4Fw41Cz G/gmJTB8orlI+7Ryt/a7nhCC78NlwSnSkTxJKHv+aghDxr3RUhxjgqHCJyuaYkSaGXQ= X-Gm-Gg: ASbGncuvl/0UI0sXAI0qGTUbtvCT6GmZiGwldwBfsH57n0DnqQOaScY0Alb+k+om/A7 +J8xGXKKo7VTTErhMwdnc3HTnJuuPEqdxm/BKO5Y++8STK3zgILoOmq/6htPOPdw6v2h99d4szf vswGrtoNQMJ/D6GvDfxiKpZ0c4j1dhA6rbB2dYNkKTC0JDEUHGDDlcv9lnoUsc3SW4aobOujfBj 1k9PGgyepJ6WzgFFTkYYgZEJrQMRBMvQGWa9NqKat/3c2SwM4rio2rjA+a9NSpwPXMqih4u9ECD fPyAOW/Sx15mY4nt646k4PKD1DNSTWW14SMtQVqJ/bmEtOiVY1x1QYas94HlNSI1rmsO0iKTem+ RyQuWJ/U68T+Rc/2x7JtE+GKGTcOTxqjYhRTdaSo6bHKAwNf9cZOfDg42 X-Google-Smtp-Source: AGHT+IHq3gu7gXUOtzXhMpgJNwrndnSsGHz+f4WtVJeNQ1ESDCp+aiPn30y5ccNPJPYcrqJVmUrWTg== X-Received: by 2002:a05:600c:1d08:b0:45b:9a7b:66ba with SMTP id 5b1f17b1804b1-46202a0ee42mr49387965e9.14.1758188751408; Thu, 18 Sep 2025 02:45:51 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4613186e5c7sm83783115e9.0.2025.09.18.02.45.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 02:45:50 -0700 (PDT) Date: Thu, 18 Sep 2025 12:45:47 +0300 From: Dan Carpenter To: Fan Gong Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Zhu Yikai , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH net-next] hinic3: Fix NULL vs IS_ERR() check in hinic3_alloc_rxqs_res() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The page_pool_create() function never returns NULL, it returns error pointers. Update the check to match. Fixes: 73f37a7e1993 ("hinic3: Queue pair resource initialization") Signed-off-by: Dan Carpenter Reviewed-by: Vadim Fedorenko --- drivers/net/ethernet/huawei/hinic3/hinic3_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c b/drivers/net/e= thernet/huawei/hinic3/hinic3_rx.c index 6cfe3bdd8ee5..16c00c3bb1ed 100644 --- a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c @@ -414,7 +414,7 @@ int hinic3_alloc_rxqs_res(struct net_device *netdev, u1= 6 num_rq, pp_params.dma_dir =3D DMA_FROM_DEVICE; pp_params.max_len =3D PAGE_SIZE; rqres->page_pool =3D page_pool_create(&pp_params); - if (!rqres->page_pool) { + if (IS_ERR(rqres->page_pool)) { netdev_err(netdev, "Failed to create rxq%d page pool\n", idx); goto err_free_cqe; --=20 2.51.0