From nobody Tue Sep 9 21:30:25 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62BFA2FD7A4 for ; Fri, 5 Sep 2025 08:04:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757059468; cv=none; b=hO1wWyBffXxk2lkttnFula66eT8+Pv9veitrLQ6zOZk4JJYE+b2Only7LMV1zTRgKoTIjEojp2YJ0Gsop8loP66xICxkYq5iNYTzUYku9h9P7QOTIvrMNyFrGdDfJKbGocMV3AAPdAU/2O4VYDSxvJhoE6gPig0ZAwDkJswGYKI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757059468; c=relaxed/simple; bh=BK69GKXDo5Lr+Qkt1GmUdgKZZr1aJR2lLdycYBt0bJU=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=bsoGtVVSm0rHcXheBrBRJo/Yn3ADJgALRXlWvRuz6TBxKg5UOFAeVmGw51wljM1Hvdm4qyVX06aOlUVLHaOI8e7vLyaiklBNsWFj8JBRmMDrUfKXoZUgjqh51fwqcC4i6y1jMqz1X39qeXcp2bf3rlQKine3hTXucrMnbBsj8Bs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WcfCalSB; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WcfCalSB" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-45b9853e630so17069005e9.0 for ; Fri, 05 Sep 2025 01:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757059465; x=1757664265; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=mEyqxPQTlvHE7Rb9nf0Ka5S6ku97HAqdoQLaDQei9o8=; b=WcfCalSBQX5L5ITP6TimiMFu5LeZmc5lCsiv4UcIC7sgdWIAeacQi+ivcACERdRbJo 5K+hEqjm9Fzx8dyl2G/09eXEa8r9AjQKrB/SfEVqduRj6IGOGznuC+vvebSPNFePhQHW HKQXFYWm04kQNz7C9nHmUfUYlqNdoVY+hzr8kXZQ0Ep2iS8+SYwifQaTV4lKRVpPWCKl kQ8uOBE8MdobqhEks0IiblQjB9vZv7D+MJinT19M5p7sm17udyD5jxCtjpKuYo2cUC1b UTJVhz2viI9Ds5vlyWoaH6DAn02bpN8b1jeyekVLEpRK/XX3hkAtqbCiyUnmQWNyxwzS rSVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757059465; x=1757664265; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mEyqxPQTlvHE7Rb9nf0Ka5S6ku97HAqdoQLaDQei9o8=; b=I24aJxIP9aZ2HmsR49KfgDXX4LvopRuP0vuIVf/TEg8qdtyNeLzdpUVyt5Cp8a5GzC 9ZGLp2hHpEp8kdhrD9aOz2ZtNho+g/NYbfttycSBRmoP7fVIJ3rdCDvtmkUURWyKgghm T16ViaMVOmPDpO2wWG/tqY0JUjBv08T8ClnKTtWkI9IEE6OV+5wYbLI+8jevW+y1Z0Bu 8LMVRhRaEZQA5nPHBlEVvV786KdPmWwZ4x/zM1J+GBLzf6M/BW3MwRvE8pdcfIQqRWv5 FrkNErUSerr2qcocFvukrP6vtkfDABhnS3myvdw+LtwZYKjUGdhko8cc2titovsnnw4k wdIg== X-Forwarded-Encrypted: i=1; AJvYcCUGcPBTmZzT386a+iICrjaDI3RGkYXBZDUTKyKulOhtZXFSDLu+RPxrXiwwq4w/Tk/i4emU6qMtpJlB2SY=@vger.kernel.org X-Gm-Message-State: AOJu0YyGYWpeR0I3dPHuYR7+42tJIv6XAiBvqgwZoCgVJ7QEHtH73zpF HYrIo9JHfTu68JwFveiKQRwXLSQwt6oHk97giRWPpI26Xb6OFSbJ3VPTX2n+exeYV9c= X-Gm-Gg: ASbGncusm3it+Bv33Yt+6mmsJlDlzXqWZgIvLxeNTEY5reUeC20zATupMr2DLVer3v5 /XNRnQ8c33t97+2sPRcgtOXvQPMvw17JZqyteqv+pEWoASp1kYhp/ri5nas41G6kNpKAOeQfbaA V3FEuwfIjjoYuhNXmQygWBroXIWpiBJKCUsAiGI5yIwxiqwX7hvZUZILbmNV8HAFxxHCiWp+mS8 zAnVxr3Kgukqm91rmQb+HB9+IT794wh+FsQchBPArgqNz9eq09lcfdEmIhIhvYyeXgdlwNbpgf+ f+WzF4T3oM3jkAUfSRRhacH+S/YBI+9x56PXHc9dC8V3DrnIWPTYacjuCJ0A/PUkClysxoCMxfX dOWaGvll5mAswaC5MXDwXEoBfcaJ3Kf348AaLYq4UIzqmULey X-Google-Smtp-Source: AGHT+IFg31bO3+yEGrU5RDt0pIsHa2/S7Tm9NAlDysnLBMH3Sorox3ujEfiAyqMx4B2CxZfrtHTl2w== X-Received: by 2002:a05:600c:35c5:b0:45d:cf5f:cff8 with SMTP id 5b1f17b1804b1-45dcf67429bmr53251585e9.11.1757059464523; Fri, 05 Sep 2025 01:04:24 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3cf276d204asm30777648f8f.24.2025.09.05.01.04.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Sep 2025 01:04:24 -0700 (PDT) Date: Fri, 5 Sep 2025 11:04:20 +0300 From: Dan Carpenter To: Christian Bruel Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Maxime Coquelin , Alexandre Torgue , linux-pci@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] PCI: stm32: clean up some error handling in probe() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Smatch complains that the other error paths use gotos to clean up and these two don't. Generally, the implication with that warning is that the error handly has been ommitted. In this case, the error handling is fine, but we can avoid a bit of code duplication by using gotos to clean up. Signed-off-by: Dan Carpenter Acked-by: Christian Bruel --- drivers/pci/controller/dwc/pcie-stm32.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-stm32.c b/drivers/pci/controll= er/dwc/pcie-stm32.c index 964fa6f674c8..96a5fb893af4 100644 --- a/drivers/pci/controller/dwc/pcie-stm32.c +++ b/drivers/pci/controller/dwc/pcie-stm32.c @@ -287,18 +287,16 @@ static int stm32_pcie_probe(struct platform_device *p= dev) =20 ret =3D pm_runtime_set_active(dev); if (ret < 0) { - clk_disable_unprepare(stm32_pcie->clk); - stm32_remove_pcie_port(stm32_pcie); - return dev_err_probe(dev, ret, "Failed to activate runtime PM\n"); + dev_err_probe(dev, ret, "Failed to activate runtime PM\n"); + goto err_disable_clk; } =20 pm_runtime_no_callbacks(dev); =20 ret =3D devm_pm_runtime_enable(dev); if (ret < 0) { - clk_disable_unprepare(stm32_pcie->clk); - stm32_remove_pcie_port(stm32_pcie); - return dev_err_probe(dev, ret, "Failed to enable runtime PM\n"); + dev_err_probe(dev, ret, "Failed to enable runtime PM\n"); + goto err_disable_clk; } =20 ret =3D dw_pcie_host_init(&stm32_pcie->pci.pp); --=20 2.47.2