From nobody Fri Oct 3 05:29:23 2025 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3739426A09B for ; Thu, 4 Sep 2025 18:59:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757012378; cv=none; b=Cf3ZOEpv/gbjMGyA/yYG46OBZn54ozkYK5wHyFKMLOZrrMZlu1rvAIVYjuS1VdZJ0vOADFtakdt+UxNb1fNi92kKstCp9jL4HDbD62GSPWwIq28KjiSYC4eUasKmlb1r/Vcz7yvIUyM/HgrxfWbIHH2NfA4xYUotlTzQZM9cNj0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757012378; c=relaxed/simple; bh=hl7UzHlA38V4Bluawkwxwy+Rq2dwVuzKGOkhwZEGe7g=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=GqMMxCGcr11pqgyIeozMvVRbPBBY6R0D4Cl9FWLNPvaGETR2b9KwjnbPxy6fxrEnlBhDhyLGBVrJ283yVRdLInuhXQAGJpQz8OWhwIqHmCAS1PDEOijyt8uhkOmmT/lW9e7hSyLShhZ5PYLg1YscttFuHBOiaDcZ6vjplSUpuR0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NnEc1ysI; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NnEc1ysI" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3df15fdf0caso1069815f8f.0 for ; Thu, 04 Sep 2025 11:59:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757012374; x=1757617174; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=nWB4qwgbKVqfMW1WmVN2/rZ5+FIZKuDCGHJqFvd3HhU=; b=NnEc1ysIVFU8Vkyh5N+4Y0QCfIFALGQjVEJD3HeIOxLPNnGGtg23H6Ez1mKyrbM5jY U9FV8ya6o5MD2QklYYMFVO8LBUC544+VECkAzCvbYjAZxsWTjRamajH1SaYoBd/erAN0 Hk8eZ2jk6D3vOry9FasFfwfURSI722amFs/EkbtKRYDycrK0E8THfC4pLj6E6jYQQgc9 bkdOiGcub+tAhVb5px4lEzuFco1mnWjiVn1aeG/YW5c+5Zin8joQNAH1SOvaEkFR6Alj p2zj0Msq9rsFvBYnWMxX+g0opHoDxis7xkRS9dPtE1MfaPeMvPn9zQbGkTAzE5GNoFLy II2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757012374; x=1757617174; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nWB4qwgbKVqfMW1WmVN2/rZ5+FIZKuDCGHJqFvd3HhU=; b=EigdZDn7wrfxcvZ4cESBRayb3ABuMBvgqbH+L2h/J+3WEK+cz4vgeTTitaSzcfBx+7 qOE9DMe7uE6FOE84ducxy/696t4yoqB63VgmYGf2qSsKSoR+mBgDV/aGTFtNHZHmXoQw HCy31QzxMM9TBvzwGe09BIuTYuYoZDnWneSQeea2GKt8ET2vaI9lfkwmz2a9GHkOXj4B TLIDPXdTIv1go3zkPmiU4bO1wUvyZgieJH4DovKg5Qu6wwQS8LLXhTu+gp1Mr2lEWswe cBWsioYLnKlPtfyAO/suGAXjAwGlsueIp4H34yiFyyZQlCTRIh7liZ2vDVDc4VA/pNt5 /NbA== X-Forwarded-Encrypted: i=1; AJvYcCX7LPc7zSt+TUtClMoGI3Stk/Bl++/L8eacKKkg2Y91ujuJE37pMExAErH0qJbe3TpBXGTwBE93js3f1AI=@vger.kernel.org X-Gm-Message-State: AOJu0YwNMMImikFzUOL2uCiB/aeEO6KaMH9xSPf3Xqhp5TTrmXBgnYGy bYorHIygWwVWVl8/BIyRqumZ4r3kkiE7sF5PKBw6G7y6sziAowv9CFFBrNeMlKNd+dI= X-Gm-Gg: ASbGncsFKE/3cHkPnqwJxvh5M/kfzJZ+pLlUAg/wiAPOJ8q5ttuVQmvKksnq/jHzYeB 4rBCy9TxyTigX/JBQDi40/RBUDQg9TFsgBDR3waAAbD/Tduf93XJ9o2D0nffW9wdjqM/ThovU7/ 1OL8SwLEUGKyrmSp5dW4De684aZxCCCJIJGC0juOv3FhoKrrWavX3GTXss429GeKOwkCIZMTNQa LcPyqJhD2OiWJ70vPgSzpYR0oiaiwwAdLEpScES8W8AJmHxOv7PHN8kmrR26+lFWrt0pR1CC/10 sGF63MjFado5HtMLeRZy+wSwLCkELqd9cdLjDSmRW1RprwAOM4yU7xH/hSV8t1Qs4shZFJbBEww Ht9bSZ46S8kwR9kOBrqFhwdBoFOo= X-Google-Smtp-Source: AGHT+IHZZPprzS9mbuO41DYFLAmvIcfpOdVZu+bM1xROID69orUBhGlsV7b4geCS+yXzO5UlL5rZ+Q== X-Received: by 2002:a05:6000:178b:b0:3da:d8a1:9b6b with SMTP id ffacd0b85a97d-3dad8a1a85emr7222669f8f.3.1757012374584; Thu, 04 Sep 2025 11:59:34 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3d1007c0dc8sm27028606f8f.53.2025.09.04.11.59.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Sep 2025 11:59:34 -0700 (PDT) Date: Thu, 4 Sep 2025 21:59:30 +0300 From: Dan Carpenter To: Scott Mayhew Cc: Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] nfsd: delete unnecessary NULL check in __fh_verify() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In commit 4a0de50a44bb ("nfsd: decouple the xprtsec policy check from check_nfsd_access()") we added a NULL check on "rqstp" to earlier in the function. This check is no longer required so delete it. Signed-off-by: Dan Carpenter Reviewed-by: Scott Mayhew --- fs/nfsd/nfsfh.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c index 062cfc18d8c6..3edccc38db42 100644 --- a/fs/nfsd/nfsfh.c +++ b/fs/nfsd/nfsfh.c @@ -403,9 +403,7 @@ __fh_verify(struct svc_rqst *rqstp, if (error) goto out; =20 - /* During LOCALIO call to fh_verify will be called with a NULL rqstp */ - if (rqstp) - svc_xprt_set_valid(rqstp->rq_xprt); + svc_xprt_set_valid(rqstp->rq_xprt); =20 check_permissions: /* Finally, check access permissions. */ --=20 2.47.2