From nobody Sun Oct 5 14:37:46 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68E3A266591 for ; Fri, 1 Aug 2025 13:34:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754055284; cv=none; b=Ea7tqevOjv4t3Wf1i/cEeU3ato0F3YnlSB+EKkKl7F3ALYO9KRwDw/Dh1cHilvDtgpziZfxh9QQKl4PVY8FlQYMX/lsoI1lmJZSj+FXGyUlhWx8etpklFkFAmfAuHkszG8gFVvCGm8gt/I+/JcECxyX1LV3R8oDOkIipFzYvU4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754055284; c=relaxed/simple; bh=MPOvYXHyt1VUDDVRVybn8iaD9dzrXwNCpMsrhQkJ1g4=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=IlJp7EMhaW4JvN4tDvivtt601dWNOxeAFZE0x593gl51/5CMjz9IltxpPzDw5s8pudawVyLZl6ugLC7CNyzMRJJUjNTg2YABnztaB3uS7o+CJ2QFSX/lB/CFoGIVYCWKLjOYUBmWodKX4Vs+vufabdWOtxexRfdrO/ea1/hO8oQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=COSBTcni; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="COSBTcni" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-455b00283a5so8991775e9.0 for ; Fri, 01 Aug 2025 06:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754055281; x=1754660081; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=JXrCxZaMMaRtHFaNQGeH/9TtujLuny+WCwC4B5wtCMc=; b=COSBTcniNu9VVI60cqSqkKlfElyVj0jBO0n9flH0K6iBDw3f0uS9vQzXNAMHMUJSd8 7YjZTXGg9fRoBsaPSQCSzFATGbH82yMuyfAA8LM1QTZTYTMds3AG1nmUGAjfT9BsBDp1 KENDwvqsQP5r2FTJeO5VQZgxjYny+5fnZJXutLdncgf9hlo86TosOsPYMx7TqGBC1EP+ jx9wNp3+2hcq+UnEvX942lVjMUXEY+vfvq/IPF74Axjuo3GH59sqbDmTi8iWd/EfY/YR WP2KNQS6zpOK+jXLxRJKXsY8xxM8OuaR3Sl20xfiVnzFfm/5wsnVFbQrXbRpXi2qCcms qhXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754055281; x=1754660081; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JXrCxZaMMaRtHFaNQGeH/9TtujLuny+WCwC4B5wtCMc=; b=XmMuVUEwj5vfLFIPgJ1jEjdhb2CTdwxWH7uemxLhnGevzEe+nP8Rf2cIICpeFTmH+x Edfh5tMsmacHdz2A2rr7jFJA69D/VWNMYWWqpK5ZXuINOu8o92k4qYznJBC85hiAd9s+ 1mSvJ3uqlS+C16AMyrRiwERdXW3WOS2WIJfXkTUfitEQpfZk1sOHwNFv6PWfGGaIGhNQ hLRylBg15QCxXjkrDm6lBhTBXBVPTG6dUL7pUFVvDwObGwPg+LrUhz+S08X7B6TH2ncK 1PQaUnXhPu92iRuL0WQeAigaJhyZlDV5b4rkEbB/UQ/c/XG1eYCcnUZtagTq4kEjEQR8 XHpg== X-Forwarded-Encrypted: i=1; AJvYcCXTrJvLXAaAZXlB7W6xe6Az+IlGkgbIHBPzaIKiowmrRB4Oa2uhMo9Ruz4kRLLt4FyF5PtNKEgOtSHMXRg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5R0vsn5pHqtGBSrvVAHAb3/gNbyQ7Jhvs2IU5GNzht4Vt0EOX sb41hMvW6ivJkmWqFIMo8kZUmZss5duVfSCByHWbudTFASA4KY/u3gO1a9MjJo4DPZI= X-Gm-Gg: ASbGncvRLWsQDoPCRk9moCrkRaKgY6E6vDds1ueesm4pzZYpFv2k8BRK5m2TB6dt/pb kU9BYX83zytYdPxpn5HUaM1eUJ2JpLQ/C7ALKr+BnblPd/hX4JgDpCXfZZRhqZpmHRhYe6H1glr EubhV+8TmMIzP4wnX5oe8icZoSIzNbsCEJGRYSz1Q+fdoz1pXAWUTDlaK6tU72ekbGf1e7nu+gf 06QUQdzoihTlXsPtwPohvoOJKEQvKlQ7DIfpzBZkvw2lRB0kB6BVoxUnpTS5pgWahSs02yiyUKg NPHFmKJjUX+4YMvf8VGyIFYU40a77oQubMxNkiPTjEF/vIcghwoUIflOVIQcz/Hdc3vwX2692mw CuFtpZO6iObFVDUY8w0BxLGNQAat0jhUCV1M4Is+JFQ8= X-Google-Smtp-Source: AGHT+IEY4PzKF931Cl4hXP2ucH16DnQzD1sduXwZybAumiUjCHWrT+naQgUR/VvPTU7PmaLeiSG4OA== X-Received: by 2002:a05:600c:4445:b0:456:22f0:d9ca with SMTP id 5b1f17b1804b1-45892bd09b5mr98694275e9.26.1754055280691; Fri, 01 Aug 2025 06:34:40 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4589edf5683sm66413925e9.7.2025.08.01.06.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 06:34:40 -0700 (PDT) Date: Fri, 1 Aug 2025 16:34:37 +0300 From: Dan Carpenter To: Marc Zyngier Cc: Toan Le , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There is a typo so we accidentally return positive EINVAL instead of negative -EINVAL. Add the missing '-' character. Fixes: 6aceb36f17ab ("PCI: xgene-msi: Restructure handler setup/teardown") Signed-off-by: Dan Carpenter Acked-by: Marc Zyngier --- drivers/pci/controller/pci-xgene-msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controlle= r/pci-xgene-msi.c index 0a37a3f1809c..654639bccd10 100644 --- a/drivers/pci/controller/pci-xgene-msi.c +++ b/drivers/pci/controller/pci-xgene-msi.c @@ -311,7 +311,7 @@ static int xgene_msi_handler_setup(struct platform_devi= ce *pdev) msi_val =3D xgene_msi_int_read(xgene_msi, i); if (msi_val) { dev_err(&pdev->dev, "Failed to clear spurious IRQ\n"); - return EINVAL; + return -EINVAL; } =20 irq =3D platform_get_irq(pdev, i); --=20 2.47.2