From nobody Tue Dec 16 05:36:40 2025 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB9331A255C for ; Tue, 27 May 2025 05:54:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748325252; cv=none; b=MKLbsUeASmRB4Kqv6nWuHP6YoAFFnIFb9AEnKZ4ZrWZe4njE/MrBjlVHTmr6HFi72Hhdn31p/7JE++gRnHdyxrvadJ95+7whMjQ8DIlAeB0nLqFfpWg8F++GlNKZ/jnd7BTBDSkf0eQr5hYLVmP7Jqx5yCkmUyb0jbUSwoJXPXA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748325252; c=relaxed/simple; bh=HjTMatqeqVA60Vr2vbz4oeS4Caye/UgdIEnm2hUQ/Y0=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=C7xFdyo37sWY7ZL7cBgsz8q0g8KfL/lg2mOvgleIr//3VeEICruT5qYX1mH5Tzz2FbbbMKKdmwaCSdPdy1f5OJybLLx7Hpd3ANwkFgckru+LzA/SWC7duwQ/jFSR1Yca9ZQuHhgbktcIs5wHc1y7cWqNTD08ELsj/gag769EHGA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RQMrMWvx; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RQMrMWvx" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-ace94273f0dso574209666b.3 for ; Mon, 26 May 2025 22:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748325248; x=1748930048; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=qMBOVGdnQVQ4NSm9o7YnP9x3OdPGFH+Y2T5UF66g6X8=; b=RQMrMWvx4fsspDWHyLKJkHMZcDB5yWogw/Wo6jgqUL47r2qJj/zmYDrhqm7seVX/nP 3rsXu7PdhmUICkx+WKJT1R0Cm1ZzLzNI6uqBMm6S0GmAjqpU2/yHWnND6YD0XgiFAZjz 2zvdR+CF9NS7wxNUU1Nf4ZPQfAQ43Qbno68xXVzZyxjnbFhFiVtUB6e4QWLCBvTelmcv 2Q3HrMl2a0de5WZrKo28y+3Xi3JpsNvQCln/PNIYwlTKWvdi7Ku7fjJasGOEU6ZsBTzJ MXoqcgI5Pr8wmc7XRrAtJ7VRR1aDmR2x8NyK5L/vyuGhqmSq+mLaxEPmJqSc2qPKG0IE /ZQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748325248; x=1748930048; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qMBOVGdnQVQ4NSm9o7YnP9x3OdPGFH+Y2T5UF66g6X8=; b=mOkz5ty21KfyGe6LSbonWrIImV0sqBWjsnZw5lRc2kzcuqIsdmh8BJMc20oO3VdpDE Q9S+LLmNfAwaIFreyFeJtnJ3EVkQMJ18KSGS2d+RIwuuTWz5aY4/xxV78m0P5hHgvQOl NjHwJjy+FCrTvzEu+gZrxZsPX5/HQ5ffFImSh9nKYXe/aonHshD+pKLQ+A2JskD/j8tW lpibt8rntV7+0tixkh9xGt+JqYhWxipLswHwBKQwrZU6dT2UECTarq9vgb0pfyndGVhL XT31qh2H14pozu504nYPmSBZjiGL8gdqvMgOxQzqr50e2iJRZPftdDWoCEWOYLp2PPvV m9MQ== X-Forwarded-Encrypted: i=1; AJvYcCXFl/5BQyqnKgmCKPyWj1ZBEu4hzSyaqQc04j4uYPp+NhBFbkBSV0tHR7quKdAnhiG89ZmyndyFyIsHJrU=@vger.kernel.org X-Gm-Message-State: AOJu0Yye9IqvVcNncRTYquegRh3f0v3z9ln0LIOaEWSK3vURJCDrYQem 5CBWCBfZsNCW0gMw89SiWq0qlYpw1jHNoRPD3Y55ER/g+aYuFtfdZtOCoTOghQeCq3U= X-Gm-Gg: ASbGnculLtbMiUmSVngGaZr7OndnDapeLUm50U8ftzD62UKtTUH3BD557t97xxX68cJ weeIBrxYZWvIKz57qWFJJycW2nHQL+rm40D85dZB3RjJA2cgvtnBEckHiCwKM2qNC2u2z6xNgVk Td2V4bXAOt55Q10Vodsb0EFTkGD3ePiwQc+o0L7m4ZVviV1aUmaBkTdz50ZbSmKNMG/YZSFOqe2 0GU+0nvV58XNVvNo6s/KP18k3GwjwY5uDxMWT3UDqv80UYZpXuvqxOVj5oWV/9lg0LUH9OSkcP5 3djoBFxRDuoZwu9+BycQ2wge/v7DW13ijDEiX9uErf4FcOY3Z+ugUvHKHNPMYwdPXGtJOa20xzg = X-Google-Smtp-Source: AGHT+IG2ab0KIO3Z5oiiNuKbor1U3QysoZKdFmQOlEh6I2uRnGXcGTV467zCuDRfsK2qo6oElSKgYQ== X-Received: by 2002:a17:907:7f17:b0:ad5:2137:cc9e with SMTP id a640c23a62f3a-ad85b120246mr1089746866b.3.1748325248139; Mon, 26 May 2025 22:54:08 -0700 (PDT) Received: from localhost (hf94.n1.ips.mtn.co.ug. [41.210.143.148]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-ad8816eb7e3sm171917466b.50.2025.05.26.22.54.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 22:54:07 -0700 (PDT) Date: Tue, 27 May 2025 08:54:04 +0300 From: Dan Carpenter To: Tony Luck Cc: "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] ACPI: MRRM: Silence error code static checker warning Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The error code is not set correctly on if kasprintf() fails. On the first iteration it would return -EINVAL and subsequent iterations would return success. Set it to -ENOMEM. In real life, this allocation will not fail and if it did the system will not boot so this change is mostly to silence static checker warnings more than anything else. Fixes: 04f53540f791 ("ACPI: MRRM: Add /sys files to describe memory ranges") Signed-off-by: Dan Carpenter --- drivers/acpi/acpi_mrrm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/acpi_mrrm.c b/drivers/acpi/acpi_mrrm.c index 2f22f013959a..70088cdfde13 100644 --- a/drivers/acpi/acpi_mrrm.c +++ b/drivers/acpi/acpi_mrrm.c @@ -156,8 +156,10 @@ static __init int add_boot_memory_ranges(void) =20 for (int i =3D 0; i < mrrm_mem_entry_num; i++) { name =3D kasprintf(GFP_KERNEL, "range%d", i); - if (!name) + if (!name) { + ret =3D -ENOMEM; break; + } =20 kobj =3D kobject_create_and_add(name, pkobj); =20 --=20 2.47.2