From nobody Tue Dec 16 05:38:16 2025 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84BA313AD3F for ; Tue, 27 May 2025 05:51:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748325108; cv=none; b=tr5iHz+hFmLmUS2o7kJglKsKk8NgvxERR4FD+kUYXl216C01sSAxMEzT/7zZichoYAUM/bON/ikyPKOcIZgLUlGkXUXiv1LIYt844bK09YV/dKW3MGlTNXSH71HRbCQpRw931rLN/msRNaDwaDjufiISvfY1cbOyUMlOENs7Qx8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748325108; c=relaxed/simple; bh=FRU9W1+DS8rfpo6UNzEN6UMBg1u0Yz12fF9f8ZKM/kE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=VOU1Gl6/3BGRkzwHNWJP4Mjtc8tpRZ/HCLfYtr4/Zbeoc2C9FIcCZfBndG+yjOf4EFdyWYUbbGR6IdK8/Vq3l9auKqaM3X8E+3XxDgZlz43VZTZ29SQSv2qcxE18qYpgGI+hJta5OPmODYRcYS9ZoTU834TOl/CJBLr9L9fMBLg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bHBTFXVq; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bHBTFXVq" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-ad216a5a59cso365819366b.3 for ; Mon, 26 May 2025 22:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748325105; x=1748929905; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=ZVp2NY7FohPgZU2Typ+0h2uamFavzqINb4M9GCUjHoM=; b=bHBTFXVq7lydwB0QzS+hm0UM3cfkRYU8KwUkLGuYw2TcnPaOUTR13DvGMIXmoqNmW0 HA2S3B579S0TlaPnpVn6T31o4VgrKCs2yJXpOTDGwxNxKNBh5Hffe+Bp5do0pn+GjdgR MpY0S9SaXpe5RFJEbnAdlLvQMlEKhCGG4bEzvW+a0/HC0o8ikkSUFjzTH1VKlodI4J1C l5Q4C7TJGoPgeNKaJqg3pzlnzd0+cs0RzloH7ZxFCOrwLaQs4p6zoG21ZdvrPMWPYWyE xmLtJaE+wHldpnrw3Y5Z2cJpuNTp3EJ3H5Aiz4sZGlXTfu8IaEpkray8s4svhPcYmgfv +5Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748325105; x=1748929905; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZVp2NY7FohPgZU2Typ+0h2uamFavzqINb4M9GCUjHoM=; b=xBt1sWffRObK86eIIxu16pzdL5/N2585q5T2yrNHeVanQXp8M04074AfSZ6EdS2aL0 R/Q9tADQfcJKa9qCzJamktfUO62MkzzjDTN0GAwRGbUl6CgaTHYnp72HStbu6fVWUudW Lbs4Du8YusyyBueQkCRYjshgZvLdkpSpyo+OtwOI9CJftsGfSg5gn+74AuxQNo15e9fx mhuI2Tj+iwMe1A9g+N57M/bjDKRWSVwApIo+PBaYMa3Q8gMaho4mB+25hTM6cn2E/zWS BnoFVl84BNh/zQf26H1afRz9a+9PkXgNYwKPN1KL7LRaKfKSVrW/41XdgK6O60fZu8Fs sacg== X-Forwarded-Encrypted: i=1; AJvYcCU4cLqd3hLB9Sw5cia362O6oRB1m1AvE/ZhVe7ICkSwchJ9QIg2iPwrsMwnOXNZdG0nCb0/RqoCVgKYLsE=@vger.kernel.org X-Gm-Message-State: AOJu0YwVVEfsxbBj3bl4RrlZk1uscdPSAvttw1Eyuh7BJjFXtiwbW7Th iLiDBMq+70aX9sN/mlxsmkjiRCQFDlcdJk2nAhIPob36Cf/qKEx/1gwdZNAuiWuJpy0= X-Gm-Gg: ASbGncvmULz3+glWSz3JI7bjS6Hfmb/eCfjo29akn7Qz/vFtF4BLGcT9uZ3y3YkYkJC bfJiKbd4VuTNa1nX8HLIy/DHr4rAORYkzZH6q3wF0iuNnKffoKLXeLClx5NiJ7VkQlAYk3P4n8b TqNZxJedoFEXzhrittrshX7Fvhb6YHV8548AxYiWIqU6nDMV0AP4i1U/7nCZV6HFYUywaSa3lHV G2RG2TDOM5RrSTZ4AmUGrEZ4J46DrvNBBQHGDqsdA5one21ziH2r7DRmiqQs7PThfgYUvi8/LFS 2GDPRWgfDQ/sHrvLpFaXmziPMhOeX0KWdOV6Lip0aVfvX2JuuA50I5Sb/8QCD0FpeWqUbpTZ9Yg = X-Google-Smtp-Source: AGHT+IHjsxqs/6jcL8C7UZ6kgwo4G0JpqJqenkT3mjexlsQRl4jPPZvuq7A6WGfuQrzvXuOSfE1M6A== X-Received: by 2002:a17:906:b84c:b0:ad8:883b:f10d with SMTP id a640c23a62f3a-ad8883bf140mr176024766b.34.1748325104785; Mon, 26 May 2025 22:51:44 -0700 (PDT) Received: from localhost (hf94.n1.ips.mtn.co.ug. [41.210.143.148]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-ad8908a54f8sm40467266b.63.2025.05.26.22.51.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 22:51:44 -0700 (PDT) Date: Tue, 27 May 2025 08:51:38 +0300 From: Dan Carpenter To: Eugenia Emantayev Cc: Tariq Toukan , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Or Gerlitz , Matan Barak , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH net] net/mlx4_en: Prevent potential integer overflow calculating Hz Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The "freq" variable is in terms of MHz and "max_val_cycles" is in terms of Hz. The fact that "max_val_cycles" is a u64 suggests that support for high frequency is intended but the "freq_khz * 1000" would overflow the u32 type if we went above 4GHz. Use unsigned long type for the mutliplication to prevent that. Fixes: 31c128b66e5b ("net/mlx4_en: Choose time-stamping shift value accordi= ng to HW frequency") Signed-off-by: Dan Carpenter --- drivers/net/ethernet/mellanox/mlx4/en_clock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/en_clock.c b/drivers/net/et= hernet/mellanox/mlx4/en_clock.c index cd754cd76bde..7abd6a7c9ebe 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_clock.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_clock.c @@ -249,7 +249,7 @@ static const struct ptp_clock_info mlx4_en_ptp_clock_in= fo =3D { static u32 freq_to_shift(u16 freq) { u32 freq_khz =3D freq * 1000; - u64 max_val_cycles =3D freq_khz * 1000 * MLX4_EN_WRAP_AROUND_SEC; + u64 max_val_cycles =3D freq_khz * 1000UL * MLX4_EN_WRAP_AROUND_SEC; u64 max_val_cycles_rounded =3D 1ULL << fls64(max_val_cycles - 1); /* calculate max possible multiplier in order to fit in 64bit */ u64 max_mul =3D div64_u64(ULLONG_MAX, max_val_cycles_rounded); --=20 2.47.2