From nobody Sun Feb 8 09:10:42 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17BD913DDAA for ; Mon, 5 May 2025 14:34:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746455663; cv=none; b=FXE5sbndwUWQF7tjO0+u1OdQJMIwqC603TCMTssblTXjhPU96TixiMMgvhPwpC7QE72l4a5yRgEmd714l9jmHVvqsXGIZMS6bGM98LPi9tgWTo7A2dLhTn7xK/ULov2Lv+o2YsZI4W3HcG/1GlRoVMLK8CfvrwycXOlgWxePwt8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746455663; c=relaxed/simple; bh=wPWDiuNy3mW4l26eURif/yg3oVzB7iJnJ6pGeCyG8qs=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=kXDtePWMAYwMQwVphxWdk2x+ONs7pJ9t4C4zi78g2oTqlWQoaEgF/2nN5XBBhYtayq0l2mSue+AkQp2OWLPqHpuvPoajs/sVLZubgbVPHKUr+H26Oqq0ABtI58xkeyDRlps1ZGptl8T7OFVur4fSVYnTMx0spVhnBDN/5bi/YEw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jqWh4CP4; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jqWh4CP4" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-39bf44be22fso3036885f8f.0 for ; Mon, 05 May 2025 07:34:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746455660; x=1747060460; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=FnbCwzPudDkiSSrhyT+WBIXfqqkwVhocBR1cTw5NLso=; b=jqWh4CP4JXYguGdtaR4xZzqXsWlXd5E1Al/ZolemEqRyFbeb/buMpumPDAln7HQak7 R+kmI4Fcm4UeR7mA0ltQOeWN4O7NyYsJ/Gyi/xeF0xpGqfOCf/goWMYyegwOCFWODDsS Qj5C7/eQPT1PoUmp+SVUBYpgO7rDzM9waAIEYWwGyBbVzaV3fqZXrga5cA8ItyNWngb2 x7K1rpHy4KN2in/v9HpcHiLQHQB+TOP7r4d59Jqto+35h/KaoAIWFPfELkqaHw1/e9OJ TZ4BFJiMJgNmLkaSTalQJgXgJpN4mDrU7gVyZEzwWP3fLVuc5hTvxEwtXnfuib0HCC7M fkJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746455660; x=1747060460; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FnbCwzPudDkiSSrhyT+WBIXfqqkwVhocBR1cTw5NLso=; b=OiSe6iFZurgNqb87GSyaqvX+ZOpWpE8HkFE89120IOOytBGXVSnZE8OeR+iMlWDArl wzeOVpysqv9oMUXZ8hb5coyro+sYMlH5S1ODaaDw5qA8D9QXM57atoH1dGN5mjhe/1tQ ldgY+F/Ag2acFj/WqqgLR90o5WUCvRqdhoqY7fCf2wdT4WL9FrKKzzVUZPM9fp0LZCZ3 Bud6Ez7cMSLeTMyo1+KULP09lEQUmMOfVMF/QyEaU198xDMuxxFHeUXvpbaYvY/yULKK i28IjYHBOHizXQljfo38O3IJZiEbwpKmPhh3PLAXCaSnzJWyKaP7MEHBi3wDd25FNxQJ 8rGg== X-Forwarded-Encrypted: i=1; AJvYcCVNLCfALkz1DmSruIEY2RvKXxHOp90brKrPRMM1id9GZtEOWnCqNGSjZyEtAnF3h8urBA2zBG+1ntBDcO4=@vger.kernel.org X-Gm-Message-State: AOJu0YxrUlLVJZppFguSr4/8x0wqaChwOzd94GfNhZLZ0FAtoiiTTL5F WOOcuyZSAd+JuqrELKnXEQoFcxEveoz5tm2ZJBRJNBhhMSJxMU+OC1omVSnbt5o= X-Gm-Gg: ASbGncsnFhT06jyJiDSLRH2lKxUE+XozepfnAVN48GmNZNZ+eUHPGuF4R6MAHDFLA7v JrKD8KQs+Yr6FEMFhBeEXqg5h4tyMrVC4ZOvnGvfi3/hPjoK6Bh8JwqjSXlOooMkoGoMDNypKwN YHm4x01SDmtaKUA/v/HpCFcKQ9dtcLv3mLSPqBmCabnnRMqo5J0EscXAcexDw35N6L8nd3JuMY4 BrL3Cb89s77LWm/65l4ZmUwFScq8EENduAem/2UhgE+3OJlmqLZfG2rUdbImAC9KJAz3ZeGYD6h 83wctYkZ66qeRCIM+lEcdh9E3YATxoXnswDZW0gh7tSEXQ== X-Google-Smtp-Source: AGHT+IGeLrfju5zWeAYtYvyAEYGbgnW8bF7ZkzBNUfY0zuisIpuKky3gv6rm7707Hc90jSISsdGZYw== X-Received: by 2002:a05:6000:1946:b0:3a0:a09b:6850 with SMTP id ffacd0b85a97d-3a0a09b68c6mr4246077f8f.45.1746455660315; Mon, 05 May 2025 07:34:20 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a099ae0cd6sm10499390f8f.5.2025.05.05.07.34.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 May 2025 07:34:20 -0700 (PDT) Date: Mon, 5 May 2025 17:34:15 +0300 From: Dan Carpenter To: Corey Minyard Cc: Corey Minyard , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] ipmi:msghandler: Fix potential memory corruption in ipmi_create_user() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The "intf" list iterator is an invalid pointer if the correct "intf->intf_num" is not found. Calling atomic_dec(&intf->nr_users) on and invalid pointer will lead to memory corruption. We don't really need to call atomic_dec() if we haven't called atomic_add_return() so update the if (intf->in_shutdown) path as well. Fixes: 8e76741c3d8b ("ipmi: Add a limit on the number of users that may use= IPMI") Signed-off-by: Dan Carpenter --- drivers/char/ipmi/ipmi_msghandler.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_m= sghandler.c index 8b2c3fca9c4c..064944ae9fdc 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -1240,12 +1240,12 @@ int ipmi_create_user(unsigned int if_num, } /* Not found, return an error */ rv =3D -EINVAL; - goto out_kfree; + goto out_unlock; =20 found: if (intf->in_shutdown) { rv =3D -ENODEV; - goto out_kfree; + goto out_unlock; } =20 if (atomic_add_return(1, &intf->nr_users) > max_users) { @@ -1293,6 +1293,7 @@ int ipmi_create_user(unsigned int if_num, } else { *user =3D new_user; } +out_unlock: mutex_unlock(&ipmi_interfaces_mutex); return rv; } --=20 2.47.2