From nobody Wed Feb 11 07:47:36 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9F462135BC for ; Wed, 30 Apr 2025 08:07:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746000447; cv=none; b=TmbTXDd+rva/SgpLjJ5NXyMRVj4udn2s5dkv2pOIuQXRn+w/bXvRSJVrZ5U3Zuxns84IlRcynxBHeIQiz5Tu/zf2VYqAa21bLrNpYoFLvPU/+bRANkP8MsGdwI3dZxemy0t3iPxHyGbeGFZFIJS+Wuh2KrnyyIZeGw1Gb8LI7XU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746000447; c=relaxed/simple; bh=TwBAWvhA2LMsfzhyPe3YteWvIvV7NRQQgO+b0MIyY2g=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=PbKcwOg7djaWmHS3v4m3etD2Xqb/U0ggmJWUK10/1mZc+nVGicRvW2+WqpjPcGaVYtnJL/669pmHch2WrA+3g2TVfvsKuHvridSVZK48mAAEWyFi83ZB+4K1c2Lb3UJwgIYPaDRpyUSGMyEts+dn+/sM1vUMcmddCVYxoqgMQgo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hU94Xi0V; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hU94Xi0V" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-43cfdc2c8c9so35280595e9.2 for ; Wed, 30 Apr 2025 01:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746000444; x=1746605244; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=uc9OCM7ZIzJpNzeChHt6JK3Q3WLBO25WpfMZPcs6ME4=; b=hU94Xi0VZ1VYHLijxt+hy0dhmt+OGjjL/bmcMkTMS5IA0+V04UBj6y/JHuDEyBN5Yg t3e0x+8LRgy71mJZSwNrdnMwewNasb7SKcCt4XkfMn7Ar5GhYdfh7HlQyyuHpzuLTlbQ ikG54sfa13kbbbKbX+C1CgJdWY1SJk+N99uBrmlIRolKabm4Td6iXtNuFdwg4nD9mw99 4rvsQklhXAikRXcwMokReJ1cjZ2TF12jKGF+Adb4KBUwQN46GFa0ASPL3I+FTDIgMRk4 Qd93TSZlKWjqlbgdztkyE/S7r39kJZFdMle6/gy1lG2lPA4c3NK2JdDrpSGbPpWx/bV+ nbRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746000444; x=1746605244; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uc9OCM7ZIzJpNzeChHt6JK3Q3WLBO25WpfMZPcs6ME4=; b=AX1nzHKL6pp1MhWmlVfGbkxy9tZAlYINfbEbLPolBE4ClAQQ50C1pl3mrrkFSdRRIV HT7x9bN4PV+25Re+xFYgjHOnBpPF5CVD9LdUu/aULFZekFCfHaEWZjJ0G2NmEifPrZJY 1oyT5pKs0RI1AOoWZ9VlI+9iuNbKtjRnpLA6S+kmGV0DvziwCIhMfZm9Z6LSN8oC1fQe YO7XByVUxDucbHTYXfNaefo1EcMF/0QZ594Z/0LpD3+mX0R/9j72PpUnBmzeAj5TTYdO d2Qn5Quu6yH8h6oyIK2IVWBxH+2iooJKT0hrLR98bMwUsmyFsYb1a3h38ShbRfcRHp1b mV/A== X-Forwarded-Encrypted: i=1; AJvYcCUX+A7U8NFmAfAbuqPbVgf1/QXpKp+wyE2HJbwdB8/focNb2fFmosuRnK7EI8o9YcX0Vf2y0P7p+ZgblQI=@vger.kernel.org X-Gm-Message-State: AOJu0YwWr1P3d1sW5PgxoFn9+TkDlkaYBwVY8GrE2EFKjFaND2KK4ezw q6Ju0+cEyxrHP7CO5rdxqU2YhzjODzKHJkxFSZQMRTVwM6bN1x1G1tDtxPkJapQ= X-Gm-Gg: ASbGncvKsYfNMRskeNhZGcT0CNZbhanr5odey1+kQCbVPiFEkw+7KM/VLw5S5A+yul2 mNnKA4J7j3NPgYXVbxSLUz/Ol2yU7K1TUT/kcXnN0XF4DK7HFUBXCq/XD9xr0scdqMS897LexQs nYKZaWMpq+dnM4KuqMkxgjOl//lZoqI9tor2oXZQ638xo8zPa3WdeYLizAsJ4raYu66saBmWXE5 nCGeeGkrLRxwS4InD4LDOgbRB9lB8dgN9ayw/H6lRblriStt+b2qt6ODs9fWwxMSJePQJdAH+bV L2H3u8STWRHJf+wXzA7QNtaMcyGNLFodD34r9IQC5n/A8g== X-Google-Smtp-Source: AGHT+IHu/zka1ZNTIDULuYu0Lh1rRpwgaoOIaY8sTkizKLpXGbJF9/FHIhltJWjgeRoIv/Od3HWxDQ== X-Received: by 2002:a05:600c:4e8f:b0:43c:fceb:91a with SMTP id 5b1f17b1804b1-441b1f35811mr16919135e9.11.1746000444147; Wed, 30 Apr 2025 01:07:24 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-441b2aecc20sm15588745e9.13.2025.04.30.01.07.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 01:07:23 -0700 (PDT) Date: Wed, 30 Apr 2025 11:07:20 +0300 From: Dan Carpenter To: Viresh Kumar Cc: Viresh Kumar , Nishanth Menon , Stephen Boyd , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] OPP: core: Fix loop in dev_pm_opp_sync_regulators() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We accidentally deleted the if statement in this loop during a cleanup. Add it back. Fixes: 5330d0dab736 ("OPP: Define and use scope-based cleanup helpers") Signed-off-by: Dan Carpenter --- drivers/opp/core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/opp/core.c b/drivers/opp/core.c index fc9874946453..f56ddae35ef2 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -2889,7 +2889,7 @@ int dev_pm_opp_sync_regulators(struct device *dev) { struct opp_table *opp_table __free(put_opp_table); struct regulator *reg; - int i; + int i, ret; =20 /* Device may not have OPP table */ opp_table =3D _find_opp_table(dev); @@ -2906,7 +2906,9 @@ int dev_pm_opp_sync_regulators(struct device *dev) =20 for (i =3D 0; i < opp_table->regulator_count; i++) { reg =3D opp_table->regulators[i]; - return regulator_sync_voltage(reg); + ret =3D regulator_sync_voltage(reg); + if (ret) + return ret; } =20 return 0; --=20 2.47.2