From nobody Sun Feb 8 12:29:03 2026 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E3012561D6 for ; Fri, 28 Feb 2025 09:38:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740735505; cv=none; b=M9yG5vgCMaumwkw9vmJqh1MzBBnKqgdOS77XoXrsLp2Qt1pl8quWNzg4Pe5gS/TYlGpNWojnW6FKxyuDaxz23Gnh9FGBBSSfYjVoN9R961KyJNeCnpkNe0oBlnrNg0xIfkOYIJSnmpNav+vFSzH6XAq4NfL+ol0nlEKDN5SIayk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740735505; c=relaxed/simple; bh=cXXYLWxWcETYA3JP92xi9LGJX/+09zhX17UC5Rt7H30=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=VyFSNHWc30ZWZ6of1hXRx81bpd7eo2z5Oh7elrUgyOvRPwgNJNHZRY/rVqUOUWSjRpXDbPXCs3oTUdfNo8ts3fmJGeOeGMzooPZEvhzovmyYfPPTC1t3E+C3oKqLVHRw1bOpUeRhuAJgig/F/AYq4m5OPamWHL2wGHC2N4EuJzw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fSkqxvqY; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fSkqxvqY" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-abee50621ecso260212166b.0 for ; Fri, 28 Feb 2025 01:38:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740735501; x=1741340301; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=kAbBHBzTpenwYQ3xIDx+RFfsaRXN6FerVlZhMl5YALM=; b=fSkqxvqYgyT28bH4q5/3FMvvvx4m53sFPcRW4zaQ0pV1TpSDLjpmAbrf9nYcHa0a3y Y86bm0cBb0jKIP+JJqyQSK8eyvJSHpRgNY+S7G6SbB1Cn+/ZkFDA0B7SGpWg0lu0uYEy RuT8h9LXu43yKRfYbL1Akh6EbSIGpctzE20ETHwUDKtqbnXtI5ySDeRsxvJvP16mqVd1 BZbWU8Cmk/lQ+BU6eWbVkim6vBBXijo2UiSR2mtcO790h1XQmjxHT3zs+kozPGfc7oRo dRSyz/ZBoZovtnxmYtG8GvZQbi/3Fo70+I0YWW6nnqRLXWFdx965uQDivlTpTIh5m8iU q05A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740735501; x=1741340301; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kAbBHBzTpenwYQ3xIDx+RFfsaRXN6FerVlZhMl5YALM=; b=Vz5bnXsjnNdkNtCGcMvDCfef/YFoiaOnTwjSqXiO1bUUHS+doVFon2N2r88VOicUTJ QeLQhcqFC7vcHH5QFefXrL0e0YzMk+ytDErySEyQXwrp+HlJ2veisWzzw7NePmpNGln8 VBSuWmU1HZNaP39Fu5GgQ+h9BZ+amUOKroyJDFbS6GoMLnu8ChgLBxrku3OgAjrUPh15 04D4LReoth4aAuRhBRUfzkylLm9J8SmyRu6baaScJM7U0rrAYsy27MJsk5KaaTNkm496 DE6f64KOTiWy+ZQw/BlfnujM5cqTIHt2lGcClxMihLUWOCvI5stZtTRceI7hkziI6bl1 mImg== X-Forwarded-Encrypted: i=1; AJvYcCVNO/A329Z+HxjhMXT7YkOmGJhtzKKn5B5Wsz15qOCaDps8e9m9mlDJCDicw+il34UV84ESRIivsOm5uYU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7wq+ODuUohqH3sX2S/tRb4LG8SBYNgr5ssf8xTX2C94HDVosU yDNSbCsIsourHWD03rNtvAowDIoJwZraxZJvTixQZ0oT0Ihihs94VVg3MSPq1II= X-Gm-Gg: ASbGncvgmEje0LYmcqiyTSEY2dEEio7Fpy6hHAShOUQpcpreNkXtq1+sWakAjd0kvDs o7rYiJxJ0oPmYypOUCppon6D3ZU1kMziKnUecDDI+Zj3TErhpAvHPudehTAQtfb3M0UBGecznCb xwls+kseAZTLMJibetnbbXzLr1RgCkaTgmMrOdH7xoLpCulPbI6BEylh9KCS7O+vYO2Og2BUSzi OEkEa7gxhl+P+mlzcvA+CaTdphRIpFX848O1/FV41WPtQFZN1k+GotLl+Wnvvzt5iPdDND2W5LF QUXyFVZtZZhAM3hd8+wb9T1Zb0rDygI= X-Google-Smtp-Source: AGHT+IFG/wAFc+7a3BTiB3lyA+ckJ1OhlFHzEfmEQnuDRhG6Sr2tZqzqalibYqvITqld8TmExotXDg== X-Received: by 2002:a17:907:2d8a:b0:aab:9430:40e9 with SMTP id a640c23a62f3a-abf2659d531mr240459266b.32.1740735501401; Fri, 28 Feb 2025 01:38:21 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-abf0c0dc5ebsm263013666b.73.2025.02.28.01.38.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 01:38:20 -0800 (PST) Date: Fri, 28 Feb 2025 12:38:17 +0300 From: Dan Carpenter To: Anusha Srivatsa Cc: Maxime Ripard , Dave Stevenson , =?iso-8859-1?Q?Ma=EDra?= Canal , Raspberry Pi Kernel Maintenance , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] drm/vc4: hdmi: Fix some NULL vs IS_ERR() bugs Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The devm_platform_ioremap_resource_byname() function doesn't return NULL, it returns error pointers. Update the checking to match. Fixes: b93f07cf090a ("drm/vc4: move to devm_platform_ioremap_resource() usa= ge") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/vc4/vc4_hdmi.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index d20e5c53ba75..37238a12baa5 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -2928,8 +2928,8 @@ static int vc5_hdmi_init_resources(struct drm_device = *drm, =20 vc4_hdmi->hdmicore_regs =3D devm_platform_ioremap_resource_byname(pdev, "hdmi"); - if (!vc4_hdmi->hdmicore_regs) - return -ENOMEM; + if (IS_ERR(vc4_hdmi->hdmicore_regs)) + return PTR_ERR(vc4_hdmi->hdmicore_regs); =20 /* This is shared between both HDMI controllers. Cannot * claim for both instances. Lets not convert to using @@ -2946,33 +2946,33 @@ static int vc5_hdmi_init_resources(struct drm_devic= e *drm, =20 vc4_hdmi->cec_regs =3D devm_platform_ioremap_resource_byname(pdev, "cec"); - if (!vc4_hdmi->cec_regs) - return -ENOMEM; + if (IS_ERR(vc4_hdmi->cec_regs)) + return PTR_ERR(vc4_hdmi->cec_regs); =20 vc4_hdmi->csc_regs =3D devm_platform_ioremap_resource_byname(pdev, "csc"); - if (!vc4_hdmi->csc_regs) - return -ENOMEM; + if (IS_ERR(vc4_hdmi->csc_regs)) + return PTR_ERR(vc4_hdmi->csc_regs); =20 vc4_hdmi->dvp_regs =3D devm_platform_ioremap_resource_byname(pdev, "dvp"); - if (!vc4_hdmi->dvp_regs) - return -ENOMEM; + if (IS_ERR(vc4_hdmi->dvp_regs)) + return PTR_ERR(vc4_hdmi->dvp_regs); =20 vc4_hdmi->phy_regs =3D devm_platform_ioremap_resource_byname(pdev, "phy"); =20 - if (!vc4_hdmi->phy_regs) - return -ENOMEM; + if (IS_ERR(vc4_hdmi->phy_regs)) + return PTR_ERR(vc4_hdmi->phy_regs); =20 vc4_hdmi->ram_regs =3D devm_platform_ioremap_resource_byname(pdev, "packet"); - if (!vc4_hdmi->ram_regs) - return -ENOMEM; + if (IS_ERR(vc4_hdmi->ram_regs)) + return PTR_ERR(vc4_hdmi->ram_regs); =20 vc4_hdmi->rm_regs =3D devm_platform_ioremap_resource_byname(pdev, "rm"); - if (!vc4_hdmi->rm_regs) - return -ENOMEM; + if (IS_ERR(vc4_hdmi->rm_regs)) + return PTR_ERR(vc4_hdmi->rm_regs); =20 vc4_hdmi->hsm_clock =3D devm_clk_get(dev, "hdmi"); if (IS_ERR(vc4_hdmi->hsm_clock)) { --=20 2.47.2