From nobody Wed Dec 17 23:53:52 2025 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FBAF31282A for ; Mon, 13 Oct 2025 14:53:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760367236; cv=none; b=FS1njru1nNumddajPtCZQfMyDbBrin1ov19cVaShHtVH/JNaEQxsvAar2tY+B5ZVAdniRvqlQS9vMBPkPt7813TuROorDLTZQnczEp1JkKMfArw9geURcONoiUzbCB5JGyyChmESi7OkXJH/Rngskgf+2SKQkMt4yMh8MwG2Au8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760367236; c=relaxed/simple; bh=5njEvVGvRvg5n+or8A0T0TeMIvuwdSGOGUYTMwZoZrw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H6MXeUh0N8HJCYlQK2Ba3v0OLdTkwxTzhVulRVmZ6LWQ1tHE1njlek7UjXPjDZNUUym/Z+oi8ci0BD59T/gA1UoUFkl+ObP51RUVH9OshYy4hnSpcLU8Rl6H8VmnNEEa8hI0IEamsKF1eAlSNM85shByMsPmN+SCoodxztwX+JE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bYZdR/1B; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bYZdR/1B" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-46e3cdc1a6aso31765425e9.1 for ; Mon, 13 Oct 2025 07:53:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760367232; x=1760972032; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mx3rKwv8UpZmKoPpNp8c4OWFyXZ2MQ9zKc0xRf7JTbY=; b=bYZdR/1B6EnR21UtQM02QdZ/SlZlUnJJ4HgKFePQdxI8Eh4Vz5mxonv4tvx8GlyEfe QNFqDE0Hof7aL+0Jg3oW3H6WPiUMPKaN8cIc8NGDQBpMgAvthmHzN1euRS2nEHuxbeFz ueQfYEXZB+DIC4i7aXyx3HfYzKhQAyj8QCqpqhoHSVAeEet06Gm6WL/yARIQ7D2syVcm eYIzEEyZrR4F76VxwW1m3QECHx4dITHvTH/Ipc4uu4tzrxtm/vbGe+Z5rwD8hpVkaSKP XZYn9xO45FjKRQMDpCUtRS7PZjJVtGsSXz1bVqCy/mxVcAhFrxuhShn6pd50eloLt5bv eM/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760367232; x=1760972032; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mx3rKwv8UpZmKoPpNp8c4OWFyXZ2MQ9zKc0xRf7JTbY=; b=W84nWhqqzESWZM3NIqDuGzEodOQ/mAuYg/iDRJGPVh/POFKZtHYJgPnfeD9pscuzyk jF+iRnINX/xNGj3l3CgeBUaLNkMCVz5Kdhew5WEAK0NRo21LzCuQ7CptshYP7i4OC+kQ 0goelojk/P1qLOUN08mwGKaWnI0XUWw0oXNmIZfRhngs9VfHRNxppXHDvWoxqPDG+Sm7 TTfGrwbyc5MjD3R5vGrQjo9NzR4VLvbFRj8COSZKjhe+NSBKOk2brEjMejne5lhP2EY9 vHEzKpzSH4Hts1QsNx3dpicEqDZb6pM6AQg315JyTpSYDV+fwpx21jgB++JqimnlpU29 e3Sg== X-Forwarded-Encrypted: i=1; AJvYcCU4Cfxt/eD397u9q6EnxoaylpzfMI9iNFnact4VB8En/vs850i1cN1KEYfJvIYZ5w6X1MbO/Rd1VrWBX1E=@vger.kernel.org X-Gm-Message-State: AOJu0YzKGGo1DUmhpNavffxinGL0K13NZAkETB2cPxahg3ByD+Y9wWiD 7aMM4QGD2uZg7ZRs45ZJePImzFIpbNil2nZy77Ttlvxi+GdcBr+WN7E+ X-Gm-Gg: ASbGncveeps+3t3RAvh+U8pmZmNjC4m3fo9SQ2vRR2c27AZTLxnGnpl4UfC0U6d94Md eOec1xzbPe2fcUhNMOB1xq8ZvLfYqWFozZa32qNTu1SrYQG69oxtY27yDb1KAqdYuw/fUQnrcup 0RUxBB/pRpRU+JoPR7RNu24sZ44vpaVgF3k96/7ZIMGXh1dLjT11rMUqauDZQZtNgRFOOMDnZNx wAhGsEwA61wb6M2UCCw61Xhg4fmsQJ6XgYvpEWjkSzqmIjNFxQoYrXFUNcVWaPSAT6glFENOzg3 arzBUj2/76gx79OQSiXma/4c0IlPyUIx7nL0EA24wl0D7BujE17wdzGXo9y6UYLYXuqI3OPcgjd Tv3PZjJiiX25a4VdoZ2B/K2KvHOwH39D3BL8= X-Google-Smtp-Source: AGHT+IE3H2i/VyBQ+RSV0mjlmorIJH69FGvZYgt2TChv0GqkPZvFJ5kiUJWgTBqn/GwNWnmRiH+YrQ== X-Received: by 2002:a05:600c:2287:b0:45d:d86b:b386 with SMTP id 5b1f17b1804b1-46fa29f13dfmr128925175e9.14.1760367231769; Mon, 13 Oct 2025 07:53:51 -0700 (PDT) Received: from 127.com ([2620:10d:c092:600::1:eb09]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce5e0e70sm18641085f8f.40.2025.10.13.07.53.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Oct 2025 07:53:50 -0700 (PDT) From: Pavel Begunkov To: netdev@vger.kernel.org Cc: Andrew Lunn , Jakub Kicinski , davem@davemloft.net, Eric Dumazet , Paolo Abeni , Simon Horman , Donald Hunter , Michael Chan , Pavan Chebbi , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Joshua Washington , Harshitha Ramamurthy , Jian Shen , Salil Mehta , Jijie Shao , Sunil Goutham , Geetha sowjanya , Subbaraya Sundeep , hariprasad , Bharat Bhushan , Saeed Mahameed , Tariq Toukan , Mark Bloch , Leon Romanovsky , Alexander Duyck , kernel-team@meta.com, Ilias Apalodimas , Joe Damato , David Wei , Willem de Bruijn , Mina Almasry , Pavel Begunkov , Breno Leitao , Dragos Tatulea , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-rdma@vger.kernel.org, Jonathan Corbet Subject: [PATCH net-next v4 16/24] eth: bnxt: always set the queue mgmt ops Date: Mon, 13 Oct 2025 15:54:18 +0100 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jakub Kicinski Core provides a centralized callback for validating per-queue settings but the callback is part of the queue management ops. Having the ops conditionally set complicates the parts of the driver which could otherwise lean on the core to feed it the correct settings. Always set the queue ops, but provide no restart-related callbacks if queue ops are not supported by the device. This should maintain current behavior, the check in netdev_rx_queue_restart() looks both at op struct and individual ops. Signed-off-by: Jakub Kicinski [pavel: reflow mgmt ops assignment] Reviewed-by: Mina Almasry Signed-off-by: Pavel Begunkov --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethern= et/broadcom/bnxt/bnxt.c index 61e5c866d946..bd06171cc86c 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -16187,6 +16187,9 @@ static const struct netdev_queue_mgmt_ops bnxt_queu= e_mgmt_ops =3D { .ndo_queue_stop =3D bnxt_queue_stop, }; =20 +static const struct netdev_queue_mgmt_ops bnxt_queue_mgmt_ops_unsupp =3D { +}; + static void bnxt_remove_one(struct pci_dev *pdev) { struct net_device *dev =3D pci_get_drvdata(pdev); @@ -16840,6 +16843,8 @@ static int bnxt_init_one(struct pci_dev *pdev, cons= t struct pci_device_id *ent) =20 if (BNXT_SUPPORTS_NTUPLE_VNIC(bp)) bp->rss_cap |=3D BNXT_RSS_CAP_MULTI_RSS_CTX; + + dev->queue_mgmt_ops =3D &bnxt_queue_mgmt_ops_unsupp; if (BNXT_SUPPORTS_QUEUE_API(bp)) dev->queue_mgmt_ops =3D &bnxt_queue_mgmt_ops; dev->request_ops_lock =3D true; --=20 2.49.0