From nobody Fri Dec 19 15:34:15 2025 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010034.outbound.protection.outlook.com [52.101.193.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DFDD22B8BD; Mon, 13 Oct 2025 00:06:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.34 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760313987; cv=fail; b=t5024+NNa+ld3Tta30AyoJCiEsLPGsOOPZnsW//ng7URO0FYZOQT2Y1Zw6PFFWo+fgRqnpvxK6o7CDiM+P4U65m897Sq7Rqv2WNKf2Lw8ApmGKXHzhBugjdsezBHIYqYgKSTXIQYBubmbtJ96G/dwtXlXtOpgvmltDKfmD8nWY0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760313987; c=relaxed/simple; bh=l85OzGTHGQx90wKZifIzDxaJdN6/eth3r+nfwxtiOqA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AOlUVSzJWQs6EjJFO4ELaQNygDt0rY7lle+kGzBG+bq4PSTsKCYamk+zUQC7oTk/t35Kmlz8iKAYDGjvLHSqTodO16JW0jz0S4bBc+aL8yzgqm/MI+FqIpjtRBwb2OIW6s7WaHQF4WRp903F8YTrg5cMF3XM/D+W2itsufm5lBA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=s2RsHXKY; arc=fail smtp.client-ip=52.101.193.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="s2RsHXKY" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Jv48/yzJK/5AeXNIV3PZ2sAQXu61Ftm/rqK/SeTzoSC5NpqJUzk4njosRCU8PYHf21+o8kD7/2Il464w+AYX+WCfvxEX3RjuYhCNEWWwdH8eePE5VAkpJkWlcf1YUsgGIxha7+V3PCOV0+FDVCReOIvUpNfxPhK2Oycgr5DdISp2xujgtLWVf0bqB1emDxwI6XjMr2LaobE3RBK+6dt1XdjjN3yehCHUDxbd6gkKVnap2v//i+crsnq6H3O5C15VAYCsmnzGeXSo9jpQNPaEzYQDAK3M1ns4yZ3xS6SUiCr7+S1Y0ke6uG+4YHM/2EbbxRmq6+N1P6pRebNgsVD2Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UQcEgu+J3hBOIAoxI2CEU4Duvjq/BJL2HgFxPHdDMGE=; b=ZHFeRZDjMbKHWOguXCgQ97H3IyIAJOta/kKoUv1MbPpYvj8M0J9ZDX0Dzt02GzVFMo778doUhlGeL4eeGSK61ZCGWIlNQzPx4+1E1DpvfZ0Cv6qGjQ1gdCDiUvXEPSuSKKvek5kB1D12WHKC4iNoaps9N4l/UUcrPVNHO+7Cx3Vn5EOG/LTiTgSn/oJlbQST3Em1tZzJNb9MnhD4ndmV1tPjRbao6NNBoy3FW1As1wPYpsqwE7xgSKMM6vgEjVDZXVJ5YRc6ngUV7eWRp7mjxsiviKkfCNtU0eBubTgzdK6PVUkKNEjmKprp/AucZ2qIzcCCpRFAcn+iLEP+ftx5/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=8bytes.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UQcEgu+J3hBOIAoxI2CEU4Duvjq/BJL2HgFxPHdDMGE=; b=s2RsHXKY4pzTjEZuS/xs+Ab8MxcZMRVr7y7ofqFiVyd/oxPZMnfjzLio7qHge+V8/WQcmvB777snlQuFd9ZtZLCMalyEhI5J4Lct+K7v1ima4kmOxOc2vc8jxF1gBGc2St0dql58C6hLwVUq9SLfqyt/mxyCZMCcOH8ER5AgFlD7NW/oiIMUEy0htl9Z3dGWTAJJS6TUTddC21OeI4DQrx+PsCXfWwBUIot+sqwCEf+VndanffetpJA7XB65x+eBtLW6dKQTFBRTVad61VBugZO8kFLKzkZ54dMf1+t8SsCUwfczmAAbTHqbwycmcg+/MXyAmQc3lztRK17JhFkDbA== Received: from PH7PR17CA0025.namprd17.prod.outlook.com (2603:10b6:510:323::27) by BL1PR12MB5754.namprd12.prod.outlook.com (2603:10b6:208:391::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9203.11; Mon, 13 Oct 2025 00:06:20 +0000 Received: from CY4PEPF0000EE3E.namprd03.prod.outlook.com (2603:10b6:510:323:cafe::67) by PH7PR17CA0025.outlook.office365.com (2603:10b6:510:323::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9203.12 via Frontend Transport; Mon, 13 Oct 2025 00:06:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000EE3E.mail.protection.outlook.com (10.167.242.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9228.7 via Frontend Transport; Mon, 13 Oct 2025 00:06:19 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.34; Sun, 12 Oct 2025 17:06:07 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 12 Oct 2025 17:06:02 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Sun, 12 Oct 2025 17:06:00 -0700 From: Nicolin Chen To: , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v1 13/20] iommu/rockchip-iommu: Implement rk_iommu_identity_test_dev Date: Sun, 12 Oct 2025 17:05:10 -0700 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE3E:EE_|BL1PR12MB5754:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b1f14b6-419a-495b-da9a-08de09ec564f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|7416014|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bq8wr4kHW8rxBy7GWByREVIae9eefvG6v/znWIiWbPu1n823qw1n0WrUC4hS?= =?us-ascii?Q?O2FHqjPnZl1MjvrX6sc68sTzKVEVEei+C+NBpBXNRz1PddtFDortz75y4YDl?= =?us-ascii?Q?z+G1EhHRPx0m8gMOjo/rf1j8+655jQUHNzEVtvHKJkuVMkGU2lxvaRdGn3tr?= =?us-ascii?Q?5gKmbisZMpmXdWyGM7kJW/Fn1gadZuu8D5GP2Yda6G+rpEB4wDCycXEMr38w?= =?us-ascii?Q?J2ZlKx0sIQ0DjYBv1fm1Im1DnfoP78j8lmGsF79IfrCGMVLkS5I+h7Roigzh?= =?us-ascii?Q?Lm4Yel4R/ScIN3crWk79vaYvcRYybnepnNIF4/+KxH2l7KMjc1u3vsyrnTQl?= =?us-ascii?Q?d6hs6uKCJTFw0uDZY+ScxsuXiojxJTsODM3JuoFZOjPY0ml+qLrx5ommZl1M?= =?us-ascii?Q?dU3JkPkx9M6qZk+jXdt779o7DUcoKoRsRCa2y3rBzp30FgQTjuFsLJ3SHKkm?= =?us-ascii?Q?f9R2CdVLEKzcRP1UO4KpZw0iX32YMrR8xYMSt6MkH5ErhixTQcHvkV8wsRSo?= =?us-ascii?Q?EVEo+DAqURYanEOepy+9jd88ILekMokhkYyneAUsZ/QYoBfFfU31BYH9VpdO?= =?us-ascii?Q?pDldU9Teb4bmAF6fsYzKm58qGDQwbHwmdF3fKtFBO9P9KyDwpuHd2Zeyykp+?= =?us-ascii?Q?rGnXdAwL4hpOid3imv3nbF2e7dWMPH8aHeurFG/NXboxtPrFHNQs9Tktcl26?= =?us-ascii?Q?AJDbV560xBmFLSXNwn0Af8NYkiPlo63/9QFwL/VWfuspddqlrNzHn8FJEm4g?= =?us-ascii?Q?hgHIzYqSLHioLf2/AEA0g30faEBCD5TV5ALefhd/UID3C1gOKWxLKBBajku0?= =?us-ascii?Q?h0qAsn8f8VFtl5KrmpCBuyzku+em2MjjK8XReMn3HL/F4lJEF4pvSjlPE06e?= =?us-ascii?Q?0P2tYSivYUd6HRcsL3YI/FbroNqlAmGW+A8wzi2tU2+bbYOpy9kBj8oD7E+m?= =?us-ascii?Q?Xw+E8NE/CaSzifVM/uQTEVKkTYdv9PHA24T/o0L+RFg1C6THkGgvdEIA804d?= =?us-ascii?Q?Zx/ZH8t4FQQpIm97OpycGXvwi4TCc9CBt6NCEaHa6gmZ4Lb9MmI4aRcQ4HM1?= =?us-ascii?Q?Eh+9E5PM3b+8rjWbOBoHIa5FPSpcUq3d94CSeE3iU3FKCJsHKFmr0zjfcTFf?= =?us-ascii?Q?Bj3LyVCwi/As0stghs4+Gj+LoejOwd6wKRf4o70nmDOtH3GxpMhSv3maxSWs?= =?us-ascii?Q?e3LiB3Woh+Hvm5FU49dDprT3zTg+1smyiNFLfIEMZPv/tuHhWn8hCrRYESsd?= =?us-ascii?Q?5Rz1C7x06+tM/2wYxI1CnM2anXaj8eorT46H9YmoI2V517BkRTm5NNmVE92p?= =?us-ascii?Q?Myg99qpy3UEuZHZ8oZg7pQeEQJaSH3AhIpko1hsJU1OH7ct2SNr64FdPgqsW?= =?us-ascii?Q?bHAWzQps6ha9dUSjK7HVS3djjR7xWmoGyycaIEPi0EogMji3qaufPcWIF0zK?= =?us-ascii?Q?fH2Eaj+wBuRB/HZKagCarTGotJCdDVPCIrryTYwdty7QfChZbdnNYobrh2Mm?= =?us-ascii?Q?yFwrkPNe2ArBdiiWU4wrEKKUmMz29UgYXups0M06XigsDOQKbY4tDWJlSUoZ?= =?us-ascii?Q?g3wLQKGz91K+Kyj5QE8=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(7416014)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2025 00:06:19.7447 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b1f14b6-419a-495b-da9a-08de09ec564f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE3E.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5754 Content-Type: text/plain; charset="utf-8" Move sanity and compatibility tests from the attach_dev callback to the new test_dev callback function. The IOMMU core makes sure an attach_dev call must be invoked after a successful test_dev call. Signed-off-by: Nicolin Chen --- drivers/iommu/rockchip-iommu.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c index 85f3667e797c3..89cb65f76fe52 100644 --- a/drivers/iommu/rockchip-iommu.c +++ b/drivers/iommu/rockchip-iommu.c @@ -959,20 +959,25 @@ static int rk_iommu_enable(struct rk_iommu *iommu) return ret; } =20 +static int rk_iommu_identity_test_dev(struct iommu_domain *domain, + struct device *dev, ioasid_t pasid, + struct iommu_domain *old) +{ + /* Allow 'virtual devices' (eg drm) to detach from domain */ + if (!rk_iommu_from_dev(dev)) + return -ENODEV; + return 0; +} + static int rk_iommu_identity_attach(struct iommu_domain *identity_domain, struct device *dev, struct iommu_domain *old) { - struct rk_iommu *iommu; + struct rk_iommu *iommu =3D rk_iommu_from_dev(dev); struct rk_iommu_domain *rk_domain; unsigned long flags; int ret; =20 - /* Allow 'virtual devices' (eg drm) to detach from domain */ - iommu =3D rk_iommu_from_dev(dev); - if (!iommu) - return -ENODEV; - rk_domain =3D to_rk_domain(iommu->domain); =20 dev_dbg(dev, "Detaching from iommu domain\n"); @@ -997,6 +1002,7 @@ static int rk_iommu_identity_attach(struct iommu_domai= n *identity_domain, } =20 static struct iommu_domain_ops rk_identity_ops =3D { + .test_dev =3D rk_iommu_identity_test_dev, .attach_dev =3D rk_iommu_identity_attach, }; =20 --=20 2.43.0